Socket::write() - Code Metrics - Inspection of "Test socket write without open" - vend/statsd - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 11139b...2b076b )

by Dominic

created 2015-12-01 01:00 UTC

Socket::write() A

↳ Parent: Socket

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	9.4286
cc	2
eloc	4
nc	2
nop	1
crap	2

<?php

namespace Vend\Statsd;

class Socket
{
    /**
     * Being fairly conservative here:
     *
     *  Implementations of the IP protocol are not required to be capable of handling arbitrarily large packets. In
     *  theory, the maximum possible IP packet size is 65,535 octets, but the standard only requires that implementations
     *  support at least 576 octets.
     *
     * via http://stackoverflow.com/a/3712822/10831
     *
     * Over this limit, we'll just fragment at the application layer, and send more than one packet.
     */
    const MAX_DATAGRAM_SIZE = 500;

    protected $host;
    protected $port;
    protected $socket = null;

    /**
     * Socket constructor
     *
     * @param string $host
     * @param int    $port
     */
    public function __construct($host = '127.0.0.1', $port = 8125)
    {
        $this->host = $host;
        $this->port = $port;
        $this->socket = null;
    }

    /**
     * @return void
     */
    public function open()
    {
        $this->socket = socket_create(AF_INET, SOCK_DGRAM, SOL_UDP) ?: null;
    }

    /**
     * @param string $data
     * @return int|null Number of bytes written

     */
    public function write($data)
    {
        if (!$this->socket) {
            $this->open();
        }

        return socket_sendto($this->socket, $data, strlen($data), 0, $this->host, $this->port);
    }

    /**
     * Closes the socket
     */
    public function close()
    {
        if ($this->socket && is_resource($this->socket)) {
            socket_close($this->socket);
        }

        $this->socket = null;
    }
}


1		<?php
2
3		namespace Vend\Statsd;
4
5		class Socket
6		{
7		/**
8		* Being fairly conservative here:
9		*
10		* Implementations of the IP protocol are not required to be capable of handling arbitrarily large packets. In
11		* theory, the maximum possible IP packet size is 65,535 octets, but the standard only requires that implementations
12		* support at least 576 octets.
13		*
14		* via http://stackoverflow.com/a/3712822/10831
15		*
16		* Over this limit, we'll just fragment at the application layer, and send more than one packet.
17		*/
18		const MAX_DATAGRAM_SIZE = 500;
19
20		protected $host;
21		protected $port;
22		protected $socket = null;
23
24		/**
25		* Socket constructor
26		*
27		* @param string $host
28		* @param int $port
29		*/
30	4	public function __construct($host = '127.0.0.1', $port = 8125)
31		{
32	4	$this->host = $host;
33	4	$this->port = $port;
34	4	$this->socket = null;
35	4	}
36
37		/**
38		* @return void
39		*/
40	2	public function open()
41		{
42	2	$this->socket = socket_create(AF_INET, SOCK_DGRAM, SOL_UDP) ?: null;
43	2	}
44
45		/**
46		* @param string $data
47		* @return int\|null Number of bytes written
		0 ignored issues – show Documentation introduced 2015-12-01 01:04 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `integer`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
48		*/
49	2	public function write($data)
50		{
51	2	if (!$this->socket) {
52	1	$this->open();
53	1	}
54
55	2	return socket_sendto($this->socket, $data, strlen($data), 0, $this->host, $this->port);
56		}
57
58		/**
59		* Closes the socket
60		*/
61	2	public function close()
62		{
63	2	if ($this->socket && is_resource($this->socket)) {
64	2	socket_close($this->socket);
65	2	}
66
67	2	$this->socket = null;
68	2	}
69		}
70

vend / statsd

GitHub Access Token became invalid

Push — master ( 11139b...2b076b )

Socket::write() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like