| Conditions | 2 |
| Paths | 2 |
| Total Lines | 156 |
| Code Lines | 152 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 177 | protected function convertFriendlyTimezoneToFull($tz) |
||
| 178 | { |
||
| 179 | $timezones = [ |
||
| 180 | "International Date Line West" => "Pacific/Midway", |
||
| 181 | "Midway Island" => "Pacific/Midway", |
||
| 182 | "American Samoa" => "Pacific/Pago_Pago", |
||
| 183 | "Hawaii" => "Pacific/Honolulu", |
||
| 184 | "Alaska" => "America/Juneau", |
||
| 185 | "Pacific Time (US & Canada)" => "America/Los_Angeles", |
||
| 186 | "Tijuana" => "America/Tijuana", |
||
| 187 | "Mountain Time (US & Canada)" => "America/Denver", |
||
| 188 | "Arizona" => "America/Phoenix", |
||
| 189 | "Chihuahua" => "America/Chihuahua", |
||
| 190 | "Mazatlan" => "America/Mazatlan", |
||
| 191 | "Central Time (US & Canada)" => "America/Chicago", |
||
| 192 | "Saskatchewan" => "America/Regina", |
||
| 193 | "Guadalajara" => "America/Mexico_City", |
||
| 194 | "Mexico City" => "America/Mexico_City", |
||
| 195 | "Monterrey" => "America/Monterrey", |
||
| 196 | "Central America" => "America/Guatemala", |
||
| 197 | "Eastern Time (US & Canada)" => "America/New_York", |
||
| 198 | "Indiana (East)" => "America/Indiana/Indianapolis", |
||
| 199 | "Bogota" => "America/Bogota", |
||
| 200 | "Lima" => "America/Lima", |
||
| 201 | "Quito" => "America/Lima", |
||
| 202 | "Atlantic Time (Canada)" => "America/Halifax", |
||
| 203 | "Caracas" => "America/Caracas", |
||
| 204 | "La Paz" => "America/La_Paz", |
||
| 205 | "Santiago" => "America/Santiago", |
||
| 206 | "Newfoundland" => "America/St_Johns", |
||
| 207 | "Brasilia" => "America/Sao_Paulo", |
||
| 208 | "Buenos Aires" => "America/Argentina/Buenos_Aires", |
||
| 209 | "Montevideo" => "America/Montevideo", |
||
| 210 | "Georgetown" => "America/Guyana", |
||
| 211 | "Greenland" => "America/Godthab", |
||
| 212 | "Mid-Atlantic" => "Atlantic/South_Georgia", |
||
| 213 | "Azores" => "Atlantic/Azores", |
||
| 214 | "Cape Verde Is." => "Atlantic/Cape_Verde", |
||
| 215 | "Dublin" => "Europe/Dublin", |
||
| 216 | "Edinburgh" => "Europe/London", |
||
| 217 | "Lisbon" => "Europe/Lisbon", |
||
| 218 | "London" => "Europe/London", |
||
| 219 | "Casablanca" => "Africa/Casablanca", |
||
| 220 | "Monrovia" => "Africa/Monrovia", |
||
| 221 | "UTC" => "Etc/UTC", |
||
| 222 | "Belgrade" => "Europe/Belgrade", |
||
| 223 | "Bratislava" => "Europe/Bratislava", |
||
| 224 | "Budapest" => "Europe/Budapest", |
||
| 225 | "Ljubljana" => "Europe/Ljubljana", |
||
| 226 | "Prague" => "Europe/Prague", |
||
| 227 | "Sarajevo" => "Europe/Sarajevo", |
||
| 228 | "Skopje" => "Europe/Skopje", |
||
| 229 | "Warsaw" => "Europe/Warsaw", |
||
| 230 | "Zagreb" => "Europe/Zagreb", |
||
| 231 | "Brussels" => "Europe/Brussels", |
||
| 232 | "Copenhagen" => "Europe/Copenhagen", |
||
| 233 | "Madrid" => "Europe/Madrid", |
||
| 234 | "Paris" => "Europe/Paris", |
||
| 235 | "Amsterdam" => "Europe/Amsterdam", |
||
| 236 | "Berlin" => "Europe/Berlin", |
||
| 237 | "Bern" => "Europe/Berlin", |
||
| 238 | "Rome" => "Europe/Rome", |
||
| 239 | "Stockholm" => "Europe/Stockholm", |
||
| 240 | "Vienna" => "Europe/Vienna", |
||
| 241 | "West Central Africa" => "Africa/Algiers", |
||
| 242 | "Bucharest" => "Europe/Bucharest", |
||
| 243 | "Cairo" => "Africa/Cairo", |
||
| 244 | "Helsinki" => "Europe/Helsinki", |
||
| 245 | "Kyiv" => "Europe/Kiev", |
||
| 246 | "Riga" => "Europe/Riga", |
||
| 247 | "Sofia" => "Europe/Sofia", |
||
| 248 | "Tallinn" => "Europe/Tallinn", |
||
| 249 | "Vilnius" => "Europe/Vilnius", |
||
| 250 | "Athens" => "Europe/Athens", |
||
| 251 | "Istanbul" => "Europe/Istanbul", |
||
| 252 | "Minsk" => "Europe/Minsk", |
||
| 253 | "Jerusalem" => "Asia/Jerusalem", |
||
| 254 | "Harare" => "Africa/Harare", |
||
| 255 | "Pretoria" => "Africa/Johannesburg", |
||
| 256 | "Kaliningrad" => "Europe/Kaliningrad", |
||
| 257 | "Moscow" => "Europe/Moscow", |
||
| 258 | "St. Petersburg" => "Europe/Moscow", |
||
| 259 | "Volgograd" => "Europe/Volgograd", |
||
| 260 | "Samara" => "Europe/Samara", |
||
| 261 | "Kuwait" => "Asia/Kuwait", |
||
| 262 | "Riyadh" => "Asia/Riyadh", |
||
| 263 | "Nairobi" => "Africa/Nairobi", |
||
| 264 | "Baghdad" => "Asia/Baghdad", |
||
| 265 | "Tehran" => "Asia/Tehran", |
||
| 266 | "Abu Dhabi" => "Asia/Muscat", |
||
| 267 | "Muscat" => "Asia/Muscat", |
||
| 268 | "Baku" => "Asia/Baku", |
||
| 269 | "Tbilisi" => "Asia/Tbilisi", |
||
| 270 | "Yerevan" => "Asia/Yerevan", |
||
| 271 | "Kabul" => "Asia/Kabul", |
||
| 272 | "Ekaterinburg" => "Asia/Yekaterinburg", |
||
| 273 | "Islamabad" => "Asia/Karachi", |
||
| 274 | "Karachi" => "Asia/Karachi", |
||
| 275 | "Tashkent" => "Asia/Tashkent", |
||
| 276 | "Chennai" => "Asia/Kolkata", |
||
| 277 | "Kolkata" => "Asia/Kolkata", |
||
| 278 | "Mumbai" => "Asia/Kolkata", |
||
| 279 | "New Delhi" => "Asia/Kolkata", |
||
| 280 | "Kathmandu" => "Asia/Kathmandu", |
||
| 281 | "Astana" => "Asia/Dhaka", |
||
| 282 | "Dhaka" => "Asia/Dhaka", |
||
| 283 | "Sri Jayawardenepura" => "Asia/Colombo", |
||
| 284 | "Almaty" => "Asia/Almaty", |
||
| 285 | "Novosibirsk" => "Asia/Novosibirsk", |
||
| 286 | "Rangoon" => "Asia/Rangoon", |
||
| 287 | "Bangkok" => "Asia/Bangkok", |
||
| 288 | "Hanoi" => "Asia/Bangkok", |
||
| 289 | "Jakarta" => "Asia/Jakarta", |
||
| 290 | "Krasnoyarsk" => "Asia/Krasnoyarsk", |
||
| 291 | "Beijing" => "Asia/Shanghai", |
||
| 292 | "Chongqing" => "Asia/Chongqing", |
||
| 293 | "Hong Kong" => "Asia/Hong_Kong", |
||
| 294 | "Urumqi" => "Asia/Urumqi", |
||
| 295 | "Kuala Lumpur" => "Asia/Kuala_Lumpur", |
||
| 296 | "Singapore" => "Asia/Singapore", |
||
| 297 | "Taipei" => "Asia/Taipei", |
||
| 298 | "Perth" => "Australia/Perth", |
||
| 299 | "Irkutsk" => "Asia/Irkutsk", |
||
| 300 | "Ulaanbaatar" => "Asia/Ulaanbaatar", |
||
| 301 | "Seoul" => "Asia/Seoul", |
||
| 302 | "Osaka" => "Asia/Tokyo", |
||
| 303 | "Sapporo" => "Asia/Tokyo", |
||
| 304 | "Tokyo" => "Asia/Tokyo", |
||
| 305 | "Yakutsk" => "Asia/Yakutsk", |
||
| 306 | "Darwin" => "Australia/Darwin", |
||
| 307 | "Adelaide" => "Australia/Adelaide", |
||
| 308 | "Canberra" => "Australia/Melbourne", |
||
| 309 | "Melbourne" => "Australia/Melbourne", |
||
| 310 | "Sydney" => "Australia/Sydney", |
||
| 311 | "Brisbane" => "Australia/Brisbane", |
||
| 312 | "Hobart" => "Australia/Hobart", |
||
| 313 | "Vladivostok" => "Asia/Vladivostok", |
||
| 314 | "Guam" => "Pacific/Guam", |
||
| 315 | "Port Moresby" => "Pacific/Port_Moresby", |
||
| 316 | "Magadan" => "Asia/Magadan", |
||
| 317 | "Srednekolymsk" => "Asia/Srednekolymsk", |
||
| 318 | "Solomon Is." => "Pacific/Guadalcanal", |
||
| 319 | "New Caledonia" => "Pacific/Noumea", |
||
| 320 | "Fiji" => "Pacific/Fiji", |
||
| 321 | "Kamchatka" => "Asia/Kamchatka", |
||
| 322 | "Marshall Is." => "Pacific/Majuro", |
||
| 323 | "Auckland" => "Pacific/Auckland", |
||
| 324 | "Wellington" => "Pacific/Auckland", |
||
| 325 | "Nuku'alofa" => "Pacific/Tongatapu", |
||
| 326 | "Tokelau Is." => "Pacific/Fakaofo", |
||
| 327 | "Chatham Is." => "Pacific/Chatham", |
||
| 328 | "Samoa" => "Pacific/Apia" |
||
| 329 | ]; |
||
| 330 | |||
| 331 | return (array_key_exists($tz, $timezones) ? $timezones[$tz] : null); |
||
| 332 | } |
||
| 333 | } |
||
| 334 |