VasilDakov\Speedy\Service\Service\DestinationServicesRequest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Test Coverage

Coverage

50%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getRecipient()	0	3	1
A	__construct()	0	3	1

<?php

/*
 * This file is part of the Neutrino package.
 *
 * (c) Vasil Dakov <vasildakov@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace VasilDakov\Speedy\Service\Service;

use VasilDakov\Speedy\Service\Calculation\CalculationRecipient;
use VasilDakov\Speedy\Service\Calculation\CalculationSender;
use VasilDakov\Speedy\Service\Shipment\CreateShipmentRequest;
use VasilDakov\Speedy\Service\Shipment\ShipmentRecipient;
use VasilDakov\Speedy\Traits\ToArray;

/**
 * Class DestinationServicesRequest.
 *
 * @author Vasil Dakov <vasildakov@gmail.com>
 * @copyright 2009-2023 Neutrino.bg
 *
 * @version 1.0
 */
class DestinationServicesRequest extends CreateShipmentRequest
{
    use ToArray;

    private ?\DateTime $date = null;

The private property $date is not used, and could be removed.

    private ?CalculationSender $sender = null;

The private property $sender is not used, and could be removed.

    private CalculationRecipient $recipient;

    public function __construct(CalculationRecipient $recipient)
    {
        $this->recipient = $recipient;
    }

    public function getRecipient(): ShipmentRecipient
    {
        return $this->recipient;

The expression return $this->recipient returns the type VasilDakov\Speedy\Service\Calculation\CalculationRecipient which is incompatible with the type-hinted return VasilDakov\Speedy\Service\Shipment\ShipmentRecipient.

    }
}