VasilDakov\Speedy\Service\Location\Office\FindOfficeRequest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	toArray()	0	6	1
A	getCountryId()	0	3	1

<?php

declare(strict_types=1);

namespace VasilDakov\Speedy\Service\Location\Office;

use VasilDakov\Speedy\Property;
use VasilDakov\Speedy\Traits\ToArray;

/**
 * Class FindOfficeRequest.
 *
 * @author Vasil Dakov <vasildakov@gmail.com>
 * @copyright 2009-2022 Neutrino.bg
 *
 * @version 1.0
 */
class FindOfficeRequest
{
    use ToArray;

The trait VasilDakov\Speedy\Traits\ToArray requires the property $value which is not provided by VasilDakov\Speedy\Service\Location\Office\FindOfficeRequest.

    private ?int $countryId;

    private ?int $siteId;

    private ?string $name;

    public function __construct(?int $countryId = null, ?int $siteId = null, ?string $name = null)
    {
        $this->countryId = $countryId;
        $this->siteId    = $siteId;
        $this->name = $name;
    }

    /**
     * @return int
     */
    public function getCountryId(): int
    {
        return $this->countryId;

The expression return $this->countryId could return the type null which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }


    public function toArray(): array
    {
        return [
            Property::COUNTRY_ID->value => $this->countryId,
            Property::SITE_ID->value => $this->siteId,
            Property::NAME->value => $this->name,
        ];
    }
}