Issues in DummyAdapter.php (main) - Issues in main - vasildakov/shipping - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

src/Adapter/DummyAdapter.php (3 issues)

Labels

Severity

Major 3

<?php

namespace VasilDakov\Shipping\Adapter;

use VasilDakov\Shipping\Response;

class DummyAdapter implements AdapterInterface
{
    private const NAME = 'Econt';

    public function getName(): string
    {
        return self::NAME;
    }

    public function getCountries(): Response\GetCountriesResponse
    {
        // TODO: Implement getCountries() method.
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    public function getCities(array $data)
    {
        // TODO: Implement getCities() method.
    }
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}

    public function getOffices(array $data)
    {
        // TODO: Implement getOffices() method.
    }
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}

    public function track(array $data)
    {
        // TODO: Implement track() method.
    }
}

1			<?php
2
3			namespace VasilDakov\Shipping\Adapter;
4
5			use VasilDakov\Shipping\Response;
6
7			class DummyAdapter implements AdapterInterface
8			{
9			private const NAME = 'Econt';
10
11			public function getName(): string
12			{
13			return self::NAME;
14			}
15
16			public function getCountries(): Response\GetCountriesResponse
17			{
18			// TODO: Implement getCountries() method.
19			}
			0 ignored issues – show Bug Best Practice introduced 2023-12-28 18:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `VasilDakov\Shipping\Response\GetCountriesResponse`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
20
21			public function getCities(array $data)
22			{
23			// TODO: Implement getCities() method.
24			}
			0 ignored issues – show Bug Best Practice introduced 2023-12-30 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `ImplicitReturnNode` returns the type `null` which is incompatible with the return type mandated by `VasilDakov\Shipping\Adap...rInterface::getCities()` of `VasilDakov\Shipping\Response\GetCitiesResponse`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
25
26			public function getOffices(array $data)
27			{
28			// TODO: Implement getOffices() method.
29			}
			0 ignored issues – show Bug Best Practice introduced 2024-01-09 16:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `ImplicitReturnNode` returns the type `null` which is incompatible with the return type mandated by `VasilDakov\Shipping\Adap...Interface::getOffices()` of `VasilDakov\Shipping\Response\GetOfficesResponse`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
30
31			public function track(array $data)
32			{
33			// TODO: Implement track() method.
34			}
35			}

vasildakov / shipping

Issues (19)

src/Adapter/DummyAdapter.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like