VasilDakov\Shipping\Adapter\EcontAdapter::getCities()

Complexity

Conditions	3
Paths	2

Size

Total Lines	45
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	33
CRAP Score	3

Importance

Changes

0

<?php
    public function getCities(Request\GetCitiesRequest $request): Response\GetCitiesResponse
    {
        $json = $this->client->getCities(new GetCitiesRequest(countryCode: $request->isoAlpha3));

        $data = $this->jsonDecode($json);

        // transform rules
        $transformer = new ArrayTransformer();
        $transformer
            ->map('id', 'id')
            ->map('country', 'country')
            ->map('postCode', 'postCode')
            ->map('name', 'name')
            ->map('nameEn', 'nameEn')
        ;

        // transform array to shipping model
        $result['cities'] = $transformer->toArrays($data['cities']);

$result was never initialized. Although not strictly required by PHP, it is generally a good practice to add $result = array(); before regardless.

        // hydrate the array
        $hydrator = new \Laminas\Hydrator\ObjectPropertyHydrator();
        $strategy = new \Laminas\Hydrator\Strategy\CollectionStrategy(
            $hydrator,
            City::class
        );
        $hydrator->addStrategy(
            'country',
            new \Laminas\Hydrator\Strategy\HydratorStrategy(
                new \Laminas\Hydrator\ReflectionHydrator(),
                Country::class
            )
        );

        $array = $strategy->hydrate($result['cities']);

        if (null !== $request->name) {
            $array = array_filter($array, function (City $city) use ($request) {
                return
                    str_starts_with($city->name, $request->name) ||

It seems like $request->name can also be of type null; however, parameter $needle of str_starts_with() does only seem to accept string, maybe add an additional type check?

It seems like $city->name can also be of type null; however, parameter $haystack of str_starts_with() does only seem to accept string, maybe add an additional type check?

                    str_starts_with($city->nameEn, $request->name)
                    ;
            });
        }

        return new Response\GetCitiesResponse($array);
    }