VasilDakov\Econt\Response\GetCitiesResponseFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	13	2

<?php

namespace VasilDakov\Econt\Response;

use VasilDakov\Econt\Exception\InvalidArgumentException;
use VasilDakov\Econt\Serializer\SerializerFactory;

use function json_decode;
use function json_last_error;

class GetCitiesResponseFactory
{
    public function __invoke(string $json): GetCitiesResponse
    {
        /** @var array $array */
        $array = json_decode($json, true);

The assignment to $array is dead and can be removed.

        if (json_last_error() !== JSON_ERROR_NONE) {
            throw new InvalidArgumentException('Invalid or malformed JSON');
        }

        $serializer = (new SerializerFactory())();

        /**  @var GetCitiesResponse $response */
        return $serializer->deserialize($json, GetCitiesResponse::class, 'json');
    }
}