Issues in telegram_main.php (master) - Issues in master - varrcan/telegram.send - Measure and Improve Code Quality continuously with Scrutinizer

Issues (31)

admin/telegram_main.php (3 issues)

Labels

Bug 3

Severity

Major 3

<?php
require_once $_SERVER['DOCUMENT_ROOT'] . '/bitrix/modules/main/include/prolog_admin_before.php';

use Bitrix\Main\Loader;
filter:
    dependency_paths: ["lib/*"]
use Bitrix\Main\Page\Asset;
filter:
    dependency_paths: ["lib/*"]
use Telegram\Send\Config;

$APPLICATION->SetTitle('Телеграм');
Loader::includeModule('telegram.send');

Config::processRequest();
$mailTemplates = Config::getMailTemplates();
$registerUser  = Config::getUser();

require_once $_SERVER['DOCUMENT_ROOT'] . '/bitrix/modules/main/include/prolog_admin_after.php';

CJSCore::Init(['jquery']);
filter:
    dependency_paths: ["lib/*"]
Asset::getInstance()->addJs('/bitrix/js/telegram.send/telegram_send.js');
?>

<div class="telegram-response" style="display:none"></div>

<form method="POST" action="" class="telegram-form">
    <div class="adm-detail-block">
        <div class="adm-detail-tabs-block">
            <span id="setting" class="adm-detail-tab adm-detail-tab-active">Настройки</span>
            <span id="user" class="adm-detail-tab">Пользователи</span>
            <span id="proxy" class="adm-detail-tab">Настройки прокси</span>
        </div>
        <div class="adm-detail-content-wrap">
            <div id="wrap-setting" class="adm-detail-content">
                <div class="adm-detail-title">Параметры модуля</div>
                <div class="adm-detail-content-item-block">
                    <table class="adm-detail-content-table edit-table">
                        <tbody>
                        <tr>
                            <td class="adm-detail-content-cell-l">
                                Включить модуль:
                            </td>
                            <td class="adm-detail-content-cell-r">
                                <input name="module_on"
                                       value="<?=Config::statusModule();?>"
                                    <?=Config::statusModule() ? 'checked="checked"' : '';?>
                                       type="checkbox"
                                       class="module_on"
                                       title="">
                            </td>
                        </tr>
                        <tr>
                            <td class="adm-detail-content-cell-l">
                                Токен бота:
                            </td>
                            <td class="adm-detail-content-cell-r">
                                <input name="token"
                                       size="50"
                                       value="<?=Config::getToken();?>"
                                       type="text"
                                       class="token"
                                       title="">
                            </td>
                        </tr>
                        <tr>
                            <td class="adm-detail-content-cell-l">
                                Почтовые события:
                            </td>
                            <td class="adm-detail-content-cell-r">
                                <select name="mail[]" class="mail" title="" size="<?=count($mailTemplates)?>" multiple>
                                    <?php foreach ($mailTemplates as $item) : ?>
                                        <option value="<?=$item['EVENT_NAME'];?>"
                                            <?=in_array($item['EVENT_NAME'], Config::getMail(), true) ? 'selected' : '';?>>
                                            <?=$item['NAME'];?>
                                        </option>
                                    <?php endforeach; ?>
                                </select>
                            </td>
                        </tr>
                        </tbody>
                    </table>
                </div>
            </div>

            <div id="wrap-user" class="adm-detail-content" style="display:none">
                <div class="adm-detail-title">Пользователи</div>
                <div class="adm-detail-content-item-block" style="height: auto; overflow-y: visible;">
                    <table class="adm-detail-content-table edit-table">
                        <tbody>
                        <tr>
                            <td colspan="2">
                                <table width="100%" cellspacing="1" cellpadding="3" border="0">
                                    <tbody>
                                    <tr>
                                        <td>
                                            <input id="updates_user" name="updates_user" value="Запросить обновления" type="button">
                                        </td>
                                    </tr>
                                    </tbody>
                                </table>
                                <br>
                                <table class="internal" width="100%" cellspacing="1" cellpadding="3" border="0">
                                    <tbody>
                                    <tr>
                                        <td class="heading"><b>ID</b></td>
                                        <td class="heading"><b>Ник</b></td>
                                        <td class="heading"><b>Имя</b></td>
                                        <td class="heading"><b>Действия</b></td>
                                    </tr>
                                    <?php if ($registerUser) : ?>
                                        <tr>
                                            <td colspan="6">Зарегистрированные пользователи</td>
                                        </tr>
                                        <?php foreach ($registerUser as $id => $val) : ?>
                                            <tr class="register_user" id="<?=$id?>">
                                                <td><?=$id?></td>
                                                <td><?=$val['nickname']?></td>
                                                <td><?=$val['username']?></td>
                                                <td><input value="Удалить" type="button" onclick="delUser(<?=$id?>);"></td>
                                            </tr>
                                        <?php endforeach; ?>
                                    <?php endif; ?>

                                    <tr class="new_user">
                                    </tr>
                                    <tr class="telegram_user">
                                    </tr>
                                    </tbody>
                                </table>
                            </td>
                        </tr>
                        </tbody>
                    </table>
                </div>
            </div>

            <div id="wrap-proxy" class="adm-detail-content" style="display:none">
                <div class="adm-detail-title">Настройки прокси</div>
                <div class="adm-detail-content-item-block">
                    <table class="adm-detail-content-table edit-table">
                        <tbody>
                        <tr>
                            <td class="adm-detail-content-cell-l">
                                Включить прокси:
                            </td>
                            <td class="adm-detail-content-cell-r">
                                <input name="proxy_on"
                                       value="<?=Config::statusProxy();?>"
                                    <?=Config::statusProxy() ? 'checked="checked"' : '';?>
                                       type="checkbox"
                                       class="proxy_on"
                                       title="">
                            </td>
                        </tr>
                        <tr>
                            <td class="adm-detail-content-cell-l">
                                IP или домен (без http):
                            </td>
                            <td class="adm-detail-content-cell-r">
                                <input name="proxy_url"
                                       size="50"
                                       value="<?=Config::proxyData()['url'];?>"
                                       type="text"
                                       class="proxy_url"
                                       title="">
                            </td>
                        </tr>
                        <tr>
                            <td class="adm-detail-content-cell-l">
                                Порт:
                            </td>
                            <td class="adm-detail-content-cell-r">
                                <input name="proxy_port"
                                       size="50"
                                       value="<?=Config::proxyData()['port'];?>"
                                       type="text"
                                       class="proxy_port"
                                       title="">
                            </td>
                        </tr>
                        <tr>
                            <td class="adm-detail-content-cell-l">
                                Пользователь:
                            </td>
                            <td class="adm-detail-content-cell-r">
                                <input name="proxy_user"
                                       size="50"
                                       value="<?=Config::proxyData()['user'];?>"
                                       type="text"
                                       class="proxy_user"
                                       title="">
                            </td>
                        </tr>
                        <tr>
                            <td class="adm-detail-content-cell-l">
                                Пароль:
                            </td>
                            <td class="adm-detail-content-cell-r">
                                <input name="proxy_pass"
                                       size="50"
                                       value="<?=Config::proxyData()['pass'];?>"
                                       type="text"
                                       class="proxy_pass"
                                       title="">
                            </td>
                        </tr>

                        </tbody>
                    </table>
                </div>
            </div>

            <div class="adm-detail-content-btns-wrap adm-detail-content-btns-pin">
                <div class="adm-detail-content-btns">
                    <a href="#" class="adm-btn adm-btn-save" id="save">Сохранить</a>
                </div>
            </div>

        </div>
    </div>
</form>

<?php
require_once $_SERVER['DOCUMENT_ROOT'] . '/bitrix/modules/main/include/epilog_admin.php';
?>


1			<?php
2			require_once $_SERVER['DOCUMENT_ROOT'] . '/bitrix/modules/main/include/prolog_admin_before.php';
3
4			use Bitrix\Main\Loader;
			0 ignored issues – show Bug introduced 2018-05-29 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `Bitrix\Main\Loader` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
5			use Bitrix\Main\Page\Asset;
			0 ignored issues – show Bug introduced 2018-05-29 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `Bitrix\Main\Page\Asset` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
6			use Telegram\Send\Config;
7
8			$APPLICATION->SetTitle('Телеграм');
9			Loader::includeModule('telegram.send');
10
11			Config::processRequest();
12			$mailTemplates = Config::getMailTemplates();
13			$registerUser = Config::getUser();
14
15			require_once $_SERVER['DOCUMENT_ROOT'] . '/bitrix/modules/main/include/prolog_admin_after.php';
16
17			CJSCore::Init(['jquery']);
			0 ignored issues – show Bug introduced 2018-05-29 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `CJSCore` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
18			Asset::getInstance()->addJs('/bitrix/js/telegram.send/telegram_send.js');
19			?>
20
21			<div class="telegram-response" style="display:none"></div>
22
23			<form method="POST" action="" class="telegram-form">
24			<div class="adm-detail-block">
25			<div class="adm-detail-tabs-block">
26			<span id="setting" class="adm-detail-tab adm-detail-tab-active">Настройки</span>
27			<span id="user" class="adm-detail-tab">Пользователи</span>
28			<span id="proxy" class="adm-detail-tab">Настройки прокси</span>
29			</div>
30			<div class="adm-detail-content-wrap">
31			<div id="wrap-setting" class="adm-detail-content">
32			<div class="adm-detail-title">Параметры модуля</div>
33			<div class="adm-detail-content-item-block">
34			<table class="adm-detail-content-table edit-table">
35			<tbody>
36			<tr>
37			<td class="adm-detail-content-cell-l">
38			Включить модуль:
39			</td>
40			<td class="adm-detail-content-cell-r">
41			<input name="module_on"
42			value="<?=Config::statusModule();?>"
43			<?=Config::statusModule() ? 'checked="checked"' : '';?>
44			type="checkbox"
45			class="module_on"
46			title="">
47			</td>
48			</tr>
49			<tr>
50			<td class="adm-detail-content-cell-l">
51			Токен бота:
52			</td>
53			<td class="adm-detail-content-cell-r">
54			<input name="token"
55			size="50"
56			value="<?=Config::getToken();?>"
57			type="text"
58			class="token"
59			title="">
60			</td>
61			</tr>
62			<tr>
63			<td class="adm-detail-content-cell-l">
64			Почтовые события:
65			</td>
66			<td class="adm-detail-content-cell-r">
67			<select name="mail[]" class="mail" title="" size="<?=count($mailTemplates)?>" multiple>
68			<?php foreach ($mailTemplates as $item) : ?>
69			<option value="<?=$item['EVENT_NAME'];?>"
70			<?=in_array($item['EVENT_NAME'], Config::getMail(), true) ? 'selected' : '';?>>
71			<?=$item['NAME'];?>
72			</option>
73			<?php endforeach; ?>
74			</select>
75			</td>
76			</tr>
77			</tbody>
78			</table>
79			</div>
80			</div>
81
82			<div id="wrap-user" class="adm-detail-content" style="display:none">
83			<div class="adm-detail-title">Пользователи</div>
84			<div class="adm-detail-content-item-block" style="height: auto; overflow-y: visible;">
85			<table class="adm-detail-content-table edit-table">
86			<tbody>
87			<tr>
88			<td colspan="2">
89			<table width="100%" cellspacing="1" cellpadding="3" border="0">
90			<tbody>
91			<tr>
92			<td>
93			<input id="updates_user" name="updates_user" value="Запросить обновления" type="button">
94			</td>
95			</tr>
96			</tbody>
97			</table>
98			<br>
99			<table class="internal" width="100%" cellspacing="1" cellpadding="3" border="0">
100			<tbody>
101			<tr>
102			<td class="heading"><b>ID</b></td>
103			<td class="heading"><b>Ник</b></td>
104			<td class="heading"><b>Имя</b></td>
105			<td class="heading"><b>Действия</b></td>
106			</tr>
107			<?php if ($registerUser) : ?>
108			<tr>
109			<td colspan="6">Зарегистрированные пользователи</td>
110			</tr>
111			<?php foreach ($registerUser as $id => $val) : ?>
112			<tr class="register_user" id="<?=$id?>">
113			<td><?=$id?></td>
114			<td><?=$val['nickname']?></td>
115			<td><?=$val['username']?></td>
116			<td><input value="Удалить" type="button" onclick="delUser(<?=$id?>);"></td>
117			</tr>
118			<?php endforeach; ?>
119			<?php endif; ?>
120
121			<tr class="new_user">
122			</tr>
123			<tr class="telegram_user">
124			</tr>
125			</tbody>
126			</table>
127			</td>
128			</tr>
129			</tbody>
130			</table>
131			</div>
132			</div>
133
134			<div id="wrap-proxy" class="adm-detail-content" style="display:none">
135			<div class="adm-detail-title">Настройки прокси</div>
136			<div class="adm-detail-content-item-block">
137			<table class="adm-detail-content-table edit-table">
138			<tbody>
139			<tr>
140			<td class="adm-detail-content-cell-l">
141			Включить прокси:
142			</td>
143			<td class="adm-detail-content-cell-r">
144			<input name="proxy_on"
145			value="<?=Config::statusProxy();?>"
146			<?=Config::statusProxy() ? 'checked="checked"' : '';?>
147			type="checkbox"
148			class="proxy_on"
149			title="">
150			</td>
151			</tr>
152			<tr>
153			<td class="adm-detail-content-cell-l">
154			IP или домен (без http):
155			</td>
156			<td class="adm-detail-content-cell-r">
157			<input name="proxy_url"
158			size="50"
159			value="<?=Config::proxyData()['url'];?>"
160			type="text"
161			class="proxy_url"
162			title="">
163			</td>
164			</tr>
165			<tr>
166			<td class="adm-detail-content-cell-l">
167			Порт:
168			</td>
169			<td class="adm-detail-content-cell-r">
170			<input name="proxy_port"
171			size="50"
172			value="<?=Config::proxyData()['port'];?>"
173			type="text"
174			class="proxy_port"
175			title="">
176			</td>
177			</tr>
178			<tr>
179			<td class="adm-detail-content-cell-l">
180			Пользователь:
181			</td>
182			<td class="adm-detail-content-cell-r">
183			<input name="proxy_user"
184			size="50"
185			value="<?=Config::proxyData()['user'];?>"
186			type="text"
187			class="proxy_user"
188			title="">
189			</td>
190			</tr>
191			<tr>
192			<td class="adm-detail-content-cell-l">
193			Пароль:
194			</td>
195			<td class="adm-detail-content-cell-r">
196			<input name="proxy_pass"
197			size="50"
198			value="<?=Config::proxyData()['pass'];?>"
199			type="text"
200			class="proxy_pass"
201			title="">
202			</td>
203			</tr>
204
205			</tbody>
206			</table>
207			</div>
208			</div>
209
210			<div class="adm-detail-content-btns-wrap adm-detail-content-btns-pin">
211			<div class="adm-detail-content-btns">
212			<a href="#" class="adm-btn adm-btn-save" id="save">Сохранить</a>
213			</div>
214			</div>
215
216			</div>
217			</div>
218			</form>
219
220			<?php
221			require_once $_SERVER['DOCUMENT_ROOT'] . '/bitrix/modules/main/include/epilog_admin.php';
222			?>
223

varrcan / telegram.send

Issues (31)

admin/telegram_main.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like