Complex classes like Schema often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Schema, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
13 | class Schema implements \JsonSerializable { |
||
14 | /// Constants /// |
||
15 | |||
16 | /** |
||
17 | * Throw a notice when extraneous properties are encountered during validation. |
||
18 | */ |
||
19 | const FLAG_EXTRA_PROPERTIES_NOTICE = 0x1; |
||
20 | |||
21 | /** |
||
22 | * Throw a ValidationException when extraneous properties are encountered during validation. |
||
23 | */ |
||
24 | const FLAG_EXTRA_PROPERTIES_EXCEPTION = 0x2; |
||
25 | |||
26 | /** |
||
27 | * @var array All the known types. |
||
28 | * |
||
29 | * If this is ever given some sort of public access then remove the static. |
||
30 | */ |
||
31 | private static $types = [ |
||
32 | 'a' => 'array', |
||
33 | 'o' => 'object', |
||
34 | 'i' => 'integer', |
||
35 | 'int' => 'integer', |
||
36 | 's' => 'string', |
||
37 | 'str' => 'string', |
||
38 | 'n' => 'number', |
||
39 | 'b' => 'boolean', |
||
40 | 'bool' => 'boolean', |
||
41 | 'ts' => 'timestamp', |
||
42 | 'dt' => 'datetime' |
||
43 | ]; |
||
44 | |||
45 | private $schema = []; |
||
46 | |||
47 | /** |
||
48 | * @var int A bitwise combination of the various **Schema::FLAG_*** constants. |
||
49 | */ |
||
50 | private $flags = 0; |
||
51 | |||
52 | /** |
||
53 | * @var array An array of callbacks that will custom validate the schema. |
||
54 | */ |
||
55 | private $validators = []; |
||
56 | |||
57 | /** |
||
58 | * @var string|Validation The name of the class or an instance that will be cloned. |
||
59 | */ |
||
60 | private $validationClass = Validation::class; |
||
61 | |||
62 | |||
63 | /// Methods /// |
||
64 | |||
65 | /** |
||
66 | * Initialize an instance of a new {@link Schema} class. |
||
67 | * |
||
68 | * @param array $schema The array schema to validate against. |
||
69 | */ |
||
70 | 112 | public function __construct($schema = []) { |
|
73 | |||
74 | /** |
||
75 | * Grab the schema's current description. |
||
76 | * |
||
77 | * @return string |
||
78 | */ |
||
79 | 1 | public function getDescription() { |
|
82 | |||
83 | /** |
||
84 | * Set the description for the schema. |
||
85 | * |
||
86 | * @param string $description The new description. |
||
87 | * @throws \InvalidArgumentException Throws an exception when the provided description is not a string. |
||
88 | * @return Schema |
||
89 | */ |
||
90 | 2 | public function setDescription($description) { |
|
91 | 2 | if (is_string($description)) { |
|
92 | 1 | $this->schema['description'] = $description; |
|
93 | 1 | } else { |
|
94 | 1 | throw new \InvalidArgumentException("The description is not a valid string.", 500); |
|
95 | } |
||
96 | |||
97 | 1 | return $this; |
|
98 | } |
||
99 | |||
100 | /** |
||
101 | * Return the validation flags. |
||
102 | * |
||
103 | * @return int Returns a bitwise combination of flags. |
||
104 | */ |
||
105 | 1 | public function getFlags() { |
|
108 | |||
109 | /** |
||
110 | * Set the validation flags. |
||
111 | * |
||
112 | * @param int $flags One or more of the **Schema::FLAG_*** constants. |
||
113 | * @return Schema Returns the current instance for fluent calls. |
||
114 | */ |
||
115 | 8 | public function setFlags($flags) { |
|
123 | |||
124 | /** |
||
125 | * Whether or not the schema has a flag (or combination of flags). |
||
126 | * |
||
127 | * @param int $flag One or more of the **Schema::VALIDATE_*** constants. |
||
128 | * @return bool Returns **true** if all of the flags are set or **false** otherwise. |
||
129 | */ |
||
130 | 8 | public function hasFlag($flag) { |
|
133 | |||
134 | /** |
||
135 | * Set a flag. |
||
136 | * |
||
137 | * @param int $flag One or more of the **Schema::VALIDATE_*** constants. |
||
138 | * @param bool $value Either true or false. |
||
139 | * @return $this |
||
140 | */ |
||
141 | 1 | public function setFlag($flag, $value) { |
|
142 | 1 | if ($value) { |
|
143 | 1 | $this->flags = $this->flags | $flag; |
|
144 | 1 | } else { |
|
145 | 1 | $this->flags = $this->flags & ~$flag; |
|
146 | } |
||
147 | 1 | return $this; |
|
148 | } |
||
149 | |||
150 | /** |
||
151 | * Merge a schema with this one. |
||
152 | * |
||
153 | * @param Schema $schema A scheme instance. Its parameters will be merged into the current instance. |
||
154 | */ |
||
155 | 2 | public function merge(Schema $schema) { |
|
156 | $fn = function (array &$target, array $source) use (&$fn) { |
||
157 | 2 | foreach ($source as $key => $val) { |
|
158 | 2 | if (is_array($val) && array_key_exists($key, $target) && is_array($target[$key])) { |
|
159 | 2 | if (isset($val[0]) || isset($target[$key][0])) { |
|
160 | // This is a numeric array, so just do a merge. |
||
161 | 1 | $merged = array_merge($target[$key], $val); |
|
162 | 1 | if (is_string($merged[0])) { |
|
163 | 1 | $merged = array_keys(array_flip($merged)); |
|
164 | 1 | } |
|
165 | 1 | $target[$key] = $merged; |
|
166 | 1 | } else { |
|
167 | 2 | $target[$key] = $fn($target[$key], $val); |
|
168 | } |
||
169 | 2 | } else { |
|
170 | 2 | $target[$key] = $val; |
|
171 | } |
||
172 | 2 | } |
|
173 | |||
174 | 2 | return $target; |
|
175 | 2 | }; |
|
176 | |||
177 | 2 | $fn($this->schema, $schema->jsonSerialize()); |
|
178 | 2 | } |
|
179 | |||
180 | /** |
||
181 | * Parse a schema in short form into a full schema array. |
||
182 | * |
||
183 | * @param array $arr The array to parse into a schema. |
||
184 | * @return array The full schema array. |
||
185 | * @throws \InvalidArgumentException Throws an exception when an item in the schema is invalid. |
||
186 | */ |
||
187 | 112 | public function parse(array $arr) { |
|
188 | 112 | if (empty($arr)) { |
|
189 | // An empty schema validates to anything. |
||
190 | 6 | return []; |
|
191 | 107 | } elseif (isset($arr['type'])) { |
|
192 | // This is a long form schema and can be parsed as the root. |
||
193 | 2 | return $this->parseNode($arr); |
|
194 | } else { |
||
195 | // Check for a root schema. |
||
196 | 107 | $value = reset($arr); |
|
197 | 107 | $key = key($arr); |
|
|
|||
198 | 107 | if (is_int($key)) { |
|
199 | 73 | $key = $value; |
|
200 | 73 | $value = null; |
|
201 | 73 | } |
|
202 | 107 | list ($name, $param) = $this->parseShortParam($key, $value); |
|
203 | 107 | if (empty($name)) { |
|
204 | 27 | return $this->parseNode($param, $value); |
|
205 | } |
||
206 | } |
||
207 | |||
208 | // If we are here then this is n object schema. |
||
209 | 82 | list($properties, $required) = $this->parseProperties($arr); |
|
210 | |||
211 | $result = [ |
||
212 | 82 | 'type' => 'object', |
|
213 | 82 | 'properties' => $properties, |
|
214 | 'required' => $required |
||
215 | 82 | ]; |
|
216 | |||
217 | 82 | return array_filter($result); |
|
218 | } |
||
219 | |||
220 | /** |
||
221 | * Parse a schema node. |
||
222 | * |
||
223 | * @param array $node The node to parse. |
||
224 | * @param mixed $value Additional information from the node. |
||
225 | * @return array Returns a JSON schema compatible node. |
||
226 | */ |
||
227 | 107 | private function parseNode($node, $value = null) { |
|
228 | 107 | if (is_array($value)) { |
|
229 | // The value describes a bit more about the schema. |
||
230 | 32 | switch ($node['type']) { |
|
231 | 32 | case 'array': |
|
232 | 6 | if (isset($value['items'])) { |
|
233 | // The value includes array schema information. |
||
234 | 1 | $node = array_replace($node, $value); |
|
235 | 1 | } else { |
|
236 | 5 | $node['items'] = $this->parse($value); |
|
237 | } |
||
238 | 6 | break; |
|
239 | 26 | case 'object': |
|
240 | // The value is a schema of the object. |
||
241 | 9 | if (isset($value['properties'])) { |
|
242 | list($node['properties']) = $this->parseProperties($value['properties']); |
||
243 | } else { |
||
244 | 9 | list($node['properties'], $required) = $this->parseProperties($value); |
|
245 | 9 | if (!empty($required)) { |
|
246 | 9 | $node['required'] = $required; |
|
247 | 9 | } |
|
248 | } |
||
249 | 9 | break; |
|
250 | 17 | default: |
|
251 | 17 | $node = array_replace($node, $value); |
|
252 | 17 | break; |
|
253 | 32 | } |
|
254 | 107 | } elseif (is_string($value)) { |
|
255 | 76 | if ($node['type'] === 'array' && $arrType = $this->getType($value)) { |
|
256 | 2 | $node['items'] = ['type' => $arrType]; |
|
257 | 76 | } elseif (!empty($value)) { |
|
258 | 22 | $node['description'] = $value; |
|
259 | 22 | } |
|
260 | 76 | } |
|
261 | |||
262 | 107 | return $node; |
|
263 | } |
||
264 | |||
265 | /** |
||
266 | * Parse the schema for an object's properties. |
||
267 | * |
||
268 | * @param array $arr An object property schema. |
||
269 | * @return array Returns a schema array suitable to be placed in the **properties** key of a schema. |
||
270 | */ |
||
271 | 82 | private function parseProperties(array $arr) { |
|
272 | 82 | $properties = []; |
|
273 | 82 | $requiredProperties = []; |
|
274 | 82 | foreach ($arr as $key => $value) { |
|
275 | // Fix a schema specified as just a value. |
||
276 | 82 | if (is_int($key)) { |
|
277 | 60 | if (is_string($value)) { |
|
278 | 60 | $key = $value; |
|
279 | 60 | $value = ''; |
|
280 | 60 | } else { |
|
281 | throw new \InvalidArgumentException("Schema at position $key is not a valid parameter.", 500); |
||
282 | } |
||
283 | 60 | } |
|
284 | |||
285 | // The parameter is defined in the key. |
||
286 | 82 | list($name, $param, $required) = $this->parseShortParam($key, $value); |
|
287 | |||
288 | 82 | $node = $this->parseNode($param, $value); |
|
289 | |||
290 | 82 | $properties[$name] = $node; |
|
291 | 82 | if ($required) { |
|
292 | 42 | $requiredProperties[] = $name; |
|
293 | 42 | } |
|
294 | 82 | } |
|
295 | 82 | return array($properties, $requiredProperties); |
|
296 | } |
||
297 | |||
298 | /** |
||
299 | * Parse a short parameter string into a full array parameter. |
||
300 | * |
||
301 | * @param string $key The short parameter string to parse. |
||
302 | * @param array $value An array of other information that might help resolve ambiguity. |
||
303 | * @return array Returns an array in the form `[string name, array param, bool required]`. |
||
304 | * @throws \InvalidArgumentException Throws an exception if the short param is not in the correct format. |
||
305 | */ |
||
306 | 107 | public function parseShortParam($key, $value = []) { |
|
307 | // Is the parameter optional? |
||
308 | 107 | if (substr($key, -1) === '?') { |
|
309 | 58 | $required = false; |
|
310 | 58 | $key = substr($key, 0, -1); |
|
311 | 58 | } else { |
|
312 | 67 | $required = true; |
|
313 | } |
||
314 | |||
315 | // Check for a type. |
||
316 | 107 | $parts = explode(':', $key); |
|
317 | 107 | $name = $parts[0]; |
|
1 ignored issue
–
show
|
|||
318 | 107 | $type = !empty($parts[1]) && isset(self::$types[$parts[1]]) ? self::$types[$parts[1]] : null; |
|
1 ignored issue
–
show
|
|||
319 | |||
320 | 107 | if ($value instanceof Schema) { |
|
321 | 2 | if ($type === 'array') { |
|
322 | 1 | $param = ['type' => $type, 'items' => $value]; |
|
323 | 1 | } else { |
|
324 | 1 | $param = $value; |
|
325 | } |
||
326 | 107 | } elseif (isset($value['type'])) { |
|
327 | $param = $value; |
||
328 | |||
329 | if (!empty($type) && $type !== $param['type']) { |
||
330 | throw new \InvalidArgumentException("Type mismatch between $type and {$param['type']} for field $name.", 500); |
||
331 | } |
||
332 | } else { |
||
333 | 107 | if (empty($type) && !empty($parts[1])) { |
|
334 | throw new \InvalidArgumentException("Invalid type {$parts[1]} for field $name.", 500); |
||
335 | } |
||
336 | 107 | $param = ['type' => $type]; |
|
337 | |||
338 | // Parsed required strings have a minimum length of 1. |
||
339 | 107 | if ($type === 'string' && !empty($name) && $required) { |
|
340 | 27 | $param['minLength'] = 1; |
|
341 | 27 | } |
|
342 | } |
||
343 | |||
344 | 107 | return [$name, $param, $required]; |
|
345 | } |
||
346 | |||
347 | /** |
||
348 | * Add a custom validator to to validate the schema. |
||
349 | * |
||
350 | * @param string $fieldname The name of the field to validate, if any. |
||
351 | * |
||
352 | * If you are adding a validator to a deeply nested field then separate the path with dots. |
||
353 | * @param callable $callback The callback to validate with. |
||
354 | * @return Schema Returns `$this` for fluent calls. |
||
355 | */ |
||
356 | 2 | public function addValidator($fieldname, callable $callback) { |
|
360 | |||
361 | /** |
||
362 | * Require one of a given set of fields in the schema. |
||
363 | * |
||
364 | * @param array $required The field names to require. |
||
365 | * @param string $fieldname The name of the field to attach to. |
||
366 | * @param int $count The count of required items. |
||
367 | * @return Schema Returns `$this` for fluent calls. |
||
368 | */ |
||
369 | 1 | public function requireOneOf(array $required, $fieldname = '', $count = 1) { |
|
370 | 1 | $result = $this->addValidator( |
|
371 | 1 | $fieldname, |
|
372 | function ($data, ValidationField $field) use ($required, $count) { |
||
373 | 1 | $hasCount = 0; |
|
1 ignored issue
–
show
|
|||
374 | 1 | $flattened = []; |
|
375 | |||
376 | 1 | foreach ($required as $name) { |
|
377 | 1 | $flattened = array_merge($flattened, (array)$name); |
|
378 | |||
379 | 1 | if (is_array($name)) { |
|
380 | // This is an array of required names. They all must match. |
||
381 | 1 | $hasCountInner = 0; |
|
382 | 1 | foreach ($name as $nameInner) { |
|
383 | 1 | if (isset($data[$nameInner]) && $data[$nameInner]) { |
|
384 | 1 | $hasCountInner++; |
|
385 | 1 | } else { |
|
386 | 1 | break; |
|
387 | } |
||
388 | 1 | } |
|
389 | 1 | if ($hasCountInner >= count($name)) { |
|
390 | 1 | $hasCount++; |
|
391 | 1 | } |
|
392 | 1 | } elseif (isset($data[$name]) && $data[$name]) { |
|
393 | 1 | $hasCount++; |
|
394 | 1 | } |
|
395 | |||
396 | 1 | if ($hasCount >= $count) { |
|
397 | 1 | return true; |
|
398 | } |
||
399 | 1 | } |
|
400 | |||
401 | 1 | if ($count === 1) { |
|
402 | 1 | $message = 'One of {required} are required.'; |
|
403 | 1 | } else { |
|
404 | $message = '{count} of {required} are required.'; |
||
405 | } |
||
406 | |||
407 | 1 | $field->addError('missingField', [ |
|
408 | 1 | 'messageCode' => $message, |
|
409 | 1 | 'required' => $required, |
|
410 | 'count' => $count |
||
411 | 1 | ]); |
|
412 | 1 | return false; |
|
413 | } |
||
414 | 1 | ); |
|
415 | |||
416 | 1 | return $result; |
|
417 | } |
||
418 | |||
419 | /** |
||
420 | * Validate data against the schema. |
||
421 | * |
||
422 | * @param mixed $data The data to validate. |
||
423 | * @param bool $sparse Whether or not this is a sparse validation. |
||
424 | * @return mixed Returns a cleaned version of the data. |
||
425 | * @throws ValidationException Throws an exception when the data does not validate against the schema. |
||
426 | */ |
||
427 | 90 | public function validate($data, $sparse = false) { |
|
438 | |||
439 | /** |
||
440 | * Validate data against the schema and return the result. |
||
441 | * |
||
442 | * @param array $data The data to validate. |
||
443 | * @param bool $sparse Whether or not to do a sparse validation. |
||
444 | * @return bool Returns true if the data is valid. False otherwise. |
||
445 | */ |
||
446 | 22 | public function isValid($data, $sparse = false) { |
|
454 | |||
455 | /** |
||
456 | * Validate a field. |
||
457 | * |
||
458 | * @param mixed $value The value to validate. |
||
459 | * @param ValidationField $field A validation object to add errors to. |
||
460 | * @param bool $sparse Whether or not this is a sparse validation. |
||
461 | * @return mixed Returns a clean version of the value with all extra fields stripped out. |
||
462 | */ |
||
463 | 90 | private function validateField($value, ValidationField $field, $sparse = false) { |
|
519 | |||
520 | /** |
||
521 | * Call all of the validators attached to a field. |
||
522 | * |
||
523 | * @param mixed $value The field value being validated. |
||
524 | * @param ValidationField $field The validation object to add errors. |
||
525 | */ |
||
526 | 89 | private function callValidators($value, ValidationField $field) { |
|
535 | |||
536 | /** |
||
537 | * Validate an array. |
||
538 | * |
||
539 | * @param mixed $value The value to validate. |
||
540 | * @param ValidationField $field The validation results to add. |
||
541 | * @param bool $sparse Whether or not this is a sparse validation. |
||
542 | * @return array|null Returns an array or **null** if validation fails. |
||
543 | */ |
||
544 | 10 | private function validateArray($value, ValidationField $field, $sparse = false) { |
|
574 | |||
575 | /** |
||
576 | * Validate a boolean value. |
||
577 | * |
||
578 | * @param mixed $value The value to validate. |
||
579 | * @param ValidationField $field The validation results to add. |
||
580 | * @return bool|null Returns the cleaned value or **null** if validation fails. |
||
581 | */ |
||
582 | 19 | private function validateBoolean($value, ValidationField $field) { |
|
597 | |||
598 | /** |
||
599 | * Validate a date time. |
||
600 | * |
||
601 | * @param mixed $value The value to validate. |
||
602 | * @param ValidationField $field The validation results to add. |
||
603 | * @return \DateTimeInterface|null Returns the cleaned value or **null** if it isn't valid. |
||
604 | */ |
||
605 | 6 | private function validateDatetime($value, ValidationField $field) { |
|
630 | |||
631 | /** |
||
632 | * Validate a float. |
||
633 | * |
||
634 | * @param mixed $value The value to validate. |
||
635 | * @param ValidationField $field The validation results to add. |
||
636 | * @return float|int|null Returns a number or **null** if validation fails. |
||
637 | */ |
||
638 | 7 | private function validateNumber($value, ValidationField $field) { |
|
649 | |||
650 | /** |
||
651 | * Validate and integer. |
||
652 | * |
||
653 | * @param mixed $value The value to validate. |
||
654 | * @param ValidationField $field The validation results to add. |
||
655 | * @return int|null Returns the cleaned value or **null** if validation fails. |
||
656 | */ |
||
657 | 20 | private function validateInteger($value, ValidationField $field) { |
|
668 | |||
669 | /** |
||
670 | * Validate an object. |
||
671 | * |
||
672 | * @param mixed $value The value to validate. |
||
673 | * @param ValidationField $field The validation results to add. |
||
674 | * @param bool $sparse Whether or not this is a sparse validation. |
||
675 | * @return object|null Returns a clean object or **null** if validation fails. |
||
676 | */ |
||
677 | 72 | private function validateObject($value, ValidationField $field, $sparse = false) { |
|
687 | |||
688 | /** |
||
689 | * Validate data against the schema and return the result. |
||
690 | * |
||
691 | * @param array $data The data to validate. |
||
692 | * @param ValidationField $field This argument will be filled with the validation result. |
||
693 | * @param bool $sparse Whether or not this is a sparse validation. |
||
694 | * @return array Returns a clean array with only the appropriate properties and the data coerced to proper types. |
||
695 | */ |
||
696 | 72 | private function validateProperties(array $data, ValidationField $field, $sparse = false) { |
|
751 | |||
752 | /** |
||
753 | * Validate a string. |
||
754 | * |
||
755 | * @param mixed $value The value to validate. |
||
756 | * @param ValidationField $field The validation results to add. |
||
757 | * @return string|null Returns the valid string or **null** if validation fails. |
||
758 | */ |
||
759 | 34 | private function validateString($value, ValidationField $field) { |
|
811 | |||
812 | /** |
||
813 | * Validate a unix timestamp. |
||
814 | * |
||
815 | * @param mixed $value The value to validate. |
||
816 | * @param ValidationField $field The field being validated. |
||
817 | * @return int|null Returns a valid timestamp or **null** if the value doesn't validate. |
||
818 | */ |
||
819 | 6 | private function validateTimestamp($value, ValidationField $field) { |
|
830 | |||
831 | /** |
||
832 | * Validate a value against an enum. |
||
833 | * |
||
834 | * @param mixed $value The value to test. |
||
835 | * @param ValidationField $field The validation object for adding errors. |
||
836 | * @return bool Returns **true** if the value one of the enumerated values or **false** otherwise. |
||
837 | */ |
||
838 | 89 | private function validateEnum($value, ValidationField $field) { |
|
857 | |||
858 | /** |
||
859 | * Specify data which should be serialized to JSON. |
||
860 | * |
||
861 | * @link http://php.net/manual/en/jsonserializable.jsonserialize.php |
||
862 | * @return mixed data which can be serialized by <b>json_encode</b>, |
||
863 | * which is a value of any type other than a resource. |
||
864 | */ |
||
865 | 20 | public function jsonSerialize() { |
|
874 | |||
875 | /** |
||
876 | * Look up a type based on its alias. |
||
877 | * |
||
878 | * @param string $alias The type alias or type name to lookup. |
||
879 | * @return mixed |
||
880 | */ |
||
881 | 9 | private function getType($alias) { |
|
891 | |||
892 | /** |
||
893 | * Get the class that's used to contain validation information. |
||
894 | * |
||
895 | * @return Validation|string Returns the validation class. |
||
896 | */ |
||
897 | 90 | public function getValidationClass() { |
|
900 | |||
901 | /** |
||
902 | * Set the class that's used to contain validation information. |
||
903 | * |
||
904 | * @param Validation|string $class Either the name of a class or a class that will be cloned. |
||
905 | * @return $this |
||
906 | */ |
||
907 | 1 | public function setValidationClass($class) { |
|
915 | |||
916 | /** |
||
917 | * Create a new validation instance. |
||
918 | * |
||
919 | * @return Validation Returns a validation object. |
||
920 | */ |
||
921 | 90 | protected function createValidation() { |
|
931 | } |
||
932 |
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.
To visualize
will produce issues in the first and second line, while this second example
will produce no issues.