Complex classes like Validation often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Validation, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class Validation { |
||
| 14 | /** |
||
| 15 | * @var array |
||
| 16 | */ |
||
| 17 | private $errors = []; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * @var string |
||
| 21 | */ |
||
| 22 | private $mainMessage = ''; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * @var int |
||
| 26 | */ |
||
| 27 | private $mainStatus = 0; |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @var bool Whether or not fields should be translated. |
||
| 31 | */ |
||
| 32 | private $translateFieldNames = false; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * Add an error. |
||
| 36 | * |
||
| 37 | * @param string $field The name and path of the field to add or an empty string if this is a global error. |
||
| 38 | * @param string $error The message code. |
||
| 39 | * @param int|array $options An array of additional information to add to the error entry or a numeric error code. |
||
| 40 | * @return $this |
||
| 41 | */ |
||
| 42 | 65 | public function addError($field, $error, $options = []) { |
|
| 76 | |||
| 77 | /** |
||
| 78 | * Get or set the error status code. |
||
| 79 | * |
||
| 80 | * The status code is an http response code and should be of the 4xx variety. |
||
| 81 | * |
||
| 82 | * @return int Returns the current status code. |
||
| 83 | */ |
||
| 84 | 58 | public function getStatus() { |
|
| 103 | |||
| 104 | /** |
||
| 105 | * Get the message for this exception. |
||
| 106 | * |
||
| 107 | * @return string Returns the exception message. |
||
| 108 | */ |
||
| 109 | 59 | public function getMessage() { |
|
| 127 | |||
| 128 | /** |
||
| 129 | * Gets all of the errors as a flat array. |
||
| 130 | * |
||
| 131 | * The errors are internally stored indexed by field. This method flattens them for final error returns. |
||
| 132 | * |
||
| 133 | * @return array Returns all of the errors. |
||
| 134 | */ |
||
| 135 | 4 | public function getErrors() { |
|
| 142 | |||
| 143 | /** |
||
| 144 | * Get the errors for a specific field. |
||
| 145 | * |
||
| 146 | * @param string $field The full path to the field. |
||
| 147 | * @return array Returns an array of errors. |
||
| 148 | */ |
||
| 149 | 6 | public function getFieldErrors($field) { |
|
| 160 | |||
| 161 | /** |
||
| 162 | * Gets all of the errors as a flat array. |
||
| 163 | * |
||
| 164 | * The errors are internally stored indexed by field. This method flattens them for final error returns. |
||
| 165 | * |
||
| 166 | * @return \Traversable Returns all of the errors. |
||
| 167 | */ |
||
| 168 | 76 | protected function getRawErrors() { |
|
| 175 | |||
| 176 | /** |
||
| 177 | * Check whether or not the validation is free of errors. |
||
| 178 | * |
||
| 179 | * @return bool Returns true if there are no errors, false otherwise. |
||
| 180 | */ |
||
| 181 | 146 | public function isValid() { |
|
| 184 | |||
| 185 | /** |
||
| 186 | * Check whether or not a particular field is has errors. |
||
| 187 | * |
||
| 188 | * @param string $field The name of the field to check for validity. |
||
| 189 | * @return bool Returns true if the field has no errors, false otherwise. |
||
| 190 | */ |
||
| 191 | 90 | public function isValidField($field) { |
|
| 195 | |||
| 196 | /** |
||
| 197 | * Get the error count, optionally for a particular field. |
||
| 198 | * |
||
| 199 | * @param string $field The name of a field or an empty string for all errors. |
||
| 200 | * @return int Returns the error count. |
||
| 201 | */ |
||
| 202 | 61 | public function getErrorCount($field = '') { |
|
| 211 | |||
| 212 | /** |
||
| 213 | * Get the error message for an error row. |
||
| 214 | * |
||
| 215 | * @param array $error The error row. |
||
| 216 | * @return string Returns a formatted/translated error message. |
||
| 217 | */ |
||
| 218 | 60 | private function getErrorMessage(array $error) { |
|
| 219 | 60 | if (isset($error['messageCode'])) { |
|
| 220 | 54 | $messageCode = $error['messageCode']; |
|
| 221 | 60 | } elseif (isset($error['message'])) { |
|
| 222 | return $error['message']; |
||
| 223 | } else { |
||
| 224 | 7 | $messageCode = $error['code']; |
|
| 225 | } |
||
| 226 | |||
| 227 | // Massage the field name for better formatting. |
||
| 228 | 60 | if (!$this->getTranslateFieldNames()) { |
|
| 229 | 59 | $field = (!empty($error['path']) ? ($error['path'][0] !== '[' ? '' : 'item').$error['path'].'.' : '').$error['field']; |
|
| 230 | 59 | $field = $field ?: (isset($error['index']) ? 'item' : 'value'); |
|
| 231 | 59 | if (isset($error['index'])) { |
|
| 232 | 3 | $field .= '['.$error['index'].']'; |
|
| 233 | 3 | } |
|
| 234 | 59 | $error['field'] = '@'.$field; |
|
| 235 | 60 | } elseif (isset($error['index'])) { |
|
| 236 | if (empty($error['field'])) { |
||
| 237 | $error['field'] = '@'.$this->formatMessage('item {index}', $error); |
||
| 238 | } else { |
||
| 239 | $error['field'] = '@'.$this->formatMessage('{field} at position {index}', $error); |
||
| 240 | } |
||
| 241 | 2 | } elseif (empty($error['field'])) { |
|
| 242 | 1 | $error['field'] = 'value'; |
|
| 243 | 1 | } |
|
| 244 | |||
| 245 | 60 | $msg = $this->formatMessage($messageCode, $error); |
|
| 246 | 60 | return $msg; |
|
| 247 | } |
||
| 248 | |||
| 249 | /** |
||
| 250 | * Expand and translate a message format against an array of values. |
||
| 251 | * |
||
| 252 | * @param string $format The message format. |
||
| 253 | * @param array $context The context arguments to apply to the message. |
||
| 254 | * @return string Returns a formatted string. |
||
| 255 | */ |
||
| 256 | 60 | private function formatMessage($format, $context = []) { |
|
| 266 | |||
| 267 | /** |
||
| 268 | * Translate an argument being placed in an error message. |
||
| 269 | * |
||
| 270 | * @param mixed $value The argument to translate. |
||
| 271 | * @param array $args Formatting arguments. |
||
| 272 | * @return string Returns the translated string. |
||
| 273 | */ |
||
| 274 | 57 | private function formatField($value, array $args = []) { |
|
| 275 | 57 | if ($value === null) { |
|
| 276 | 1 | $r = $this->translate('null'); |
|
| 277 | 57 | } elseif ($value === true) { |
|
| 278 | $r = $this->translate('true'); |
||
| 279 | 57 | } elseif ($value === false) { |
|
| 280 | $r = $this->translate('false'); |
||
| 281 | 57 | } elseif (is_string($value)) { |
|
| 282 | 56 | $r = $this->translate($value); |
|
| 283 | 57 | } elseif (is_numeric($value)) { |
|
| 284 | 8 | $r = $value; |
|
| 285 | 12 | } elseif (is_array($value)) { |
|
| 286 | 5 | $argArray = array_map([$this, 'formatField'], $value); |
|
| 287 | 5 | $r = implode(', ', $argArray); |
|
| 288 | 5 | } elseif ($value instanceof \DateTimeInterface) { |
|
| 289 | $r = $value->format('c'); |
||
| 290 | } else { |
||
| 291 | $r = $value; |
||
| 292 | } |
||
| 293 | |||
| 294 | 57 | $format = array_shift($args); |
|
| 295 | switch ($format) { |
||
| 296 | 57 | case 'plural': |
|
| 297 | 8 | $singular = array_shift($args); |
|
| 298 | 8 | $plural = array_shift($args) ?: $singular.'s'; |
|
| 299 | 8 | $count = is_array($value) ? count($value) : $value; |
|
| 300 | 8 | $r = $count == 1 ? $singular : $plural; |
|
| 301 | 8 | break; |
|
| 302 | } |
||
| 303 | |||
| 304 | 57 | return (string)$r; |
|
| 305 | } |
||
| 306 | |||
| 307 | /** |
||
| 308 | * Translate a string. |
||
| 309 | * |
||
| 310 | * This method doesn't do any translation itself, but is meant for subclasses wanting to add translation ability to |
||
| 311 | * this class. |
||
| 312 | * |
||
| 313 | * @param string $str The string to translate. |
||
| 314 | * @return string Returns the translated string. |
||
| 315 | */ |
||
| 316 | 61 | public function translate($str) { |
|
| 324 | |||
| 325 | /** |
||
| 326 | * Merge another validation object with this one. |
||
| 327 | * |
||
| 328 | * @param Validation $validation The validation object to merge. |
||
| 329 | * @param string $name The path to merge to. Use this parameter when the validation object is meant to be a subset of this one. |
||
| 330 | * @return $this |
||
| 331 | */ |
||
| 332 | 2 | public function merge(Validation $validation, $name = '') { |
|
| 333 | 2 | $paths = $validation->errors; |
|
| 334 | |||
| 335 | 2 | foreach ($paths as $path => $errors) { |
|
| 336 | 2 | foreach ($errors as $error) { |
|
| 337 | 2 | if (!empty($name)) { |
|
| 338 | // We are merging a sub-schema error that did not occur on a particular property of the sub-schema. |
||
| 339 | 2 | if ($path === '') { |
|
| 340 | 1 | $fullPath = "$name"; |
|
| 341 | 1 | } else { |
|
| 342 | 1 | $fullPath = "{$name}.{$path}"; |
|
| 343 | } |
||
| 344 | 2 | $this->addError($fullPath, $error['code'], $error); |
|
| 345 | 2 | } |
|
| 346 | 2 | } |
|
| 347 | 2 | } |
|
| 348 | 2 | return $this; |
|
| 349 | } |
||
| 350 | |||
| 351 | /** |
||
| 352 | * Get the main error message. |
||
| 353 | * |
||
| 354 | * If set, this message will be returned as the error message. Otherwise the message will be set from individual |
||
| 355 | * errors. |
||
| 356 | * |
||
| 357 | * @return string Returns the main message. |
||
| 358 | */ |
||
| 359 | 59 | public function getMainMessage() { |
|
| 362 | |||
| 363 | /** |
||
| 364 | * Set the main error message. |
||
| 365 | * |
||
| 366 | * @param string $message The new message. |
||
| 367 | * @return $this |
||
| 368 | */ |
||
| 369 | 1 | public function setMainMessage($message) { |
|
| 373 | |||
| 374 | /** |
||
| 375 | * Get the main status. |
||
| 376 | * |
||
| 377 | * @return int Returns an HTTP response code or zero to indicate it should be calculated. |
||
| 378 | */ |
||
| 379 | 58 | public function getMainStatus() { |
|
| 382 | |||
| 383 | /** |
||
| 384 | * Set the main status. |
||
| 385 | * |
||
| 386 | * @param int $status An HTTP response code or zero. |
||
| 387 | * @return $this |
||
| 388 | */ |
||
| 389 | 1 | public function setMainStatus($status) { |
|
| 393 | |||
| 394 | /** |
||
| 395 | * Whether or not fields should be translated. |
||
| 396 | * |
||
| 397 | * @return bool Returns **true** if field names are translated or **false** otherwise. |
||
| 398 | */ |
||
| 399 | 60 | public function getTranslateFieldNames() { |
|
| 402 | |||
| 403 | /** |
||
| 404 | * Set whether or not fields should be translated. |
||
| 405 | * |
||
| 406 | * @param bool $translate Whether or not fields should be translated. |
||
| 407 | * @return $this |
||
| 408 | */ |
||
| 409 | 2 | public function setTranslateFieldNames($translate) { |
|
| 413 | |||
| 414 | /** |
||
| 415 | * @param $error |
||
| 416 | * @return array |
||
| 417 | */ |
||
| 418 | 10 | private function formatError($error) { |
|
| 427 | } |
||
| 428 |
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.
To visualize
will produce issues in the first and second line, while this second example
will produce no issues.