Complex classes like Validation often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Validation, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
13 | class Validation { |
||
14 | /** |
||
15 | * @var array |
||
16 | */ |
||
17 | private $errors = []; |
||
18 | |||
19 | /** |
||
20 | * @var string |
||
21 | */ |
||
22 | private $mainMessage = ''; |
||
23 | |||
24 | /** |
||
25 | * @var int |
||
26 | */ |
||
27 | private $mainStatus = 0; |
||
28 | |||
29 | /** |
||
30 | * @var bool Whether or not fields should be translated. |
||
31 | */ |
||
32 | private $translateFieldNames = false; |
||
33 | |||
34 | /** |
||
35 | * Add an error. |
||
36 | * |
||
37 | * @param string $field The name and path of the field to add or an empty string if this is a global error. |
||
38 | * @param string $error The message code. |
||
39 | * @param int|array $options An array of additional information to add to the error entry or a numeric error code. |
||
40 | * @return $this |
||
41 | */ |
||
42 | 66 | public function addError($field, $error, $options = []) { |
|
76 | |||
77 | /** |
||
78 | * Get or set the error status code. |
||
79 | * |
||
80 | * The status code is an http response code and should be of the 4xx variety. |
||
81 | * |
||
82 | * @return int Returns the current status code. |
||
83 | */ |
||
84 | 59 | public function getStatus() { |
|
103 | |||
104 | /** |
||
105 | * Get the message for this exception. |
||
106 | * |
||
107 | * @return string Returns the exception message. |
||
108 | */ |
||
109 | 60 | public function getMessage() { |
|
127 | |||
128 | /** |
||
129 | * Gets all of the errors as a flat array. |
||
130 | * |
||
131 | * The errors are internally stored indexed by field. This method flattens them for final error returns. |
||
132 | * |
||
133 | * @return array Returns all of the errors. |
||
134 | */ |
||
135 | 4 | public function getErrors() { |
|
136 | 4 | $result = []; |
|
137 | 4 | foreach ($this->getRawErrors() as $error) { |
|
138 | 4 | $result[] = $this->formatError($error); |
|
139 | } |
||
140 | 4 | return $result; |
|
141 | } |
||
142 | |||
143 | /** |
||
144 | * Get the errors for a specific field. |
||
145 | * |
||
146 | * @param string $field The full path to the field. |
||
147 | * @return array Returns an array of errors. |
||
148 | */ |
||
149 | 6 | public function getFieldErrors($field) { |
|
150 | 6 | if (empty($this->errors[$field])) { |
|
151 | return []; |
||
152 | } else { |
||
153 | 6 | $result = []; |
|
154 | 6 | foreach ($this->errors[$field] as $error) { |
|
155 | 6 | $result[] = $this->formatError($error); |
|
156 | } |
||
157 | 6 | return $result; |
|
158 | } |
||
159 | } |
||
160 | |||
161 | /** |
||
162 | * Gets all of the errors as a flat array. |
||
163 | * |
||
164 | * The errors are internally stored indexed by field. This method flattens them for final error returns. |
||
165 | * |
||
166 | * @return \Traversable Returns all of the errors. |
||
167 | */ |
||
168 | 63 | protected function getRawErrors() { |
|
169 | 63 | foreach ($this->errors as $errors) { |
|
170 | 63 | foreach ($errors as $error) { |
|
171 | 63 | yield $error; |
|
172 | } |
||
173 | } |
||
174 | 63 | } |
|
175 | |||
176 | /** |
||
177 | * Check whether or not the validation is free of errors. |
||
178 | * |
||
179 | * @return bool Returns true if there are no errors, false otherwise. |
||
180 | */ |
||
181 | 108 | public function isValid() { |
|
184 | |||
185 | /** |
||
186 | * Check whether or not a particular field is has errors. |
||
187 | * |
||
188 | * @param string $field The name of the field to check for validity. |
||
189 | * @return bool Returns true if the field has no errors, false otherwise. |
||
190 | */ |
||
191 | 35 | public function isValidField($field) { |
|
195 | |||
196 | /** |
||
197 | * Get the error message for an error row. |
||
198 | * |
||
199 | * @param array $error The error row. |
||
200 | * @return string Returns a formatted/translated error message. |
||
201 | */ |
||
202 | 61 | private function getErrorMessage(array $error) { |
|
203 | 61 | if (isset($error['messageCode'])) { |
|
204 | 55 | $messageCode = $error['messageCode']; |
|
205 | 7 | } elseif (isset($error['message'])) { |
|
206 | return $error['message']; |
||
207 | } else { |
||
208 | 7 | $messageCode = $error['code']; |
|
209 | } |
||
210 | |||
211 | // Massage the field name for better formatting. |
||
212 | 61 | if (!$this->getTranslateFieldNames()) { |
|
213 | 60 | $field = (!empty($error['path']) ? ($error['path'][0] !== '[' ?: 'item').$error['path'].'.' : '').$error['field']; |
|
214 | 60 | $field = $field ?: (isset($error['index']) ? 'item' : 'value'); |
|
215 | 60 | if (isset($error['index'])) { |
|
216 | 3 | $field .= '['.$error['index'].']'; |
|
217 | } |
||
218 | 60 | $error['field'] = '@'.$field; |
|
219 | 2 | } elseif (isset($error['index'])) { |
|
220 | if (empty($error['field'])) { |
||
221 | $error['field'] = '@'.$this->formatMessage('item {index}', $error); |
||
222 | } else { |
||
223 | $error['field'] = '@'.$this->formatMessage('{field} at position {index}', $error); |
||
224 | } |
||
225 | 2 | } elseif (empty($error['field'])) { |
|
226 | 1 | $error['field'] = 'value'; |
|
227 | } |
||
228 | |||
229 | 61 | $msg = $this->formatMessage($messageCode, $error); |
|
230 | 61 | return $msg; |
|
231 | } |
||
232 | |||
233 | /** |
||
234 | * Expand and translate a message format against an array of values. |
||
235 | * |
||
236 | * @param string $format The message format. |
||
237 | * @param array $context The context arguments to apply to the message. |
||
238 | * @return string Returns a formatted string. |
||
239 | */ |
||
240 | 61 | private function formatMessage($format, $context = []) { |
|
250 | |||
251 | /** |
||
252 | * Translate an argument being placed in an error message. |
||
253 | * |
||
254 | * @param mixed $value The argument to translate. |
||
255 | * @param array $args Formatting arguments. |
||
256 | * @return string Returns the translated string. |
||
257 | */ |
||
258 | 58 | private function formatField($value, array $args = []) { |
|
259 | 58 | if (is_string($value)) { |
|
260 | 57 | $r = $this->translate($value); |
|
261 | 9 | } elseif (is_numeric($value)) { |
|
262 | 5 | $r = $value; |
|
263 | 4 | } elseif (is_array($value)) { |
|
264 | 4 | $argArray = array_map([$this, 'formatField'], $value); |
|
265 | 4 | $r = implode(', ', $argArray); |
|
266 | } elseif ($value instanceof \DateTimeInterface) { |
||
267 | $r = $value->format('c'); |
||
268 | } else { |
||
269 | $r = $value; |
||
270 | } |
||
271 | |||
272 | 58 | $format = array_shift($args); |
|
273 | switch ($format) { |
||
274 | 58 | case 'plural': |
|
275 | 6 | $singular = array_shift($args); |
|
276 | 6 | $plural = array_shift($args) ?: $singular.'s'; |
|
277 | 6 | $count = is_array($value) ? count($value) : $value; |
|
278 | 6 | $r = $count == 1 ? $singular : $plural; |
|
279 | 6 | break; |
|
280 | } |
||
281 | |||
282 | 58 | return (string)$r; |
|
283 | } |
||
284 | |||
285 | /** |
||
286 | * Translate a string. |
||
287 | * |
||
288 | * This method doesn't do any translation itself, but is meant for subclasses wanting to add translation ability to |
||
289 | * this class. |
||
290 | * |
||
291 | * @param string $str The string to translate. |
||
292 | * @return string Returns the translated string. |
||
293 | */ |
||
294 | 62 | public function translate($str) { |
|
302 | |||
303 | /** |
||
304 | * Merge another validation object with this one. |
||
305 | * |
||
306 | * @param Validation $validation The validation object to merge. |
||
307 | * @param string $name The path to merge to. Use this parameter when the validation object is meant to be a subset of this one. |
||
308 | * @return $this |
||
309 | */ |
||
310 | 1 | public function merge(Validation $validation, $name = '') { |
|
311 | 1 | $paths = $validation->errors; |
|
312 | |||
313 | 1 | foreach ($paths as $path => $errors) { |
|
314 | 1 | foreach ($errors as $error) { |
|
315 | 1 | if (!empty($name)) { |
|
316 | 1 | $fullPath = "{$name}.{$path}"; |
|
317 | 1 | $this->addError($fullPath, $error['code'], $error); |
|
318 | } |
||
319 | } |
||
320 | } |
||
321 | 1 | return $this; |
|
322 | } |
||
323 | |||
324 | /** |
||
325 | * Get the main error message. |
||
326 | * |
||
327 | * If set, this message will be returned as the error message. Otherwise the message will be set from individual |
||
328 | * errors. |
||
329 | * |
||
330 | * @return string Returns the main message. |
||
331 | */ |
||
332 | 60 | public function getMainMessage() { |
|
335 | |||
336 | /** |
||
337 | * Set the main error message. |
||
338 | * |
||
339 | * @param string $message The new message. |
||
340 | * @return $this |
||
341 | */ |
||
342 | 1 | public function setMainMessage($message) { |
|
346 | |||
347 | /** |
||
348 | * Get the main status. |
||
349 | * |
||
350 | * @return int Returns an HTTP response code or zero to indicate it should be calculated. |
||
351 | */ |
||
352 | 59 | public function getMainStatus() { |
|
355 | |||
356 | /** |
||
357 | * Set the main status. |
||
358 | * |
||
359 | * @param int $status An HTTP response code or zero. |
||
360 | * @return $this |
||
361 | */ |
||
362 | 1 | public function setMainStatus($status) { |
|
366 | |||
367 | /** |
||
368 | * Whether or not fields should be translated. |
||
369 | * |
||
370 | * @return bool Returns **true** if field names are translated or **false** otherwise. |
||
371 | */ |
||
372 | 61 | public function getTranslateFieldNames() { |
|
375 | |||
376 | /** |
||
377 | * Set whether or not fields should be translated. |
||
378 | * |
||
379 | * @param bool $translate Whether or not fields should be translated. |
||
380 | * @return $this |
||
381 | */ |
||
382 | 2 | public function setTranslateFieldNames($translate) { |
|
386 | |||
387 | /** |
||
388 | * @param $error |
||
389 | * @return array |
||
390 | */ |
||
391 | 10 | private function formatError($error) { |
|
392 | 10 | $row = array_intersect_key( |
|
400 | } |
||
401 |
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.
To visualize
will produce issues in the first and second line, while this second example
will produce no issues.