RequiredParameter::__construct() - Code Metrics - Inspection of "Add better error messages for required parameters" - vanilla/garden-container - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

by Todd

created 2017-04-02 15:55 UTC

RequiredParameter::__construct() A

↳ Parent: RequiredParameter

Complexity

Conditions	3
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	5
nc	2
nop	1
crap	3

<?php
/**
 * @author Todd Burry <[email protected]>
 * @copyright 2009-2017 Vanilla Forums Inc.
 * @license MIT
 * @internal
 */

namespace Garden\Container;

/**
 * A placeholder for a required parameter.
 */
class RequiredParameter extends DefaultReference {
    private $parameter;
    private $function;

    /**
     * RequiredParameter constructor.
     *
     * @param \ReflectionParameter $param The required parameter.
     */
    public function __construct(\ReflectionParameter $param) {
        parent::__construct($param->getClass() ? $param->getClass()->getName() : '');


        $this->parameter = $param->getName();

        $this->function = ($param->getDeclaringClass() ? $param->getDeclaringClass()->getName().'::' : '').

            $param->getDeclaringFunction()->getName().'()';

    }


    /**
     * Get the name.
     *
     * @return string Returns the name.
     */
    public function getParameter() {
        return $this->parameter;
    }

    /**
     * Get the function.
     *
     * @return string Returns the function.
     */
    public function getFunction() {
        return $this->function;
    }

    /**
     * {@inheritdoc}
     *
     * @throws MissingArgumentException Always throws an exception.
     */
    public function resolve(Container $container, $_ = null) {

        throw new MissingArgumentException($this->parameter, $this->function);
    }
}


1		<?php
2		/**
3		* @author Todd Burry <[email protected]>
4		* @copyright 2009-2017 Vanilla Forums Inc.
5		* @license MIT
6		* @internal
7		*/
8
9		namespace Garden\Container;
10
11		/**
12		* A placeholder for a required parameter.
13		*/
14		class RequiredParameter extends DefaultReference {
15		private $parameter;
16		private $function;
17
18		/**
19		* RequiredParameter constructor.
20		*
21		* @param \ReflectionParameter $param The required parameter.
22		*/
23	5	public function __construct(\ReflectionParameter $param) {
24	5	parent::__construct($param->getClass() ? $param->getClass()->getName() : '');
		0 ignored issues – show Bug introduced 2017-04-02 15:56 UTC by Report Bug Copy Issue Report Consider using `$param->getClass()->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
25
26	5	$this->parameter = $param->getName();
		0 ignored issues – show Bug introduced 2017-04-02 15:56 UTC by Report Bug Copy Issue Report Consider using `$param->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
27	5	$this->function = ($param->getDeclaringClass() ? $param->getDeclaringClass()->getName().'::' : '').
		0 ignored issues – show Bug introduced 2017-04-02 15:56 UTC by Report Bug Copy Issue Report Consider using `$param->getDeclaringClass()->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
28	5	$param->getDeclaringFunction()->getName().'()';
		0 ignored issues – show Bug introduced 2017-04-02 15:56 UTC by Report Bug Copy Issue Report Consider using `$param->getDeclaringFunction()->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
29	5	}
30
31
32		/**
33		* Get the name.
34		*
35		* @return string Returns the name.
36		*/
37		public function getParameter() {
38		return $this->parameter;
39		}
40
41		/**
42		* Get the function.
43		*
44		* @return string Returns the function.
45		*/
46		public function getFunction() {
47		return $this->function;
48		}
49
50		/**
51		* {@inheritdoc}
52		*
53		* @throws MissingArgumentException Always throws an exception.
54		*/
55	2	public function resolve(Container $container, $_ = null) {
		0 ignored issues – show Coding Style Naming introduced 2017-04-02 15:56 UTC by Report Bug Copy Issue Report The parameter $_ is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
56	2	throw new MissingArgumentException($this->parameter, $this->function);
57		}
58		}
59

vanilla / garden-container

Pull Request — master (#18)

RequiredParameter::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like