Complex classes like LogFormatter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LogFormatter, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
13 | class LogFormatter { |
||
14 | /** |
||
15 | * @var string The date format as passed to {@link strftime()}. |
||
16 | */ |
||
17 | protected $dateFormat = '[%F %T]'; |
||
18 | |||
19 | /** |
||
20 | * @var string The end of line string to use. |
||
21 | */ |
||
22 | protected $eol = PHP_EOL; |
||
23 | |||
24 | /** |
||
25 | * @var bool Whether or not to format output. |
||
26 | */ |
||
27 | protected $formatOutput; |
||
28 | |||
29 | /** |
||
30 | * @var bool Whether or not the console is on a new line. |
||
31 | */ |
||
32 | protected $isNewline = true; |
||
33 | |||
34 | /** |
||
35 | * @var int The maximum level deep to output. |
||
36 | */ |
||
37 | protected $maxLevel = 2; |
||
38 | |||
39 | /** |
||
40 | * @var array An array of currently running tasks. |
||
41 | */ |
||
42 | protected $taskStack = []; |
||
43 | |||
44 | /** |
||
45 | * LogFormatter constructor. |
||
46 | */ |
||
47 | 9 | public function __construct() { |
|
50 | |||
51 | /** |
||
52 | * Output an error message. |
||
53 | * |
||
54 | * When formatting is turned on, error messages are displayed in red. Error messages are always output, even if they |
||
55 | * are past the maximum display level. |
||
56 | * |
||
57 | * @param string $str The message to output. |
||
58 | * @return LogFormatter Returns `$this` for fluent calls. |
||
59 | */ |
||
60 | 2 | public function error($str) { |
|
63 | |||
64 | /** |
||
65 | * Output a success message. |
||
66 | * |
||
67 | * When formatting is turned on, success messages are displayed in green. |
||
68 | * |
||
69 | * @param string $str The message to output. |
||
70 | * @return LogFormatter Returns `$this` for fluent calls. |
||
71 | */ |
||
72 | public function success($str) { |
||
75 | |||
76 | /** |
||
77 | * Get the current depth of tasks. |
||
78 | * |
||
79 | * @return int Returns the current level. |
||
80 | */ |
||
81 | 9 | protected function currentLevel() { |
|
84 | |||
85 | /** |
||
86 | * Output a message that designates the beginning of a task. |
||
87 | * |
||
88 | * @param string $str The message to output. |
||
89 | * @return $this Returns `$this` for fluent calls. |
||
90 | */ |
||
91 | 7 | public function begin($str) { |
|
109 | |||
110 | /** |
||
111 | * Output a message that designates a task being completed. |
||
112 | * |
||
113 | * @param string $str The message to output. |
||
114 | * @param bool $force Whether or not to always output the message even if the task is past the max depth. |
||
115 | * @return $this Returns `$this` for fluent calls. |
||
116 | */ |
||
117 | 7 | public function end($str, $force = false) { |
|
154 | |||
155 | /** |
||
156 | * Output a message that represents a task being completed in success. |
||
157 | * |
||
158 | * When formatting is turned on, success messages are output in green. |
||
159 | * |
||
160 | * @param string $str The message to output. |
||
161 | * @param bool $force Whether or not to force a message past the max level to be output. |
||
162 | * @return LogFormatter Returns `$this` for fluent calls. |
||
163 | */ |
||
164 | public function endSuccess($str, $force = false) { |
||
167 | |||
168 | /** |
||
169 | * Output a message that represents a task being completed in an error. |
||
170 | * |
||
171 | * When formatting is turned on, error messages are output in red. Error messages are always output even if they are |
||
172 | * past the maximum depth. |
||
173 | * |
||
174 | * @param string $str The message to output. |
||
175 | * @return LogFormatter Returns `$this` for fluent calls. |
||
176 | */ |
||
177 | 1 | public function endError($str) { |
|
180 | |||
181 | /** |
||
182 | * Output a message that ends a task with an HTTP status code. |
||
183 | * |
||
184 | * This method is useful if you are making a call to an external API as a task. You can end the task by passing the |
||
185 | * response code to this message. |
||
186 | * |
||
187 | * @param int $httpStatus The HTTP status code that represents the completion of a task. |
||
188 | * @param bool $force Whether or not to force message output. |
||
189 | * @return $this Returns `$this` for fluent calls. |
||
190 | * @see LogFormatter::endSuccess(), LogFormatter::endError(). |
||
191 | */ |
||
192 | public function endHttpStatus($httpStatus, $force = false) { |
||
205 | |||
206 | /** |
||
207 | * Output a message. |
||
208 | * |
||
209 | * @param string $str The message to output. |
||
210 | * @param bool $force Whether or not to force output of the message even if it's past the max depth. |
||
211 | * @return $this Returns `$this` for fluent calls. |
||
212 | */ |
||
213 | 8 | public function message($str, $force = false) { |
|
244 | |||
245 | /** |
||
246 | * Get the format. |
||
247 | * |
||
248 | * @return boolean Returns the format. |
||
249 | */ |
||
250 | public function getFormatOutput() { |
||
253 | |||
254 | /** |
||
255 | * Set the format. |
||
256 | * |
||
257 | * @param boolean $formatOutput |
||
258 | * @return LogFormatter Returns `$this` for fluent calls. |
||
259 | */ |
||
260 | 9 | public function setFormatOutput($formatOutput) { |
|
264 | |||
265 | 9 | protected function fullMessageStr($timestamp, $str, $indent = null, $eol = true) { |
|
289 | |||
290 | /** |
||
291 | * Create a message string. |
||
292 | * |
||
293 | * @param string $str The message to output. |
||
294 | * @param bool $eol Whether or not to add an EOL. |
||
295 | * @return string Returns the message. |
||
296 | */ |
||
297 | 9 | protected function messageStr($str, $eol = true) { |
|
300 | |||
301 | /** |
||
302 | * Format some text for the console. |
||
303 | * |
||
304 | * @param string $text The text to format. |
||
305 | * @param array $wrap The format to wrap in the form ['before', 'after']. |
||
306 | * @return string Returns the string formatted according to {@link Cli::$format}. |
||
307 | */ |
||
308 | 3 | protected function formatString($text, array $wrap) { |
|
315 | |||
316 | /** |
||
317 | * Guess whether or not to format the output with colors. |
||
318 | * |
||
319 | * If the current environment is being redirected to a file then output should not be formatted. Also, Windows |
||
320 | * machines do not support terminal colors so formatting should be suppressed on them too. |
||
321 | * |
||
322 | * @return bool Returns **true** if the output can be formatter or **false** otherwise. |
||
323 | */ |
||
324 | 9 | public function guessFormatOutput() { |
|
333 | |||
334 | /** |
||
335 | * Get the maxLevel. |
||
336 | * |
||
337 | * @return int Returns the maxLevel. |
||
338 | */ |
||
339 | 9 | public function getMaxLevel() { |
|
342 | |||
343 | /** |
||
344 | * @param int $maxLevel |
||
345 | * @return LogFormatter |
||
346 | */ |
||
347 | 9 | public function setMaxLevel($maxLevel) { |
|
355 | |||
356 | /** |
||
357 | * Get the date format as passed to {@link strftime()}. |
||
358 | * |
||
359 | * @return string Returns the date format. |
||
360 | * @see strftime() |
||
361 | */ |
||
362 | 9 | public function getDateFormat() { |
|
365 | |||
366 | /** |
||
367 | * Set the date format as passed to {@link strftime()}. |
||
368 | * |
||
369 | * @param string $dateFormat |
||
370 | * @return LogFormatter Returns `$this` for fluent calls. |
||
371 | * @see strftime() |
||
372 | */ |
||
373 | 9 | public function setDateFormat($dateFormat) { |
|
377 | |||
378 | /** |
||
379 | * Get the end of line string to use. |
||
380 | * |
||
381 | * @return string Returns the eol string. |
||
382 | */ |
||
383 | 5 | public function getEol() { |
|
386 | |||
387 | /** |
||
388 | * Set the end of line string. |
||
389 | * |
||
390 | * @param string $eol The end of line string to use. |
||
391 | * @return LogFormatter Returns `$this` for fluent calls. |
||
392 | */ |
||
393 | 9 | public function setEol($eol) { |
|
397 | } |
||
398 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.