Complex classes like LogFormatter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LogFormatter, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class LogFormatter { |
||
| 14 | /** |
||
| 15 | * @var string The date format as passed to {@link strftime()}. |
||
| 16 | */ |
||
| 17 | protected $dateFormat = '[%F %R]'; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * @var string The end of line string to use. |
||
| 21 | */ |
||
| 22 | protected $eol = PHP_EOL; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * @var bool Whether or not to format output. |
||
| 26 | */ |
||
| 27 | protected $formatOutput; |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @var bool Whether or not the console is on a new line. |
||
| 31 | */ |
||
| 32 | protected $isNewline = true; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @var int The maximum level deep to output. |
||
| 36 | */ |
||
| 37 | protected $maxLevel = 2; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @var array An array of currently running tasks. |
||
| 41 | */ |
||
| 42 | protected $taskStack = []; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * LogFormatter constructor. |
||
| 46 | */ |
||
| 47 | 9 | public function __construct() { |
|
| 50 | |||
| 51 | /** |
||
| 52 | * Output an error message. |
||
| 53 | * |
||
| 54 | * When formatting is turned on, error messages are displayed in red. Error messages are always output, even if they |
||
| 55 | * are past the maximum display level. |
||
| 56 | * |
||
| 57 | * @param string $str The message to output. |
||
| 58 | * @return LogFormatter Returns `$this` for fluent calls. |
||
| 59 | */ |
||
| 60 | 2 | public function error($str) { |
|
| 63 | |||
| 64 | /** |
||
| 65 | * Output a success message. |
||
| 66 | * |
||
| 67 | * When formatting is turned on, success messages are displayed in green. |
||
| 68 | * |
||
| 69 | * @param string $str The message to output. |
||
| 70 | * @return LogFormatter Returns `$this` for fluent calls. |
||
| 71 | */ |
||
| 72 | public function success($str) { |
||
| 75 | |||
| 76 | /** |
||
| 77 | * Get the current depth of tasks. |
||
| 78 | * |
||
| 79 | * @return int Returns the current level. |
||
| 80 | */ |
||
| 81 | 9 | protected function currentLevel() { |
|
| 84 | |||
| 85 | /** |
||
| 86 | * Output a message that designates the beginning of a task. |
||
| 87 | * |
||
| 88 | * @param string $str The message to output. |
||
| 89 | * @return $this Returns `$this` for fluent calls. |
||
| 90 | */ |
||
| 91 | 7 | public function begin($str) { |
|
| 109 | |||
| 110 | /** |
||
| 111 | * Output a message that designates a task being completed. |
||
| 112 | * |
||
| 113 | * @param string $str The message to output. |
||
| 114 | * @param bool $force Whether or not to always output the message even if the task is past the max depth. |
||
| 115 | * @return $this Returns `$this` for fluent calls. |
||
| 116 | */ |
||
| 117 | 7 | public function end($str, $force = false) { |
|
| 154 | |||
| 155 | /** |
||
| 156 | * Output a message that represents a task being completed in success. |
||
| 157 | * |
||
| 158 | * When formatting is turned on, success messages are output in green. |
||
| 159 | * |
||
| 160 | * @param string $str The message to output. |
||
| 161 | * @return LogFormatter Returns `$this` for fluent calls. |
||
| 162 | */ |
||
| 163 | public function endSuccess($str) { |
||
| 166 | |||
| 167 | /** |
||
| 168 | * Output a message that represents a task being completed in an error. |
||
| 169 | * |
||
| 170 | * When formatting is turned on, error messages are output in red. Error messages are always output even if they are |
||
| 171 | * past the maximum depth. |
||
| 172 | * |
||
| 173 | * @param string $str The message to output. |
||
| 174 | * @return LogFormatter Returns `$this` for fluent calls. |
||
| 175 | */ |
||
| 176 | 1 | public function endError($str) { |
|
| 179 | |||
| 180 | /** |
||
| 181 | * Output a message that ends a task with an HTTP status code. |
||
| 182 | * |
||
| 183 | * This method is useful if you are making a call to an external API as a task. You can end the task by passing the |
||
| 184 | * response code to this message. |
||
| 185 | * |
||
| 186 | * @param int $httpStatus The HTTP status code that represents the completion of a task. |
||
| 187 | * @return $this Returns `$this` for fluent calls. |
||
| 188 | * @see LogFormatter::endSuccess(), LogFormatter::endError(). |
||
| 189 | */ |
||
| 190 | public function endHttpStatus($httpStatus) { |
||
| 203 | |||
| 204 | /** |
||
| 205 | * Output a message. |
||
| 206 | * |
||
| 207 | * @param string $str The message to output. |
||
| 208 | * @param bool $force Whether or not to force output of the message even if it's past the max depth. |
||
| 209 | * @return $this Returns `$this` for fluent calls. |
||
| 210 | */ |
||
| 211 | 8 | public function message($str, $force = false) { |
|
| 242 | |||
| 243 | /** |
||
| 244 | * Get the format. |
||
| 245 | * |
||
| 246 | * @return boolean Returns the format. |
||
| 247 | */ |
||
| 248 | public function getFormatOutput() { |
||
| 251 | |||
| 252 | /** |
||
| 253 | * Set the format. |
||
| 254 | * |
||
| 255 | * @param boolean $formatOutput |
||
| 256 | * @return LogFormatter Returns `$this` for fluent calls. |
||
| 257 | */ |
||
| 258 | 9 | public function setFormatOutput($formatOutput) { |
|
| 262 | |||
| 263 | 9 | protected function fullMessageStr($timestamp, $str, $indent = null, $eol = true) { |
|
| 287 | |||
| 288 | 9 | protected function messageStr($str, $eol = true) { |
|
| 291 | |||
| 292 | /** |
||
| 293 | * Format some text for the console. |
||
| 294 | * |
||
| 295 | * @param string $text The text to format. |
||
| 296 | * @param array $wrap The format to wrap in the form ['before', 'after']. |
||
| 297 | * @return string Returns the string formatted according to {@link Cli::$format}. |
||
| 298 | */ |
||
| 299 | 3 | protected function formatString($text, array $wrap) { |
|
| 306 | |||
| 307 | 9 | public function guessFormatOutput() { |
|
| 316 | |||
| 317 | /** |
||
| 318 | * Get the maxLevel. |
||
| 319 | * |
||
| 320 | * @return int Returns the maxLevel. |
||
| 321 | */ |
||
| 322 | 9 | public function getMaxLevel() { |
|
| 325 | |||
| 326 | /** |
||
| 327 | * @param int $maxLevel |
||
| 328 | * @return LogFormatter |
||
| 329 | */ |
||
| 330 | 9 | public function setMaxLevel($maxLevel) { |
|
| 338 | |||
| 339 | /** |
||
| 340 | * Get the date format as passed to {@link strftime()}. |
||
| 341 | * |
||
| 342 | * @return string Returns the date format. |
||
| 343 | * @see strftime() |
||
| 344 | */ |
||
| 345 | 9 | public function getDateFormat() { |
|
| 348 | |||
| 349 | /** |
||
| 350 | * Set the date format as passed to {@link strftime()}. |
||
| 351 | * |
||
| 352 | * @param string $dateFormat |
||
| 353 | * @return LogFormatter Returns `$this` for fluent calls. |
||
| 354 | * @see strftime() |
||
| 355 | */ |
||
| 356 | 9 | public function setDateFormat($dateFormat) { |
|
| 360 | |||
| 361 | /** |
||
| 362 | * Get the end of line string to use. |
||
| 363 | * |
||
| 364 | * @return string Returns the eol string. |
||
| 365 | */ |
||
| 366 | 5 | public function getEol() { |
|
| 369 | |||
| 370 | /** |
||
| 371 | * Set the end of line string. |
||
| 372 | * |
||
| 373 | * @param string $eol The end of line string to use. |
||
| 374 | * @return LogFormatter Returns `$this` for fluent calls. |
||
| 375 | */ |
||
| 376 | 9 | public function setEol($eol) { |
|
| 380 | } |
||
| 381 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.