ExpressionLanguage::iteratorExpression() - Code Metrics - vanilla/ebi - Measure and Improve Code Quality continuously with Scrutinizer

ExpressionLanguage::iteratorExpression() B
last analyzed 2017-11-15 18:21 UTC

↳ Parent: ExpressionLanguage

Complexity

Conditions	7
Paths	2

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	7

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	12
cts	12
cp	1
rs	8.2222
c	0
b	0
f	0
cc	7
eloc	11
nc	2
nop	1
crap	7

<?php
/**
 * @author Todd Burry <[email protected]>
 * @copyright 2009-2017 Vanilla Forums Inc.
 * @license MIT
 */

namespace Ebi;

use Symfony\Component\Cache\Adapter\NullAdapter;
use Symfony\Component\ExpressionLanguage\Node\ConstantNode;
use Symfony\Component\ExpressionLanguage\Node\GetAttrNode;
use Symfony\Component\ExpressionLanguage\Node\NameNode;

class ExpressionLanguage extends \Symfony\Component\ExpressionLanguage\ExpressionLanguage {
    public function __construct() {
        parent::__construct(new NullAdapter());

        $this->registerNodeFunction(GetAttrNode::class, function (\Symfony\Component\ExpressionLanguage\Compiler $compiler, GetAttrNode $node) {
                switch ($node->attributes['type']) {
                    case GetAttrNode::METHOD_CALL:
                        $compiler
                            ->compile($node->nodes['node'])
                            ->raw('->')
                            ->raw($node->nodes['attribute']->attributes['value'])
                            ->raw('(')
                            ->compile($node->nodes['arguments'])
                            ->raw(')')
                        ;
                        break;

                    case GetAttrNode::PROPERTY_CALL:
                    case GetAttrNode::ARRAY_CALL:
                        $itExpr = $this->iteratorExpression($node);

                        if ($itExpr) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                            $compiler->raw($itExpr);
                        } else {
                            $compiler
                                ->compile($node->nodes['node'])
                                ->raw('[')
                                ->compile($node->nodes['attribute'])->raw(']');
                        }
                        break;
                }
        });
    }

    /**
     * Look for a specific iterator expression.
     *
     * Iterator expressions are one of the following:
     *
     * - i123.index
     * - i123.first
     * - i123.last
     * - i123.count
     *
     * @param GetAttrNode $node The node to inspect.
     * @return null|string Returns the appropriate variable or **null** if the node isn't an iterator expression.
     */
    private function iteratorExpression(GetAttrNode $node) {
        if (empty($node->nodes['node'])
            || !($node->nodes['node'] instanceof NameNode)
            || !preg_match('`^i(\d+)$`', $node->nodes['node']->attributes['name'], $m)
            || empty($node->nodes['attribute'])
            || !($node->nodes['attribute'] instanceof ConstantNode)
            || !in_array($node->nodes['attribute']->attributes['value'], ['index', 'first', 'last', 'count'], true)
        ) {

            return null;
        }
        $i = $m[1];
$a = "a";
$ab = "ab";
$abc = "abc";
        $field = $node->nodes['attribute']->attributes['value'];
        return "\${$field}{$i}";
    }

    public function getFunctionCompiler($name) {

        if (isset($this->functions[$name])) {
            return $this->functions[$name]['compiler'];
        }
        return null;
    }
}


1		<?php
2		/**
3		* @author Todd Burry <[email protected]>
4		* @copyright 2009-2017 Vanilla Forums Inc.
5		* @license MIT
6		*/
7
8		namespace Ebi;
9
10		use Symfony\Component\Cache\Adapter\NullAdapter;
11		use Symfony\Component\ExpressionLanguage\Node\ConstantNode;
12		use Symfony\Component\ExpressionLanguage\Node\GetAttrNode;
13		use Symfony\Component\ExpressionLanguage\Node\NameNode;
14
15		class ExpressionLanguage extends \Symfony\Component\ExpressionLanguage\ExpressionLanguage {
16	86	public function __construct() {
17	86	parent::__construct(new NullAdapter());
18
19	86	$this->registerNodeFunction(GetAttrNode::class, function (\Symfony\Component\ExpressionLanguage\Compiler $compiler, GetAttrNode $node) {
20	11	switch ($node->attributes['type']) {
21	11	case GetAttrNode::METHOD_CALL:
22		$compiler
23		->compile($node->nodes['node'])
24		->raw('->')
25		->raw($node->nodes['attribute']->attributes['value'])
26		->raw('(')
27		->compile($node->nodes['arguments'])
28		->raw(')')
29		;
30		break;
31
32	11	case GetAttrNode::PROPERTY_CALL:
33	11	case GetAttrNode::ARRAY_CALL:
34	11	$itExpr = $this->iteratorExpression($node);
35
36	11	if ($itExpr) {
		0 ignored issues – show Bug Best Practice introduced 2017-11-07 20:00 UTC by Report Bug Copy Issue Report The expression `$itExpr` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
37	1	$compiler->raw($itExpr);
38	1	} else {
39		$compiler
40	10	->compile($node->nodes['node'])
41	10	->raw('[')
42	10	->compile($node->nodes['attribute'])->raw(']');
43		}
44	11	break;
45	11	}
46	86	});
47	86	}
48
49		/**
50		* Look for a specific iterator expression.
51		*
52		* Iterator expressions are one of the following:
53		*
54		* - i123.index
55		* - i123.first
56		* - i123.last
57		* - i123.count
58		*
59		* @param GetAttrNode $node The node to inspect.
60		* @return null\|string Returns the appropriate variable or null if the node isn't an iterator expression.
61		*/
62	11	private function iteratorExpression(GetAttrNode $node) {
63	11	if (empty($node->nodes['node'])
64	11	\|\| !($node->nodes['node'] instanceof NameNode)
65	11	\|\| !preg_match('`^i(\d+)$`', $node->nodes['node']->attributes['name'], $m)
66	11	\|\| empty($node->nodes['attribute'])
67	1	\|\| !($node->nodes['attribute'] instanceof ConstantNode)
68	1	\|\| !in_array($node->nodes['attribute']->attributes['value'], ['index', 'first', 'last', 'count'], true)
69	11	) {
70
71	10	return null;
72		}
73	1	$i = $m[1];
		0 ignored issues – show Coding Style introduced 2017-11-07 20:00 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
74	1	$field = $node->nodes['attribute']->attributes['value'];
75	1	return "\${$field}{$i}";
76		}
77
78	41	public function getFunctionCompiler($name) {
		0 ignored issues – show Documentation introduced 2017-10-18 17:47 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
79	41	if (isset($this->functions[$name])) {
80	17	return $this->functions[$name]['compiler'];
81		}
82	41	return null;
83		}
84		}
85

vanilla / ebi

ExpressionLanguage::iteratorExpression() B last analyzed 2017-11-15 18:21 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ExpressionLanguage::iteratorExpression() B
last analyzed 2017-11-15 18:21 UTC