Base_PHPUnit5::expectException() - Code Metrics - Inspection of "Merge pull request #38 from weirdan/phpunit-compat..." - vanderlee/PHPSwaggerGen - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5b4fcf...5a8d3e )

by Martijn

created 2018-04-26 11:13 UTC

Base_PHPUnit5::expectException() A

↳ Parent: Base_PHPUnit5

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	2

<?php

class Base_PHPUnit5 extends PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{
	/**
	 * @param string $exception
	 * @param string $message
	 * @return void
	 */
	public function expectException($exception, $message = '')
	{
		parent::setExpectedException($exception, $message);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
	}
}


1			<?php
2
3			class Base_PHPUnit5 extends PHPUnit_Framework_TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2018-04-20 23:50 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			/**
6			* @param string $exception
7			* @param string $message
8			* @return void
9			*/
10			public function expectException($exception, $message = '')
11			{
12			parent::setExpectedException($exception, $message);
			0 ignored issues – show Comprehensibility Bug introduced 2018-04-20 23:50 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setExpectedException()` instead of `expectException()`). Are you sure this is correct? If so, you might want to change this to `$this->setExpectedException()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
13			}
14			}
15

vanderlee / PHPSwaggerGen

Push — master ( 5b4fcf...5a8d3e )

Base_PHPUnit5::expectException() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like