valkyrjaio /
valkyrja
| Conditions | 10 |
| Paths | 512 |
| Total Lines | 47 |
| Code Lines | 19 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
| 1 | <?php |
||
| 33 | public function __construct( |
||
| 34 | string $path, |
||
| 35 | string $name = null, |
||
| 36 | array $methods = null, |
||
| 37 | array $parameters = null, |
||
| 38 | array $middleware = null, |
||
| 39 | array $messages = null, |
||
| 40 | bool $secure = null, |
||
| 41 | string $to = null, |
||
| 42 | int $code = null, |
||
| 43 | ) { |
||
| 44 | $this->path = $path; |
||
| 45 | |||
| 46 | if ($path) { |
||
| 47 | $this->name = $path; |
||
| 48 | } |
||
| 49 | |||
| 50 | if ($name) { |
||
| 51 | $this->name = $name; |
||
| 52 | } |
||
| 53 | |||
| 54 | if ($methods) { |
||
| 55 | $this->methods = $methods; |
||
| 56 | } |
||
| 57 | |||
| 58 | if ($parameters) { |
||
| 59 | $this->setParameters($parameters); |
||
| 60 | } |
||
| 61 | |||
| 62 | if ($middleware) { |
||
| 63 | $this->setMiddleware($middleware); |
||
| 64 | } |
||
| 65 | |||
| 66 | if ($secure) { |
||
| 67 | $this->secure = $secure; |
||
| 68 | } |
||
| 69 | |||
| 70 | if ($to) { |
||
| 71 | $this->setTo($to); |
||
| 72 | } |
||
| 73 | |||
| 74 | if ($code) { |
||
| 75 | $this->code = $code; |
||
| 76 | } |
||
| 77 | |||
| 78 | if ($messages) { |
||
| 79 | $this->setMessages($messages); |
||
| 80 | } |
||
| 83 |
Loading history...
Let?s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let?s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: