Result::valid() - Code Metrics - Inspection of "updated readme" - vakata/database - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b71ad6...2211ef )

by Ivan

created 2017-04-05 08:46 UTC

Result::valid() A

↳ Parent: Result

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace vakata\database\driver\postgre;

use \vakata\database\DBException;
use \vakata\database\DriverInterface;
use \vakata\database\ResultInterface;
use \vakata\collection\Collection;

class Result implements ResultInterface
{
    protected $statement;
    protected $last = null;
    protected $fetched = -1;
    protected $iid = null;
    protected $aff = 0;

    public function __construct($statement, $iid, $aff)
    {
        $this->statement = $statement;
        $this->iid = $iid;
        $this->aff = $aff;
    }
    public function __destruct()
    {
        @\pg_free_result($this->statement);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }
    public function affected() : int
    {
        return $this->aff;
    }
    public function insertID()
    {
        return $this->iid;
    }
    public function toArray() : array
    {
        return iterator_to_array($this);
    }

    public function count()
    {
        return \pg_num_rows($this->statement);
    }

    public function key()
    {
        return $this->fetched;
    }
    public function current()
    {
        return $this->last;
    }
    public function rewind()
    {
        if ($this->fetched >= 0) {
            \pg_result_seek($this->statement, 0);
        }
        $this->last = null;
        $this->fetched = -1;
        $this->next();
    }
    public function next()
    {
        $this->fetched ++;
        $this->last = \pg_fetch_array($this->statement, null, \PGSQL_ASSOC);
    }
    public function valid()
    {
        return !!$this->last;
    }
}

1			<?php
2
3			namespace vakata\database\driver\postgre;
4
5			use \vakata\database\DBException;
6			use \vakata\database\DriverInterface;
7			use \vakata\database\ResultInterface;
8			use \vakata\collection\Collection;
9
10			class Result implements ResultInterface
11			{
12			protected $statement;
13			protected $last = null;
14			protected $fetched = -1;
15			protected $iid = null;
16			protected $aff = 0;
17
18			public function __construct($statement, $iid, $aff)
19			{
20			$this->statement = $statement;
21			$this->iid = $iid;
22			$this->aff = $aff;
23			}
24			public function __destruct()
25			{
26			@\pg_free_result($this->statement);
			0 ignored issues – show Security Best Practice introduced 2017-04-05 08:54 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
27			}
28			public function affected() : int
29			{
30			return $this->aff;
31			}
32			public function insertID()
33			{
34			return $this->iid;
35			}
36			public function toArray() : array
37			{
38			return iterator_to_array($this);
39			}
40
41			public function count()
42			{
43			return \pg_num_rows($this->statement);
44			}
45
46			public function key()
47			{
48			return $this->fetched;
49			}
50			public function current()
51			{
52			return $this->last;
53			}
54			public function rewind()
55			{
56			if ($this->fetched >= 0) {
57			\pg_result_seek($this->statement, 0);
58			}
59			$this->last = null;
60			$this->fetched = -1;
61			$this->next();
62			}
63			public function next()
64			{
65			$this->fetched ++;
66			$this->last = \pg_fetch_array($this->statement, null, \PGSQL_ASSOC);
67			}
68			public function valid()
69			{
70			return !!$this->last;
71			}
72			}

vakata / database

Push — master ( b71ad6...2211ef )

Result::valid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like