CLIClient::getArguments() - Code Metrics - Inspection of "Added recursive metadata support (fixes #16)" - vaites/php-apache-tika - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( daf5ec...c13cfb )

by David
created 2019-05-21 02:23 UTC
CLIClient::getArguments() C

↳ Parent: CLIClient
Complexity

Conditions	14
Paths	14
Size

Total Lines	57
Code Lines	40
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	14
eloc	40
nc	14
nop	2
dl	0
loc	57
rs	6.2666
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

namespace Vaites\ApacheTika\Clients;

use Exception;

use Vaites\ApacheTika\Client;
use Vaites\ApacheTika\Metadata\Metadata;

/**
 * Apache Tika command line interface client
 *
 * @author  David Martínez <[email protected]>
 * @link    http://wiki.apache.org/tika/TikaJAXRS
 * @link    https://tika.apache.org/1.12/formats.html
 */
class CLIClient extends Client
{
    const MODE = 'cli';

    /**
     * Apache Tika app path
     *
     * @var string
     */
    protected $path = null;

    /**
     * Java binary path
     *
     * @var string
     */
    protected $java = null;

    /**
     * Configure client
     *
     * @param   string  $path
     * @param   string  $java
     *
     * @throws Exception
     */
    public function __construct($path = null, $java = null)
    {
        parent::__construct();

        if($path)
        {
            $this->setPath($path);
        }

        if($java)
        {
            $this->setJava($java);
        }

        if(self::$check === true)
        {
            $this->check();
        }
    }

    /**
     * Get the path
     *
     * @return  null|string
     */
    public function getPath()
    {
        return $this->path;
    }

    /**
     * Set the path
     *
     * @param   string  $path
     * @return  $this
     */
    public function setPath($path)
    {
        $this->path = $path;

        return $this;
    }

    /**
     * Get the Java path
     *
     * @return  null|int
     */
    public function getJava()
    {
        return $this->java;

    }

    /**
     * Set the Java path
     *
     * @param   string    $java
     * @return  $this
     */
    public function setJava($java)
    {
        $this->java = $java;

        return $this;
    }

    /**
     * Check Java binary, JAR path or server connection
     *
     * @return  void
     * @throws  \Exception
     */
    public function check()
    {
        if(self::isChecked() === false)
        {
            // Java command must not return an error
            try
            {
                $this->exec(($this->java ?: 'java') . ' -version');
            }
            catch(Exception $exception)
            {
                throw new Exception('Java command not found');
            }

            // JAR path must exists
            if(file_exists($this->path) === false)
            {
                throw new Exception('Apache Tika app JAR not found');
            }

            self::setChecked(true);
        }
    }

    /**
     * Configure and make a request and return its results
     *
     * @param   string  $type
     * @param   string  $file
     * @return  string|\Vaites\ApacheTika\Metadata\Metadata
     * @throws  \Exception
     */
    public function request($type, $file = null)
    {
        // check if not checked
        $this->check();

        // check if is cached
        if($this->isCached($type, $file))
        {
            return $this->getCachedResponse($type, $file);
        }

        // command arguments
        $arguments = $this->getArguments($type, $file);

        // check the request
        $file = parent::checkRequest($type, $file);

        // add last argument
        if($file)
        {
            $arguments[] = escapeshellarg($file);
        }

        // build command
        $jar = escapeshellarg($this->path);
        $command = ($this->java ?: 'java') . " -jar $jar " . implode(' ', $arguments);

        // run command
        $response = $this->exec($command);

        // metadata response
        if($type == 'meta')
        {
            // fix for invalid? json returned only with images
            $response = str_replace(basename($file) . '"}{', '", ', $response);

            // on Windows, response comes in another charset
            if($this->platform == 'win')
            {
                $response = utf8_encode($response);
            }

            $response = Metadata::make($response, $file);
        }

        // cache certain responses
        if($this->isCacheable($type))
        {
            $this->cacheResponse($type, $response, $file);
        }

        return $response;
    }

    /**
     * Run the command and return its results
     *
     * @param   string  $command
     * @return  null|string
     * @throws  \Exception
     */
    public function exec($command)
    {
        // run command
        $exit = -1;
        $logfile = sys_get_temp_dir() . DIRECTORY_SEPARATOR . 'tika-error.log';
        $descriptors = [['pipe', 'r'], ['pipe', 'w'], ['file', $logfile, 'a']];
        $process = proc_open($command, $descriptors, $pipes);
        $callback = $this->callback;

        // get output if command runs ok
        if(is_resource($process))
        {
            fclose($pipes[0]);
            $this->response = '';
            while($chunk = stream_get_line($pipes[1], $this->chunkSize))
            {
                if(!is_null($callback))
                {
                    $callback($chunk);
                }

                $this->response .= $chunk;
            }
            fclose($pipes[1]);
            $exit = proc_close($process);
        }

        // exception if exit value is not zero
        if($exit > 0)
        {
            throw new Exception("Unexpected exit value ($exit) for command $command");
        }

        return trim($this->response);
    }

    /**
     * Get the arguments to run the command
     *
     * @param   string  $type
     * @param   string  $file
     * @return  array
     * @throws  Exception
     */
    protected function getArguments($type, $file = null)
    protected function getArguments($type, /** @scrutinizer ignore-unused */ $file = null)
    {
        // parameters for command
        $arguments = [];
        switch($type)
        {
            case 'html':
                $arguments[] = '--html';
                break;

            case 'lang':
                $arguments[] = '--language';
                break;

            case 'mime':
                $arguments[] = '--detect';
                break;

            case 'meta':
                $arguments[] = '--metadata --json';
                break;

            case 'rmeta/ignore':
            case 'rmeta/html':
            case 'rmeta/text':
                throw new Exception('Recursive metadata is not supported in command line mode');
                break;

            case 'text':
                $arguments[] = '--text';
                break;

            case 'text-main':
                $arguments[] = '--text-main';
                break;

            case 'mime-types':
                $arguments[] = '--list-supported-types';
                break;

            case 'detectors':
                $arguments[] = '--list-detectors';
                break;

            case 'parsers':
                $arguments[] = '--list-parsers';
                break;

            case 'version':
                $arguments[] = '--version';
                break;

            default:
                throw new Exception("Unknown type $type");
        }

        return $arguments;
    }
}

vaites / php-apache-tika

Push — master ( daf5ec...c13cfb )

CLIClient::getArguments() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
