Issues in VendorSource.php (master) - Issues in master - vaimo/composer-patches - Measure and Improve Code Quality continuously with Scrutinizer

Issues (13)

src/Sources/VendorSource.php (1 issue)

Labels

Severity

Major 1

<?php
/**
 * Copyright © Vaimo Group. All rights reserved.
 * See LICENSE_VAIMO.txt for license details.
 */
namespace Vaimo\ComposerPatches\Sources;

use Composer\Repository\WritableRepositoryInterface;
use Composer\Package\PackageInterface;

use Vaimo\ComposerPatches\Composer\Constants as ComposerConstants;

class VendorSource implements \Vaimo\ComposerPatches\Interfaces\PatchSourceListInterface
{
    /**
     * @var array
     */
    private $vendors;

    /**
     * @param array $vendors
     */
    public function __construct(
        array $vendors = array()
    ) {
        $this->vendors = $vendors;
    }

    public function getItems(WritableRepositoryInterface $repository)
    {
        $packages = $repository->getPackages();

        if (empty($this->vendors)) {
            return $packages;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        }

        $allowedVendors = array_fill_keys($this->vendors, true);
        return array_filter(
            $packages,
            function (PackageInterface $package) use ($allowedVendors) {
                $vendorName = strtok($package->getName(), ComposerConstants::PACKAGE_SEPARATOR);

                return isset($allowedVendors[$vendorName]);
            }
        );
    }
}


1			<?php
2			/**
3			* Copyright © Vaimo Group. All rights reserved.
4			* See LICENSE_VAIMO.txt for license details.
5			*/
6			namespace Vaimo\ComposerPatches\Sources;
7
8			use Composer\Repository\WritableRepositoryInterface;
9			use Composer\Package\PackageInterface;
10
11			use Vaimo\ComposerPatches\Composer\Constants as ComposerConstants;
12
13			class VendorSource implements \Vaimo\ComposerPatches\Interfaces\PatchSourceListInterface
14			{
15			/**
16			* @var array
17			*/
18			private $vendors;
19
20			/**
21			* @param array $vendors
22			*/
23			public function __construct(
24			array $vendors = array()
25			) {
26			$this->vendors = $vendors;
27			}
28
29			public function getItems(WritableRepositoryInterface $repository)
30			{
31			$packages = $repository->getPackages();
32
33			if (empty($this->vendors)) {
34			return $packages;
			0 ignored issues – show Bug Best Practice introduced 2019-09-24 13:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $packages` returns the type `Composer\Package\PackageInterface[]` which is incompatible with the return type mandated by `Vaimo\ComposerPatches\In...stInterface::getItems()` of `array<mixed,string[]>`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
35			}
36
37			$allowedVendors = array_fill_keys($this->vendors, true);
38			return array_filter(
39			$packages,
40			function (PackageInterface $package) use ($allowedVendors) {
41			$vendorName = strtok($package->getName(), ComposerConstants::PACKAGE_SEPARATOR);
42
43			return isset($allowedVendors[$vendorName]);
44			}
45			);
46			}
47			}
48

vaimo / composer-patches

Issues (13)

src/Sources/VendorSource.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like