Issues in ProjectSource.php (master) - Issues in master - vaimo/composer-patches - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

src/Sources/ProjectSource.php (1 issue)

Labels

Severity

Major 1

<?php
/**
 * Copyright © Vaimo Group. All rights reserved.
 * See LICENSE_VAIMO.txt for license details.
 */
namespace Vaimo\ComposerPatches\Sources;

class ProjectSource implements \Vaimo\ComposerPatches\Interfaces\PatchSourceListInterface
{
    /**
     * @var \Composer\Package\RootPackageInterface
     */
    private $rootPackage;

    /**
     * @param \Composer\Package\RootPackageInterface $rootPackage
     */
    public function __construct(
        \Composer\Package\RootPackageInterface $rootPackage
    ) {
        $this->rootPackage = $rootPackage;
    }

    public function getItems(\Composer\Repository\WritableRepositoryInterface $repository)
    {
        return array($this->rootPackage);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2			/**
3			* Copyright © Vaimo Group. All rights reserved.
4			* See LICENSE_VAIMO.txt for license details.
5			*/
6			namespace Vaimo\ComposerPatches\Sources;
7
8			class ProjectSource implements \Vaimo\ComposerPatches\Interfaces\PatchSourceListInterface
9			{
10			/**
11			* @var \Composer\Package\RootPackageInterface
12			*/
13			private $rootPackage;
14
15			/**
16			* @param \Composer\Package\RootPackageInterface $rootPackage
17			*/
18			public function __construct(
19			\Composer\Package\RootPackageInterface $rootPackage
20			) {
21			$this->rootPackage = $rootPackage;
22			}
23
24			public function getItems(\Composer\Repository\WritableRepositoryInterface $repository)
25			{
26			return array($this->rootPackage);
			0 ignored issues – show Bug Best Practice introduced 2019-09-24 13:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return array($this->rootPackage)` returns the type `array<integer,Composer\P...e\RootPackageInterface>` which is incompatible with the return type mandated by `Vaimo\ComposerPatches\In...stInterface::getItems()` of `array<mixed,string[]>`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
27			}
28			}
29

vaimo / composer-patches

Issues (18)

src/Sources/ProjectSource.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like