| Conditions | 1 |
| Paths | 1 |
| Total Lines | 62 |
| Code Lines | 48 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 12 | public function getPatcherConfig() |
||
| 13 | { |
||
| 14 | return array( |
||
| 15 | Config::PATCHER_FILE => array(), |
||
| 16 | Config::PATCHER_FILE_DEV => array(), |
||
| 17 | Config::PATCHER_SEARCH => array(), |
||
| 18 | Config::PATCHER_SEARCH_DEV => array(), |
||
| 19 | Config::PATCHER_TARGETS => array(), |
||
| 20 | Config::PATCHER_BASE_PATHS => array(), |
||
| 21 | Config::PATCHER_GRACEFUL => false, |
||
| 22 | Config::PATCHER_FROM_SOURCE => false, |
||
| 23 | Config::PATCHER_FORCE_REAPPLY => false, |
||
| 24 | Config::PATCHER_SECURE_HTTP => true, |
||
| 25 | Config::PATCHER_FORCE_RESET => false, |
||
| 26 | Config::PATCHER_SOURCES => array( |
||
| 27 | 'project' => true, |
||
| 28 | 'packages' => true, |
||
| 29 | 'vendors' => true, |
||
| 30 | ), |
||
| 31 | Config::PATCHER_APPLIERS => array( |
||
| 32 | 'DEFAULT' => array( |
||
| 33 | 'resolver' => array( |
||
| 34 | 'default' => '< which', |
||
| 35 | 'windows' => '< where /F' |
||
| 36 | ) |
||
| 37 | ), |
||
| 38 | 'GIT' => array( |
||
| 39 | 'bin' => '[[resolver]] git', |
||
| 40 | 'ping' => '!cd .. && [[bin]] rev-parse --is-inside-work-tree', |
||
| 41 | 'check' => '[[bin]] apply -p{{level}} --check {{file}}', |
||
| 42 | 'patch' => '[[bin]] apply -p{{level}} {{file}}' |
||
| 43 | ), |
||
| 44 | 'PATCH' => array( |
||
| 45 | 'bin' => '[[resolver]] patch', |
||
| 46 | 'check' => array( |
||
| 47 | 'default' => '[[bin]] -t --verbose -p{{level}} --no-backup-if-mismatch --dry-run < {{file}}', |
||
| 48 | 'bsd' => '[[bin]] -t -p{{level}} --dry-run < {{file}}' |
||
| 49 | ), |
||
| 50 | 'patch' => array( |
||
| 51 | 'default' => '[[bin]] -t -p{{level}} --no-backup-if-mismatch < {{file}}', |
||
| 52 | 'bsd' => '[[bin]] -t -p{{level}} < {{file}}' |
||
| 53 | ) |
||
| 54 | ) |
||
| 55 | ), |
||
| 56 | Config::PATCHER_OPERATIONS => array( |
||
| 57 | 'ping' => 'Usability test', |
||
| 58 | 'bin' => 'Availability test', |
||
| 59 | 'check' => 'Validation', |
||
| 60 | 'patch' => 'Patching' |
||
| 61 | ), |
||
| 62 | Config::PATCHER_FAILURES => array( |
||
| 63 | 'check' => array( |
||
| 64 | 'garbage' => '/(\n|^)Hmm\.\.\. Ignoring the trailing garbage/', |
||
| 65 | 'reversals' => '/(\n|^)Reversed \(or previously applied\) patch detected/' |
||
| 66 | ) |
||
| 67 | ), |
||
| 68 | Config::PATCHER_SEQUENCE => array( |
||
| 69 | Config::PATCHER_APPLIERS => array('PATCH', 'GIT'), |
||
| 70 | Config::PATCHER_OPERATIONS => array('resolver', 'bin', 'ping', 'check', 'patch'), |
||
| 71 | Config::PATCHER_SANITY => array('resolver', 'bin') |
||
| 72 | ), |
||
| 73 | Config::PATCHER_LEVELS => array('0', '1', '2') |
||
| 74 | ); |
||
| 77 |