Conditions | 20 |
Paths | 396 |
Total Lines | 73 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
102 | public function getFilteredQuery() |
||
103 | { |
||
104 | $query = clone $this->queryBuilder; |
||
105 | $columns = &$this->requestParams['columns']; |
||
106 | $c = count($columns); |
||
107 | // Search |
||
108 | if (array_key_exists('search', $this->requestParams)) { |
||
109 | if ($value = trim($this->requestParams['search']['value'])) { |
||
110 | $orX = $query->expr()->orX(); |
||
111 | for ($i = 0; $i < $c; $i++) { |
||
112 | $column = &$columns[$i]; |
||
113 | if ($column['searchable'] == 'true') { |
||
114 | if (array_key_exists($column[$this->columnField], $this->columnAliases)) { |
||
115 | $column[$this->columnField] = $this->columnAliases[$column[$this->columnField]]; |
||
116 | } |
||
117 | if ($this->caseInsensitive) { |
||
118 | $searchColumn = "lower(" . $column[$this->columnField] . ")"; |
||
119 | $orX->add($query->expr()->like($searchColumn, 'lower(:search)')); |
||
120 | } else { |
||
121 | $orX->add($query->expr()->like($column[$this->columnField], ':search')); |
||
122 | } |
||
123 | } |
||
124 | } |
||
125 | if ($orX->count() >= 1) { |
||
126 | $query->andWhere($orX) |
||
127 | ->setParameter('search', "%{$value}%"); |
||
128 | } |
||
129 | } |
||
130 | } |
||
131 | // Filter |
||
132 | for ($i = 0; $i < $c; $i++) { |
||
133 | $column = &$columns[$i]; |
||
134 | $andX = $query->expr()->andX(); |
||
135 | if (($column['searchable'] == 'true') && ($value = trim($column['search']['value']))) { |
||
136 | if (array_key_exists($column[$this->columnField], $this->columnAliases)) { |
||
137 | $column[$this->columnField] = $this->columnAliases[$column[$this->columnField]]; |
||
138 | } |
||
139 | $operator = preg_match('~^\[(?<operator>[=!%<>]+)\].*$~', $value, $matches) ? $matches['operator'] : '='; |
||
140 | if ($this->caseInsensitive) { |
||
141 | $searchColumn = "lower(" . $column[$this->columnField] . ")"; |
||
142 | $filter = "lower(:filter_{$i})"; |
||
143 | } else { |
||
144 | $searchColumn = $column[$this->columnField]; |
||
145 | $filter = ":filter_{$i}"; |
||
146 | } |
||
147 | switch ($operator) { |
||
148 | case '!=': // Not equals; usage: [!=]search_term |
||
149 | $andX->add($query->expr()->neq($searchColumn, $filter)); |
||
150 | break; |
||
151 | case '%': // Like; usage: [%]search_term |
||
152 | $andX->add($query->expr()->like($searchColumn, $filter)); |
||
153 | $value = "%{$value}%"; |
||
154 | break; |
||
155 | case '<': // Less than; usage: [>]search_term |
||
156 | $andX->add($query->expr()->lt($searchColumn, $filter)); |
||
157 | break; |
||
158 | case '>': // Greater than; usage: [<]search_term |
||
159 | $andX->add($query->expr()->gt($searchColumn, $filter)); |
||
160 | break; |
||
161 | case '=': // Equals (default); usage: [=]search_term |
||
162 | default: |
||
163 | $andX->add($query->expr()->eq($searchColumn, $filter)); |
||
164 | break; |
||
165 | } |
||
166 | $query->setParameter("filter_{$i}", $value); |
||
167 | } |
||
168 | if ($andX->count() >= 1) { |
||
169 | $query->andWhere($andX); |
||
170 | } |
||
171 | } |
||
172 | // Done |
||
173 | return $query; |
||
174 | } |
||
175 | |||
279 |
If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:
If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.