Vaened\Searcher\Constraints\Between

Complexity

Total Complexity

2

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	condition()	0	3	1
A	__construct()	0	4	1

<?php
/**
 * Created by enea dhack - 29/12/2019 12:24.
 */

namespace Vaened\Searcher\Constraints;

use Illuminate\Database\Eloquent\Builder;
use Vaened\Searcher\Constraint;
use Vaened\Searcher\Rangeable;

class Between implements Constraint
{
    private Rangeable $range;

    private string $column;

    public function __construct(Rangeable $range, string $column)
    {
        $this->range = $range;
        $this->column = $column;
    }

    public function condition(Builder $builder): Builder
    {
        return $builder->whereBetween($this->column, $this->range->getRange());

The expression return $builder->whereBetween($this->column, $this->range->getRange()) could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

    }
}