Vaened\Searcher\Binding

Complexity

Total Complexity

6

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getName()	0	3	1
A	getConstraints()	0	3	1
A	__construct()	0	4	1
A	unnamed()	0	3	1
A	named()	0	3	1
A	isNamed()	0	3	1

<?php
/**
 * Created by enea dhack - 17/06/2020 17:03.
 */

namespace Vaened\Searcher;

final class Binding
{
    private ?string $name;

    private array $constraints;

    public function __construct(?string $name, array $constraints)
    {
        $this->name = $name;
        $this->constraints = $constraints;
    }

    public static function named(string $name, array $constraints): Binding
    {
        return new static($name, $constraints);
    }

    public static function unnamed(Constraint $constraint): Binding
    {
        return new static(null, [$constraint]);
    }

    public function isNamed(): bool
    {
        return $this->getName() != null;

It seems like you are loosely comparing $this->getName() of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

    }

    public function getName(): ?string
    {
        return $this->name;
    }

    public function getConstraints(): array
    {
        return $this->constraints;
    }
}