ArtistListDataProvider::getArtists() - Code Metrics - Inspection of "Add scrutinizer analysis stage" - uxmp/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( e933de...5ef56a )

by Daniel

created 2023-02-26 13:24 UTC

ArtistListDataProvider::getArtists() A

↳ Parent: ArtistListDataProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	13
ccs	10
cts	10
cp	1
rs	9.9666
cc	2
nc	2
nop	1
crap	2

<?php

declare(strict_types=1);

namespace Uxmp\Core\Component\SubSonic;

use DateTimeInterface;
use Generator;
use Usox\HyperSonic\FeatureSet\V1161\Contract\ArtistListDataProviderInterface;
use Uxmp\Core\Orm\Repository\ArtistRepositoryInterface;

/**
 * Provides the complete list of available artists
 */
final class ArtistListDataProvider implements ArtistListDataProviderInterface
{
    public function __construct(
        private readonly ArtistRepositoryInterface $artistRepository
    ) {
    }

    /**
     * @return array<string>
     *
     * @todo implement stripping of articles (like 'the, el, los, ...')
     */
    public function getIgnoredArticles(): array
    {
        return [];
    }

    /**
     * @return Generator<array{
     *  id: string,
     *  name: string,
     *  coverArtId: string,
     *  artistImageUrl: string,
     *  albumCount: int,
     *  starred: null|DateTimeInterface
     * }>
     */
    public function getArtists(
        ?string $musicFolderId
    ): Generator {
        foreach ($this->artistRepository->findBy([], ['title' => 'ASC']) as $artist) {
            $artistId = $artist->getId();

            yield [
                'id' => (string) $artistId,
                'name' => (string) $artist->getTitle(),
                'artistImageUrl' => '',
                'coverArtId' => 'artist-'.$artistId,
                'albumCount' => $artist->getAlbumCount(),
                'starred' => null,
            ];
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Uxmp\Core\Component\SubSonic;
6
7		use DateTimeInterface;
8		use Generator;
9		use Usox\HyperSonic\FeatureSet\V1161\Contract\ArtistListDataProviderInterface;
10		use Uxmp\Core\Orm\Repository\ArtistRepositoryInterface;
11
12		/**
13		* Provides the complete list of available artists
14		*/
15		final class ArtistListDataProvider implements ArtistListDataProviderInterface
16		{
17	2	public function __construct(
18		private readonly ArtistRepositoryInterface $artistRepository
19		) {
20	2	}
21
22		/**
23		* @return array<string>
24		*
25		* @todo implement stripping of articles (like 'the, el, los, ...')
26		*/
27	1	public function getIgnoredArticles(): array
28		{
29	1	return [];
30		}
31
32		/**
33		* @return Generator<array{
34		* id: string,
35		* name: string,
36		* coverArtId: string,
37		* artistImageUrl: string,
38		* albumCount: int,
39		* starred: null\|DateTimeInterface
40		* }>
41		*/
42	1	public function getArtists(
43		?string $musicFolderId
44		): Generator {
45	1	foreach ($this->artistRepository->findBy([], ['title' => 'ASC']) as $artist) {
46	1	$artistId = $artist->getId();
47
48	1	yield [
49	1	'id' => (string) $artistId,
50	1	'name' => (string) $artist->getTitle(),
51	1	'artistImageUrl' => '',
52	1	'coverArtId' => 'artist-'.$artistId,
53	1	'albumCount' => $artist->getAlbumCount(),
54	1	'starred' => null,
55	1	];
56		}
57		}
58		}
59

uxmp / core

Push — main ( e933de...5ef56a )

ArtistListDataProvider::getArtists() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like