ArtistCache::retrieve() - Code Metrics - Inspection of "Add scrutinizer analysis stage" - uxmp/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( e933de...5ef56a )

by Daniel

created 2023-02-26 13:24 UTC

ArtistCache::retrieve() A

↳ Parent: ArtistCache

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	3

Importance

Changes

Metric	Value
eloc	11
c	0
b	0
f	0
dl	0
loc	19
ccs	13
cts	13
cp	1
rs	9.9
cc	3
nc	3
nop	1
crap	3

<?php

declare(strict_types=1);

namespace Uxmp\Core\Component\Catalog\Scanner;

use Uxmp\Core\Component\Tag\Container\AudioFileInterface;
use Uxmp\Core\Orm\Model\ArtistInterface;
use Uxmp\Core\Orm\Repository\ArtistRepositoryInterface;

/**
 * Retrieves and caches artists for catalog scanning purposes
 *
 * If no artist was found, a new one will be created
 */
final class ArtistCache implements ArtistCacheInterface
{
    /** @var array<string, ArtistInterface> */
    private array $cache = [];

    public function __construct(
        private readonly ArtistRepositoryInterface $artistRepository,
    ) {
    }

    public function retrieve(AudioFileInterface $audioFile): ArtistInterface
    {
        $artistMbid = $audioFile->getArtistMbid();

        $artist = $this->cache[$artistMbid] ?? null;
        if ($artist === null) {
            $artist = $this->artistRepository->findByMbId($artistMbid);
            if ($artist === null) {
                $artist = $this->artistRepository->prototype()
                    ->setTitle($audioFile->getArtistTitle())
                    ->setMbid($artistMbid)
                ;
                $this->artistRepository->save($artist);
            }

            $this->cache[$artistMbid] = $artist;
        }

        return $artist;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Uxmp\Core\Component\Catalog\Scanner;
6
7		use Uxmp\Core\Component\Tag\Container\AudioFileInterface;
8		use Uxmp\Core\Orm\Model\ArtistInterface;
9		use Uxmp\Core\Orm\Repository\ArtistRepositoryInterface;
10
11		/**
12		* Retrieves and caches artists for catalog scanning purposes
13		*
14		* If no artist was found, a new one will be created
15		*/
16		final class ArtistCache implements ArtistCacheInterface
17		{
18		/** @var array<string, ArtistInterface> */
19		private array $cache = [];
20
21	2	public function __construct(
22		private readonly ArtistRepositoryInterface $artistRepository,
23		) {
24	2	}
25
26	2	public function retrieve(AudioFileInterface $audioFile): ArtistInterface
27		{
28	2	$artistMbid = $audioFile->getArtistMbid();
29
30	2	$artist = $this->cache[$artistMbid] ?? null;
31	2	if ($artist === null) {
32	2	$artist = $this->artistRepository->findByMbId($artistMbid);
33	2	if ($artist === null) {
34	1	$artist = $this->artistRepository->prototype()
35	1	->setTitle($audioFile->getArtistTitle())
36	1	->setMbid($artistMbid)
37	1	;
38	1	$this->artistRepository->save($artist);
39		}
40
41	2	$this->cache[$artistMbid] = $artist;
42		}
43
44	2	return $artist;
45		}
46		}
47

uxmp / core

Push — main ( e933de...5ef56a )

ArtistCache::retrieve() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like