Album::getYear() - Code Metrics - Inspection of "Remove phpstorm Pure attributes" - uxmp/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 0ace76...960e41 )

by Daniel

created 2023-10-30 18:33 UTC

Album::getYear() A

↳ Parent: Album

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Uxmp\Core\Orm\Model;

use DateTimeInterface;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\DBAL\Types\Types;
use Doctrine\ORM\Mapping as ORM;
use Uxmp\Core\Orm\Repository\AlbumRepository;

#[ORM\Table(name: 'album')]
#[ORM\Entity(repositoryClass: AlbumRepository::class)]
class Album implements AlbumInterface
{
    #[ORM\Column(type: Types::INTEGER)]
    #[ORM\Id, ORM\GeneratedValue(strategy: 'AUTO')]
    private int $id;

    #[ORM\Column(type: Types::STRING, nullable: true)]
    private ?string $title = null;

    #[ORM\Column(type: Types::STRING, nullable: true)]
    private ?string $searchTitle = '';

    #[ORM\Column(type: Types::INTEGER)]
    private int $artist_id;


    #[ORM\Column(type: Types::INTEGER)]
    private int $catalog_id;


    #[ORM\Column(type: Types::DATETIME_MUTABLE)]
    private DateTimeInterface $last_modified;

    #[ORM\Column(type: Types::STRING, length: 36, unique: true, nullable: true)]
    private ?string $mbid = null;

    #[ORM\Column(type: Types::INTEGER, nullable: true)]
    private ?int $year = null;

    #[ORM\ManyToOne(targetEntity: ArtistInterface::class, inversedBy: 'albums')]
    #[ORM\JoinColumn(name: 'artist_id', referencedColumnName: 'id', nullable: false, onDelete: 'CASCADE')]
    private ArtistInterface $artist;

    #[ORM\ManyToOne(targetEntity: CatalogInterface::class)]
    #[ORM\JoinColumn(name: 'catalog_id', referencedColumnName: 'id', nullable: false, onDelete: 'CASCADE')]
    private CatalogInterface $catalog;

    /** @var ArrayCollection<int, DiscInterface> */
    #[ORM\OneToMany(mappedBy: 'album', targetEntity: DiscInterface::class, cascade: ['ALL'], indexBy: 'id')]
    #[ORM\OrderBy(['number' => 'ASC'])]
    private iterable $discs;

    public function __construct()
    {
        $this->discs = new ArrayCollection();
    }

    public function getId(): int
    {
        return $this->id;
    }

    public function getTitle(): ?string
    {
        return $this->title;
    }

    public function setTitle(?string $title): AlbumInterface
    {
        $this->title = $title;
        return $this;
    }

    public function getSearchTitle(): string
    {
        return (string) $this->searchTitle;
    }

    public function setSearchTitle(string $searchTitle): AlbumInterface
    {
        $this->searchTitle = $searchTitle;
        return $this;
    }

    public function getArtist(): ArtistInterface
    {
        return $this->artist;
    }

    public function setArtist(ArtistInterface $artist): AlbumInterface
    {
        $this->artist = $artist;
        return $this;
    }

    public function getMbid(): ?string
    {
        return $this->mbid;
    }

    public function setMbid(?string $mbid): AlbumInterface
    {
        $this->mbid = $mbid;
        return $this;
    }

    public function getDiscs(): iterable
    {
        return $this->discs;
    }

    public function getDiscCount(): int
    {
        return $this->discs->count();
    }

    public function addDisc(DiscInterface $disc): AlbumInterface
    {
        $this->discs->add($disc);
        return $this;
    }

    public function getCatalog(): CatalogInterface
    {
        return $this->catalog;
    }

    public function setCatalog(CatalogInterface $catalog): AlbumInterface
    {
        $this->catalog = $catalog;
        return $this;
    }

    public function getLength(): int
    {
        return array_sum(

            array_map(
                static fn (DiscInterface $disc): int => $disc->getLength(),
                $this->discs->toArray()
            )
        );
    }

    public function getSongCount(): int
    {
        return array_sum(

            array_map(
                static fn (DiscInterface $disc): int => $disc->getSongCount(),
                $this->discs->toArray()
            )
        );
    }

    public function getLastModified(): DateTimeInterface
    {
        return $this->last_modified;
    }

    public function setLastModified(DateTimeInterface $last_modified): AlbumInterface
    {
        $this->last_modified = $last_modified;
        return $this;
    }

    public function getYear(): ?int
    {
        return $this->year;
    }

    public function setYear(?int $year): AlbumInterface
    {
        $this->year = $year;
        return $this;
    }

    public function getArtItemType(): string
    {
        return 'album';
    }

    public function getArtItemId(): ?string
    {
        return $this->getMbid();
    }

    public function getType(): FavoriteItemTypeEnum
    {
        return FavoriteItemTypeEnum::ALBUM;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Uxmp\Core\Orm\Model;
6
7		use DateTimeInterface;
8		use Doctrine\Common\Collections\ArrayCollection;
9		use Doctrine\DBAL\Types\Types;
10		use Doctrine\ORM\Mapping as ORM;
11		use Uxmp\Core\Orm\Repository\AlbumRepository;
12
13		#[ORM\Table(name: 'album')]
14		#[ORM\Entity(repositoryClass: AlbumRepository::class)]
15		class Album implements AlbumInterface
16		{
17		#[ORM\Column(type: Types::INTEGER)]
18		#[ORM\Id, ORM\GeneratedValue(strategy: 'AUTO')]
19		private int $id;
20
21		#[ORM\Column(type: Types::STRING, nullable: true)]
22		private ?string $title = null;
23
24		#[ORM\Column(type: Types::STRING, nullable: true)]
25		private ?string $searchTitle = '';
26
27		#[ORM\Column(type: Types::INTEGER)]
28		private int $artist_id;
		0 ignored issues – show introduced 2022-04-10 16:35 UTC by Report Bug Copy Issue Report The private property `$artist_id` is not used, and could be removed. Loading history...
29
30		#[ORM\Column(type: Types::INTEGER)]
31		private int $catalog_id;
		0 ignored issues – show introduced 2021-09-27 20:08 UTC by Report Bug Copy Issue Report The private property `$catalog_id` is not used, and could be removed. Loading history...
32
33		#[ORM\Column(type: Types::DATETIME_MUTABLE)]
34		private DateTimeInterface $last_modified;
35
36		#[ORM\Column(type: Types::STRING, length: 36, unique: true, nullable: true)]
37		private ?string $mbid = null;
38
39		#[ORM\Column(type: Types::INTEGER, nullable: true)]
40		private ?int $year = null;
41
42		#[ORM\ManyToOne(targetEntity: ArtistInterface::class, inversedBy: 'albums')]
43		#[ORM\JoinColumn(name: 'artist_id', referencedColumnName: 'id', nullable: false, onDelete: 'CASCADE')]
44		private ArtistInterface $artist;
45
46		#[ORM\ManyToOne(targetEntity: CatalogInterface::class)]
47		#[ORM\JoinColumn(name: 'catalog_id', referencedColumnName: 'id', nullable: false, onDelete: 'CASCADE')]
48		private CatalogInterface $catalog;
49
50		/** @var ArrayCollection<int, DiscInterface> */
51		#[ORM\OneToMany(mappedBy: 'album', targetEntity: DiscInterface::class, cascade: ['ALL'], indexBy: 'id')]
52		#[ORM\OrderBy(['number' => 'ASC'])]
53		private iterable $discs;
54
55	15	public function __construct()
56		{
57	15	$this->discs = new ArrayCollection();
58		}
59
60		public function getId(): int
61		{
62		return $this->id;
63		}
64
65	1	public function getTitle(): ?string
66		{
67	1	return $this->title;
68		}
69
70	1	public function setTitle(?string $title): AlbumInterface
71		{
72	1	$this->title = $title;
73	1	return $this;
74		}
75
76	1	public function getSearchTitle(): string
77		{
78	1	return (string) $this->searchTitle;
79		}
80
81	1	public function setSearchTitle(string $searchTitle): AlbumInterface
82		{
83	1	$this->searchTitle = $searchTitle;
84	1	return $this;
85		}
86
87	1	public function getArtist(): ArtistInterface
88		{
89	1	return $this->artist;
90		}
91
92	1	public function setArtist(ArtistInterface $artist): AlbumInterface
93		{
94	1	$this->artist = $artist;
95	1	return $this;
96		}
97
98	2	public function getMbid(): ?string
99		{
100	2	return $this->mbid;
101		}
102
103	2	public function setMbid(?string $mbid): AlbumInterface
104		{
105	2	$this->mbid = $mbid;
106	2	return $this;
107		}
108
109	1	public function getDiscs(): iterable
110		{
111	1	return $this->discs;
112		}
113
114	1	public function getDiscCount(): int
115		{
116	1	return $this->discs->count();
117		}
118
119	2	public function addDisc(DiscInterface $disc): AlbumInterface
120		{
121	2	$this->discs->add($disc);
122	2	return $this;
123		}
124
125	1	public function getCatalog(): CatalogInterface
126		{
127	1	return $this->catalog;
128		}
129
130	1	public function setCatalog(CatalogInterface $catalog): AlbumInterface
131		{
132	1	$this->catalog = $catalog;
133	1	return $this;
134		}
135
136	1	public function getLength(): int
137		{
138	1	return array_sum(
		0 ignored issues – show Bug Best Practice introduced 2021-09-10 14:42 UTC by Report Bug Copy Issue Report The expression `return array_sum(array_m...his->discs->toArray()))` could return the type `double` which is incompatible with the type-hinted return `integer`. Consider adding an additional type-check to rule them out. Loading history...
139	1	array_map(
140	1	static fn (DiscInterface $disc): int => $disc->getLength(),
141	1	$this->discs->toArray()
142	1	)
143	1	);
144		}
145
146	1	public function getSongCount(): int
147		{
148	1	return array_sum(
		0 ignored issues – show Bug Best Practice introduced 2022-05-03 18:25 UTC by Report Bug Copy Issue Report The expression `return array_sum(array_m...his->discs->toArray()))` could return the type `double` which is incompatible with the type-hinted return `integer`. Consider adding an additional type-check to rule them out. Loading history...
149	1	array_map(
150	1	static fn (DiscInterface $disc): int => $disc->getSongCount(),
151	1	$this->discs->toArray()
152	1	)
153	1	);
154		}
155
156	1	public function getLastModified(): DateTimeInterface
157		{
158	1	return $this->last_modified;
159		}
160
161	1	public function setLastModified(DateTimeInterface $last_modified): AlbumInterface
162		{
163	1	$this->last_modified = $last_modified;
164	1	return $this;
165		}
166
167	1	public function getYear(): ?int
168		{
169	1	return $this->year;
170		}
171
172	1	public function setYear(?int $year): AlbumInterface
173		{
174	1	$this->year = $year;
175	1	return $this;
176		}
177
178	1	public function getArtItemType(): string
179		{
180	1	return 'album';
181		}
182
183	1	public function getArtItemId(): ?string
184		{
185	1	return $this->getMbid();
186		}
187
188	1	public function getType(): FavoriteItemTypeEnum
189		{
190	1	return FavoriteItemTypeEnum::ALBUM;
191		}
192		}
193

uxmp / core

Push — main ( 0ace76...960e41 )

Album::getYear() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like