FavoriteManager::add() - Code Metrics - Inspection of "Perform automatic refactoring to php 8.1" - uxmp/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 1d1c5b...83bc52 )

by Daniel

created 2022-05-01 11:51 UTC

FavoriteManager::add() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	26
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	15
c	1
b	0
f	1
dl	0
loc	26
ccs	13
cts	13
cp	1
rs	9.7666
cc	2
nc	2
nop	2
crap	2

<?php

declare(strict_types=1);

namespace Uxmp\Core\Component\Favorite;

use Uxmp\Core\Orm\Model\UserInterface;
use Uxmp\Core\Orm\Repository\FavoriteRepositoryInterface;

final class FavoriteManager implements FavoriteManagerInterface
{
    public function __construct(
        private readonly FavoriteRepositoryInterface $favoriteRepository

    ) {
    }

    public function add(
        FavoriteAbleInterface $obj,
        UserInterface $user,
    ): bool {
        $itemId = $obj->getId();
        $type = $obj->getType();

        $favorite = $this->favoriteRepository->findOneBy([
            'user' => $user,
            'item_id' => $itemId,
            'type' => $type,
        ]);

        if ($favorite === null) {
            $favorite = $this->favoriteRepository->prototype()
                ->setUser($user)
                ->setType($type)
                ->setItemId($itemId)
                ->setDate(new \DateTime());

            $this->favoriteRepository->save($favorite);

            return true;
        }

        return false;
    }

    public function remove(
        FavoriteAbleInterface $obj,
        UserInterface $user,
    ): bool {
        $favorite = $this->favoriteRepository->findOneBy([
            'user' => $user,
            'item_id' => $obj->getId(),
            'type' => $obj->getType(),
        ]);

        if ($favorite !== null) {
            $this->favoriteRepository->delete($favorite);

            return true;
        }

        return false;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Uxmp\Core\Component\Favorite;
6
7		use Uxmp\Core\Orm\Model\UserInterface;
8		use Uxmp\Core\Orm\Repository\FavoriteRepositoryInterface;
9
10		final class FavoriteManager implements FavoriteManagerInterface
11		{
12	4	public function __construct(
13		private readonly FavoriteRepositoryInterface $favoriteRepository
		0 ignored issues – show Bug introduced 2022-05-01 11:55 UTC by Report Bug Copy Issue Report A parse error occurred: Syntax error, unexpected T_STRING, expecting T_VARIABLE on line 13 at column 25 Loading history...
14		) {
15		}
16
17	2	public function add(
18		FavoriteAbleInterface $obj,
19		UserInterface $user,
20		): bool {
21	2	$itemId = $obj->getId();
22	2	$type = $obj->getType();
23
24	2	$favorite = $this->favoriteRepository->findOneBy([
25		'user' => $user,
26		'item_id' => $itemId,
27		'type' => $type,
28		]);
29
30	2	if ($favorite === null) {
31	1	$favorite = $this->favoriteRepository->prototype()
32	1	->setUser($user)
33	1	->setType($type)
34	1	->setItemId($itemId)
35	1	->setDate(new \DateTime());
36
37	1	$this->favoriteRepository->save($favorite);
38
39	1	return true;
40		}
41
42	1	return false;
43		}
44
45	2	public function remove(
46		FavoriteAbleInterface $obj,
47		UserInterface $user,
48		): bool {
49	2	$favorite = $this->favoriteRepository->findOneBy([
50		'user' => $user,
51	2	'item_id' => $obj->getId(),
52	2	'type' => $obj->getType(),
53		]);
54
55	2	if ($favorite !== null) {
56	1	$this->favoriteRepository->delete($favorite);
57
58	1	return true;
59		}
60
61	1	return false;
62		}
63		}
64

uxmp / core

Push — main ( 1d1c5b...83bc52 )

FavoriteManager::add() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like