Uxmp\Core\Orm\Model\Album

Complexity

Total Complexity

15

Size/Duplication

Total Lines	137
Duplicated Lines	0 %

Test Coverage

Coverage

7.69%

Importance

Changes

0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	setMbid()	0	4	1
A	setTitle()	0	4	1
A	setLastModified()	0	4	1
A	getDiscCount()	0	3	1
A	getArtist()	0	3	1
A	getMbid()	0	3	1
A	__construct()	0	4	1
A	getLastModified()	0	3	1
A	getDiscs()	0	3	1
A	getId()	0	3	1
A	setCatalog()	0	4	1
A	getCatalog()	0	3	1
A	setArtist()	0	4	1
A	getLength()	0	6	1
A	getTitle()	0	3	1

<?php

declare(strict_types=1);

namespace Uxmp\Core\Orm\Model;

use Doctrine\Common\Collections\ArrayCollection;
use JetBrains\PhpStorm\Pure;

/**
 * @Entity(repositoryClass="\Uxmp\Core\Orm\Repository\AlbumRepository")
 * @Table(name="album")
 */
class Album implements AlbumInterface
{
    /**
     * @Id
     * @Column(type="integer")
     * @GeneratedValue
     */
    private int $id;

    /**
     * @Column(type="string", nullable=true)
     */
    private ?string $title = null;

    /**
     * @Column(type="integer")
     */
    private int $artist_id;

    /**
     * @Column(type="integer")
     */
    private int $catalog_id;

The private property $catalog_id is not used, and could be removed.

    /**
     * @Column(type="datetime")
     */
    private \DateTimeInterface $last_modified;

    /**
     * @Column(type="string", length="32", nullable="true", unique=true)
     */
    private ?string $mbid = null;

    /**
     * @ManyToOne(targetEntity="Artist", inversedBy="albums")
     * @JoinColumn(name="artist_id", referencedColumnName="id", onDelete="CASCADE")
     */
    private ArtistInterface $artist;

    /**
     * @ManyToOne(targetEntity="Catalog")
     * @JoinColumn(name="catalog_id", referencedColumnName="id", onDelete="CASCADE")
     */
    private CatalogInterface $catalog;

    /**
     * @OneToMany(targetEntity="Disc", mappedBy="album", cascade={"ALL"}, indexBy="id")
     *
     * @var ArrayCollection<int, DiscInterface>
     */
    private iterable $discs;

    #[Pure]
    public function __construct()
    {
        $this->discs = new ArrayCollection();
    }

    public function getId(): int
    {
        return $this->id;
    }

    public function getTitle(): ?string
    {
        return $this->title;
    }

    public function setTitle(?string $title): AlbumInterface
    {
        $this->title = $title;
        return $this;
    }

    public function getArtist(): ArtistInterface
    {
        return $this->artist;
    }

    public function setArtist(ArtistInterface $artist): AlbumInterface
    {
        $this->artist = $artist;
        return $this;
    }

    public function getMbid(): ?string
    {
        return $this->mbid;
    }

    public function setMbid(?string $mbid): AlbumInterface
    {
        $this->mbid = $mbid;
        return $this;
    }

    public function getDiscs(): iterable
    {
        return $this->discs;
    }

    public function getDiscCount(): int
    {
        return $this->discs->count();
    }

    public function getCatalog(): CatalogInterface
    {
        return $this->catalog;
    }

    public function setCatalog(CatalogInterface $catalog): AlbumInterface
    {
        $this->catalog = $catalog;
        return $this;
    }

    public function getLength(): int
    {
        return array_sum(

The expression return array_sum(array_map(function(...) { /* ... */ }, $this->discs->toArray())) could return the type double which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

            array_map(
                fn (DiscInterface $disc): int => $disc->getLength(),
                $this->discs->toArray()
            )
        );
    }

    public function getLastModified(): \DateTimeInterface
    {
        return $this->last_modified;
    }

    public function setLastModified(\DateTimeInterface $last_modified): AlbumInterface
    {
        $this->last_modified = $last_modified;
        return $this;
    }
}