Kata\Algorithm\Finder

Complexity

Total Complexity

13

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

97.14%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	find()	0	33	5
A	isFirstPersonMoreYoungerThanSecondPerson()	0	4	1
B	getPeopleComparisonWith()	0	22	6

<?php

declare(strict_types = 1);

namespace Kata\Algorithm;

final class Finder
{
    /** @var Person[] */
    private $people;

    public function __construct(array $a_people)
    {
        $this->people = $a_people;
    }

    public function find(int $birthday_sort): PeopleComparison
    {
        /** @var PeopleComparison[] $people_comparisons */
        $people_comparisons = [];

        for ($i = 0; $i < count($this->people); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            for ($j = $i + 1; $j < count($this->people); $j++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $current_people_comparison = new PeopleComparison();

                $first_person = $this->people[$i];
                $second_person = $this->people[$j];

                if ($this->isFirstPersonMoreYoungerThanSecondPerson($i, $j)) {
                    $current_people_comparison->setFirstPerson($first_person);
                    $current_people_comparison->setSecondPerson($second_person);
                } else {
                    $current_people_comparison->setFirstPerson($second_person);
                    $current_people_comparison->setSecondPerson($first_person);
                }

                $current_people_comparison->setBirthdayDifference($current_people_comparison->secondPerson()->birthDate()->getTimestamp()
                    - $current_people_comparison->firstPerson()->birthDate()->getTimestamp());

                $people_comparisons[] = $current_people_comparison;
            }
        }

        if (empty($people_comparisons)) {
            return new PeopleComparison();
        }

        return $this->getPeopleComparisonWith($birthday_sort, $people_comparisons);
    }

    private function isFirstPersonMoreYoungerThanSecondPerson($first_person_index, $second_person_index): bool
    {
        return $this->people[$first_person_index]->birthDate() < $this->people[$second_person_index]->birthDate();
    }

    private function getPeopleComparisonWith(int $birthday_sort, array $people_comparisons)
    {
        $answer = $people_comparisons[0];

        foreach ($people_comparisons as $result) {
            switch ($birthday_sort) {
                case BirthdaySort::CLOSEST:
                    if ($result->birthdayDifference() < $answer->birthdayDifference()) {
                        $answer = $result;
                    }
                    break;

                case BirthdaySort::FURTHEST:
                    if ($result->birthdayDifference() > $answer->birthdayDifference()) {
                        $answer = $result;
                    }
                    break;
            }
        }

        return $answer;
    }
}