Finder::compareTwoBirthDates() - Code Metrics - Inspection of "Refactorized F to be AgeComparatorResult instead" - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — IncomprehensibleFinder/Edu-Chr... ( 0d3d24...6fe578 )

by Eduard

created 2019-06-13 09:10 UTC

Finder::compareTwoBirthDates() A

↳ Parent: Finder

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	4
cts	4
cp	1
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	2

<?php

declare(strict_types=1);

namespace Kata\Algorithm;

use function count;

final class Finder
{
    /** @var Person[] */
    private $people;

    public function __construct(array $some_people)
    {
        $this->people = $some_people;
    }

    public function find(int $criteria): AgeComparatorResult
    {
        /** @var AgeComparatorResult[] $results */
        $results = [];
        $number_of_people = count($this->people);

        foreach ($this->people as $index => $person) {
            for ($j = $index + 1; $j < $number_of_people; $j++) {
                $results[] = $this->compareTwoBirthDates($person, $j);
            }
        }

        if (count($results) < 1) {
            throw new \InvalidArgumentException('Add at least two people');
        }

        $answer = $results[0];

        foreach ($results as $result) {
            switch ($criteria) {
                case Criteria::CLOSEST:
                    if ($result->age_difference < $answer->age_difference) {
                        $answer = $result;
                    }
                    break;

                case Criteria::FURTHEST:
                    if ($result->age_difference > $answer->age_difference) {
                        $answer = $result;
                    }
                    break;
            }
        }

        return $answer;
    }

    private function compareTwoBirthDates(
        Person $person,
        int $j
    ): AgeComparatorResult{
        if ($person->birthDate() < $this->people[$j]->birthDate()) {
            return new AgeComparatorResult($person, $this->people[$j]);
        }

        return new AgeComparatorResult($this->people[$j], $person);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Kata\Algorithm;
6
7		use function count;
8
9		final class Finder
10		{
11		/** @var Person[] */
12		private $people;
13
14	6	public function __construct(array $some_people)
15		{
16	6	$this->people = $some_people;
17	6	}
18
19	6	public function find(int $criteria): AgeComparatorResult
20		{
21		/** @var AgeComparatorResult[] $results */
22	6	$results = [];
23	6	$number_of_people = count($this->people);
24
25	6	foreach ($this->people as $index => $person) {
26	5	for ($j = $index + 1; $j < $number_of_people; $j++) {
27	4	$results[] = $this->compareTwoBirthDates($person, $j);
28		}
29		}
30
31	6	if (count($results) < 1) {
32	2	throw new \InvalidArgumentException('Add at least two people');
33		}
34
35	4	$answer = $results[0];
36
37	4	foreach ($results as $result) {
38		switch ($criteria) {
39	4	case Criteria::CLOSEST:
40	2	if ($result->age_difference < $answer->age_difference) {
41	1	$answer = $result;
42		}
43	2	break;
44
45	2	case Criteria::FURTHEST:
46	2	if ($result->age_difference > $answer->age_difference) {
47		$answer = $result;
48		}
49	2	break;
50		}
51		}
52
53	4	return $answer;
54		}
55
56	4	private function compareTwoBirthDates(
57		Person $person,
58		int $j
59		): AgeComparatorResult{
60	4	if ($person->birthDate() < $this->people[$j]->birthDate()) {
61	3	return new AgeComparatorResult($person, $this->people[$j]);
62		}
63
64	3	return new AgeComparatorResult($this->people[$j], $person);
65		}
66		}
67

uvinum / php-kata-env

Push — IncomprehensibleFinder/Edu-Chr... ( 0d3d24...6fe578 )

Finder::compareTwoBirthDates() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like