Couple::getYoungerPerson() - Code Metrics - Inspection of "Move some couple generation logic to CoupleCollect..." - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — IncomprehensibleFinder/SandraA... ( c60dee )

by Albert

created 2019-06-13 09:22 UTC

Couple::getYoungerPerson() A

↳ Parent: Couple

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	11
c	0
b	0
f	0
ccs	0
cts	10
cp	0
rs	9.9
cc	2
nc	2
nop	2
crap	6

<?php

declare(strict_types = 1);

namespace Kata\Algorithm;

final class Couple
{
    /** @var Person */
    public $older_person;

    /** @var Person */
    public $younger_person;

    /** @var int */
    public $age_difference;

    public function __construct(
        ?Person $first_person = null,
        ?Person $second_person = null
    ) {
        if (null === $first_person || null === $second_person)
        {
            return;
        }

        $this->older_person = $this->getOlderPerson($first_person, $second_person);
        $this->younger_person = $this->getYoungerPerson($first_person, $second_person);
    }

    private function getOlderPerson(
        Person $first_person,
        Person $second_person
    ) {
        if ($first_person->getBirthDate() < $second_person->getBirthDate())
        {
            return $first_person;

        }

        return $second_person;
    }

    private function getYoungerPerson(
        Person $first_person,
        Person $second_person
    ) {
        if ($first_person->getBirthDate() < $second_person->getBirthDate())
        {
            return $second_person;
        }

        return $first_person;
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			namespace Kata\Algorithm;
6
7			final class Couple
8			{
9			/** @var Person */
10			public $older_person;
11
12			/** @var Person */
13			public $younger_person;
14
15			/** @var int */
16			public $age_difference;
17
18			public function __construct(
19			?Person $first_person = null,
20			?Person $second_person = null
21			) {
22			if (null === $first_person \|\| null === $second_person)
23			{
24			return;
25			}
26
27			$this->older_person = $this->getOlderPerson($first_person, $second_person);
28			$this->younger_person = $this->getYoungerPerson($first_person, $second_person);
29			}
30
31			private function getOlderPerson(
32			Person $first_person,
33			Person $second_person
34			) {
35			if ($first_person->getBirthDate() < $second_person->getBirthDate())
36			{
37			return $first_person;
38
39			}
40
41			return $second_person;
42			}
43
44			private function getYoungerPerson(
45			Person $first_person,
46			Person $second_person
47			) {
48			if ($first_person->getBirthDate() < $second_person->getBirthDate())
49			{
50			return $second_person;
51			}
52
53			return $first_person;
54			}
55			}
56

uvinum / php-kata-env

Push — IncomprehensibleFinder/SandraA... ( c60dee )

Couple::getYoungerPerson() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like