Finder::firstIsOlder() - Code Metrics - Inspection of "Using setters instead of public access to properti..." - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — IncomprehensibleFinder/marcos ( 3df5a7 )

by Marcos

created 2017-03-23 10:03 UTC

Finder::firstIsOlder() A

↳ Parent: Finder

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	2
crap	1

<?php

declare(strict_types = 1);

namespace Kata\Algorithm;

final class Finder
{
    /** @var Person[] */
    private $people;

    public function __construct(array $all_people)
    {
        $this->people = $all_people;
    }

    public function find(int $sorting_type): Comparator
    {
        /** @var Comparator[] $sorted_people_from_older_to_younger */
        $sorted_people_from_older_to_younger = [];

        foreach ($this->people as $index => $person)
        {
            for ($j = $index + 1; $j < count($this->people); $j++)
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            {
                $person_to_compare_with = $this->people[$j];
                $current_couple         = $this->sortFromOlderToYounger($person, $person_to_compare_with);

                $sorted_people_from_older_to_younger[] = $current_couple;
            }
        }

        if (empty($sorted_people_from_older_to_younger))
        {
            return new Comparator();
        }

        $first_couple = $sorted_people_from_older_to_younger[0];

        $sorting_algorithm = $sorting_type == 1 ? SortClosest::class : SortFurthest::class;
        foreach ($sorted_people_from_older_to_younger as $current_couple)
        {
            $first_couple = (new $sorting_algorithm())->__invoke($current_couple, $first_couple);
        }

        return $first_couple;
    }

    /**
     * @param $person
     * @param $person_to_compare_with
     *
     * @return Comparator
     */
    private function sortFromOlderToYounger($person, $person_to_compare_with): Comparator
    {
        $result = new Comparator();
        if ($this->firstIsOlder($person, $person_to_compare_with))
        {
            $result->first_person  = $person;
            $result->second_person = $person_to_compare_with;
        }
        else
        {
            $result->first_person  = $person_to_compare_with;
            $result->second_person = $person;
        }
        $this->addAgeDifference($result);

        return $result;
    }

    /**
     * @param $person
     * @param $person_to_compare_with
     *
     * @return bool
     */
    private function firstIsOlder($person, $person_to_compare_with): bool
    {
        return $person->birthDate < $person_to_compare_with->birthDate;
    }

    private function addAgeDifference($result)
    {
        $result->age_difference = $result->second_person->birthDate->getTimestamp() - $result->first_person->birthDate->getTimestamp();

        return $result;
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace Kata\Algorithm;
6
7		final class Finder
8		{
9		/** @var Person[] */
10		private $people;
11
12	6	public function __construct(array $all_people)
13		{
14	6	$this->people = $all_people;
15	6	}
16
17	6	public function find(int $sorting_type): Comparator
18		{
19		/** @var Comparator[] $sorted_people_from_older_to_younger */
20	6	$sorted_people_from_older_to_younger = [];
21
22	6	foreach ($this->people as $index => $person)
23		{
24	5	for ($j = $index + 1; $j < count($this->people); $j++)
		0 ignored issues – show Performance Best Practice introduced 2017-03-23 10:08 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
25		{
26	4	$person_to_compare_with = $this->people[$j];
27	4	$current_couple = $this->sortFromOlderToYounger($person, $person_to_compare_with);
28
29	4	$sorted_people_from_older_to_younger[] = $current_couple;
30		}
31		}
32
33	6	if (empty($sorted_people_from_older_to_younger))
34		{
35	2	return new Comparator();
36		}
37
38	4	$first_couple = $sorted_people_from_older_to_younger[0];
39
40	4	$sorting_algorithm = $sorting_type == 1 ? SortClosest::class : SortFurthest::class;
41	4	foreach ($sorted_people_from_older_to_younger as $current_couple)
42		{
43	4	$first_couple = (new $sorting_algorithm())->__invoke($current_couple, $first_couple);
44		}
45
46	4	return $first_couple;
47		}
48
49		/**
50		* @param $person
51		* @param $person_to_compare_with
52		*
53		* @return Comparator
54		*/
55	4	private function sortFromOlderToYounger($person, $person_to_compare_with): Comparator
56		{
57	4	$result = new Comparator();
58	4	if ($this->firstIsOlder($person, $person_to_compare_with))
59		{
60	3	$result->first_person = $person;
61	3	$result->second_person = $person_to_compare_with;
62		}
63		else
64		{
65	3	$result->first_person = $person_to_compare_with;
66	3	$result->second_person = $person;
67		}
68	4	$this->addAgeDifference($result);
69
70	4	return $result;
71		}
72
73		/**
74		* @param $person
75		* @param $person_to_compare_with
76		*
77		* @return bool
78		*/
79	4	private function firstIsOlder($person, $person_to_compare_with): bool
80		{
81	4	return $person->birthDate < $person_to_compare_with->birthDate;
82		}
83
84	4	private function addAgeDifference($result)
85		{
86	4	$result->age_difference = $result->second_person->birthDate->getTimestamp() - $result->first_person->birthDate->getTimestamp();
87
88	4	return $result;
89		}
90		}
91

uvinum / php-kata-env

Push — IncomprehensibleFinder/marcos ( 3df5a7 )

Finder::firstIsOlder() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like