BaseItem::getQualityMagnitudeForNextUpdate() - Code Metrics - Inspection of "Add more semantics to `BackstagePass` business rul..." - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — GildedRose/AlbertAndMarcos ( c4eed1 )

by Albert

created 2016-12-15 09:59 UTC

BaseItem::getQualityMagnitudeForNextUpdate() A

↳ Parent: BaseItem

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php
/**
 * Created by PhpStorm.
 * User: albertgarcia
 * Date: 15/12/16
 * Time: 9:58
 */

namespace Kata\GildedRoseKata;

class BaseItem
{
    const DEGRADE_WITH_TIME = true;

    /** @var Item */
    protected $item;

    public function __construct(Item $an_item)
    {
        $this->item = $an_item;
    }

    protected function getQualityMagnitudeForNextUpdate()
    {
        return 1;
    }

    public function updateQualityByDayPassed()
    {
        $this->item->sell_in--;
        if (true === static::DEGRADE_WITH_TIME) {
            $this->item->quality = $this->item->quality - $this->getQualityMagnitudeForNextUpdate();
        }

        if (false === static::DEGRADE_WITH_TIME) {
            $this->item->quality = $this->item->quality + $this->getQualityMagnitudeForNextUpdate();
        }
        $this->validateQualityBoundaries();
    }

    private function validateQualityBoundaries()
    {
        if ($this->item->quality < 0) {
            $this->item->quality = 0;
        }

        if ($this->item->quality > 50) {
            $this->item->quality = 50;
        }
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: albertgarcia
5		* Date: 15/12/16
6		* Time: 9:58
7		*/
8
9		namespace Kata\GildedRoseKata;
10
11		class BaseItem
12		{
13		const DEGRADE_WITH_TIME = true;
14
15		/** @var Item */
16		protected $item;
17
18	15	public function __construct(Item $an_item)
19		{
20	15	$this->item = $an_item;
21	15	}
22
23	4	protected function getQualityMagnitudeForNextUpdate()
24		{
25	4	return 1;
26		}
27
28	13	public function updateQualityByDayPassed()
29		{
30	13	$this->item->sell_in--;
31	13	if (true === static::DEGRADE_WITH_TIME) {
32	7	$this->item->quality = $this->item->quality - $this->getQualityMagnitudeForNextUpdate();
33		}
34
35	13	if (false === static::DEGRADE_WITH_TIME) {
36	6	$this->item->quality = $this->item->quality + $this->getQualityMagnitudeForNextUpdate();
37		}
38	13	$this->validateQualityBoundaries();
39	13	}
40
41	13	private function validateQualityBoundaries()
42		{
43	13	if ($this->item->quality < 0) {
44	3	$this->item->quality = 0;
45		}
46
47	13	if ($this->item->quality > 50) {
48	2	$this->item->quality = 50;
49		}
50	13	}
51		}
52

uvinum / php-kata-env

Push — GildedRose/AlbertAndMarcos ( c4eed1 )

BaseItem::getQualityMagnitudeForNextUpdate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like