Kata\PHP7Kata\LegacyToMigrate

Complexity

Total Complexity

22

Size/Duplication

Total Lines	149
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

91.94%

Importance

Changes

0

18 Methods

Rating	Name	Duplication	Size	Complexity
A	getStringOrNull()	0	4	1
A	sumOfIntegers()	0	4	1
A	arraysSum()	0	6	1
A	getUserName()	0	4	1
A	strcmpFromC()	0	4	1
A	saySomething()	0	7	1
A	divideEnters()	0	4	1
A	searchInText()	0	16	1
A	callingClosures()	0	9	1
A	nothingToReturn()	0	12	2
A	getComposedName()	0	6	1
A	getAllComposedNames()	0	10	2
A	tooMuchExceptionsMakeUglyCode()	0	11	2
A	functionThatFails()	0	4	1
A	anotherFunctionThatAlsoFails()	0	4	1
A	getLastCharOfAString()	0	4	1
A	printForEachValue()	0	10	2
A	doSomethingTooHeavy()	0	4	1

<?php

namespace Kata\PHP7Kata;

use Behat\Testwork\Ordering\Orderer\Orderer;
use Kata\OtherExamples\{
    Example, Form, NotAnExample
};

final class LegacyToMigrate
{
    const ANIMALS = [
        'dog',
        'cat',
        'bird'
    ];

    public function getStringOrNull(?string $param):? string
    {
        return $param;
    }

    public function sumOfIntegers(int ...$ints)
    {
        return array_sum($ints);
    }

    public function arraysSum(array ...$arrays)
    {
        return array_map(function (array $array) {
            return ($array);
        }, $arrays);
    }

    public function getUserName($user): string
    {
        return $user['username'] ?? 'nobody';
    }

    public function strcmpFromC($a, $b)
    {
        return $a <=> $b;
    }

    public function saySomething()
    {
        $example        = new Example();
        $not_an_example = new NotAnExample();

        return $example->greetings() . ' ' . $not_an_example->greetings() . '!';
    }

    public function divideEnters(int $a, int $b)
    {
        return round($a / $b, 0);
    }

    public function searchInText()
    {
        $credit_card = 'daniel:madurell:visa:999888777';

        $credit_card = preg_replace_callback_array([
            '/([a-z]{1})/' => function ($m) {
                return strtoupper($m[1]);
            },
            '/([0-9]{1})/' => function ($m) {

The parameter $m is not used and could be removed.

                return 'XXX';
            }

        ], $credit_card);

        return $credit_card;
    }

    public function callingClosures()
    {
        $form  = new Form(1);
        $form2 = new Form(2);

        $getX = $form->getX();

        return $getX->call($form2);
    }

    public function nothingToReturn(&$left, &$right): void
    {
        if ($left === $right) {
            return;
        }

        $tmp   = $left;
        $left  = $right;
        $right = $tmp;

        return;
    }

    public function getComposedName($data, $number_user) : string
    {
        [$id, $name] = $data[$number_user];

The variable $id does not exist. Did you forget to declare it?

The variable $name does not exist. Did you forget to declare it?

        return $id . '_' . $name;
    }

    public function getAllComposedNames($data)
    {
        $all_composed_names = '';

        foreach ($data as [$id, $name]) {
            $all_composed_names .= $id . '_' . $name . '|';

The variable $id does not exist. Did you forget to declare it?

The variable $name does not exist. Did you forget to declare it?

        }

        return $all_composed_names;
    }

    public function tooMuchExceptionsMakeUglyCode()
    {
        try {
            $this->functionThatFails();
            $this->anotherFunctionThatAlsoFails();
        } catch (SecondException | FirstException $e) {
            return false;
        }

        return true;
    }

    private function functionThatFails()
    {
        throw new FirstException;
    }

    private function anotherFunctionThatAlsoFails()
    {
        throw new SecondException;
    }

    public function getLastCharOfAString(string $a_string): string
    {
        return substr($a_string, -1);
    }

    public function printForEachValue()
    {
        $gen = function () { return yield 1; };

        foreach ($gen() as $key => $value) {
            $this->doSomethingTooHeavy($key, $value);

The call to the method Kata\PHP7Kata\LegacyToMigrate::doSomethingTooHeavy() seems un-needed as the method has no side-effects.

        }

        return $value;

The variable $value seems to be defined by a foreach iteration on line 147. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }

    private function doSomethingTooHeavy($key, $value)

The parameter $key is not used and could be removed.

The parameter $value is not used and could be removed.

    {
        //...
    }
}