City::productShippingRule() - Code Metrics - Inspection of "Initial commit" - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Lonja/xserrat ( 69e2b6 )

by Xavier Serrat

created 2018-03-29 09:38 UTC

City::productShippingRule() A

↳ Parent: City

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3.072

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	4
cts	5
cp	0.8
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	5
nc	3
nop	1
crap	3.072

<?php

namespace Kata;

final class City
{
    private const FIXED_LOAD_COST_IN_EUR = 5;
    private const LOAD_COST_IN_EUR_PER_KM = 2;

    private $name;

    /** @var ShippingRule[] */
    private $shipping_rules;
    private $distance;

    public function __construct(string $a_name, array $some_shipping_rules, int $a_distance)
    {
        $this->name           = $a_name;
        $this->shipping_rules = $some_shipping_rules;
        $this->distance       = $a_distance;
    }

    public function name()
    {
        return $this->name;
    }

    public function productShippingRule(Product $a_product): ?ShippingRule
    {
        foreach ($this->shipping_rules as $current_shipping_rule)
        {
            if ($current_shipping_rule->product()->equalTo($a_product))
            {
                return $current_shipping_rule;
            }
        }

        return null;
    }

    public function loadCost(): int
    {
        return self::FIXED_LOAD_COST_IN_EUR + self::LOAD_COST_IN_EUR_PER_KM * $this->distance;
    }

    public function saleCostEveryThousandKmPercentage(): float
    {
        $percentage = $this->distance / 100 / 100;
        return $percentage;
    }
}


1		<?php
2
3		namespace Kata;
4
5		final class City
6		{
7		private const FIXED_LOAD_COST_IN_EUR = 5;
8		private const LOAD_COST_IN_EUR_PER_KM = 2;
9
10		private $name;
11
12		/** @var ShippingRule[] */
13		private $shipping_rules;
14		private $distance;
15
16	1	public function __construct(string $a_name, array $some_shipping_rules, int $a_distance)
17		{
18	1	$this->name = $a_name;
19	1	$this->shipping_rules = $some_shipping_rules;
20	1	$this->distance = $a_distance;
21	1	}
22
23	1	public function name()
24		{
25	1	return $this->name;
26		}
27
28	1	public function productShippingRule(Product $a_product): ?ShippingRule
29		{
30	1	foreach ($this->shipping_rules as $current_shipping_rule)
31		{
32	1	if ($current_shipping_rule->product()->equalTo($a_product))
33		{
34	1	return $current_shipping_rule;
35		}
36		}
37
38		return null;
39		}
40
41	1	public function loadCost(): int
42		{
43	1	return self::FIXED_LOAD_COST_IN_EUR + self::LOAD_COST_IN_EUR_PER_KM * $this->distance;
44		}
45
46	1	public function saleCostEveryThousandKmPercentage(): float
47		{
48	1	$percentage = $this->distance / 100 / 100;
49	1	return $percentage;
50		}
51		}
52

uvinum / php-kata-env

Push — Lonja/xserrat ( 69e2b6 )

City::productShippingRule() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like