FindCoupleByBirthdayDistance::getBestMatchCouple() - Code Metrics - Inspection of "Refactor models namespaces" - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — IncomprehensibleFinder/base ( 348f7f...2b8e11 )

by Albert

created 2017-03-23 10:02 UTC

FindCoupleByBirthdayDistance::getBestMatchCouple() A

↳ Parent: FindCoupleByBirthdayDistance

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	0
crap	3

<?php

declare(strict_types = 1);

namespace Kata\Algorithm;

use Kata\Algorithm\Model\Couple;
use Kata\Algorithm\Model\CoupleCollection;
use Kata\Algorithm\Model\CoupleEmpty;
use Kata\Algorithm\Model\Person;

final class FindCoupleByBirthdayDistance
{
    /** @var Person[] */
    private $people;

    /** @var CoupleCollection */
    private $couples;

    /** @var BirthdayDistanceCriteria */
    private $birthday_distance_criteria;

    public function __construct(array $people)
    {
        $this->people  = $people;
        $this->couples = CoupleCollection::buildAllPossibleCouplesFromPeopleArray($people);
    }

    public function findByBirthdaysDistance(int $find_criteria): Couple
    {
        if (0 == count($this->couples)) {
            return new CoupleEmpty();
        }

        $this->birthday_distance_criteria = BirthdayDistanceCriteria::fromCriteriaParameter($find_criteria);

        return $this->getBestMatchCouple();
    }

    private function getBestMatchCouple(): Couple
    {
        $selected_couple = $this->couples[0];

        foreach ($this->couples as $current_couple) {
            if ($this->birthday_distance_criteria->isSatisfiedBy($current_couple)->versus($selected_couple)) {
                $selected_couple = $current_couple;
            }
        }

        return $selected_couple;
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace Kata\Algorithm;
6
7		use Kata\Algorithm\Model\Couple;
8		use Kata\Algorithm\Model\CoupleCollection;
9		use Kata\Algorithm\Model\CoupleEmpty;
10		use Kata\Algorithm\Model\Person;
11
12		final class FindCoupleByBirthdayDistance
13		{
14		/** @var Person[] */
15		private $people;
16
17		/** @var CoupleCollection */
18		private $couples;
19
20		/** @var BirthdayDistanceCriteria */
21		private $birthday_distance_criteria;
22
23	6	public function __construct(array $people)
24		{
25	6	$this->people = $people;
26	6	$this->couples = CoupleCollection::buildAllPossibleCouplesFromPeopleArray($people);
27	6	}
28
29	6	public function findByBirthdaysDistance(int $find_criteria): Couple
30		{
31	6	if (0 == count($this->couples)) {
32	2	return new CoupleEmpty();
33		}
34
35	4	$this->birthday_distance_criteria = BirthdayDistanceCriteria::fromCriteriaParameter($find_criteria);
36
37	4	return $this->getBestMatchCouple();
38		}
39
40	4	private function getBestMatchCouple(): Couple
41		{
42	4	$selected_couple = $this->couples[0];
43
44	4	foreach ($this->couples as $current_couple) {
45	4	if ($this->birthday_distance_criteria->isSatisfiedBy($current_couple)->versus($selected_couple)) {
46	4	$selected_couple = $current_couple;
47		}
48		}
49
50	4	return $selected_couple;
51		}
52		}
53

uvinum / php-kata-env

Push — IncomprehensibleFinder/base ( 348f7f...2b8e11 )

FindCoupleByBirthdayDistance::getBestMatchCouple() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like