BirthdayDistanceCriteria::versus() - Code Metrics - Inspection of "Refactor models namespaces" - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — IncomprehensibleFinder/base ( 348f7f...2b8e11 )

by Albert

created 2017-03-23 10:02 UTC

BirthdayDistanceCriteria::versus() A

↳ Parent: BirthdayDistanceCriteria

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.0416

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	6
cp	0.8333
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	5
nc	3
nop	1
crap	3.0416

<?php

declare(strict_types = 1);

namespace Kata\Algorithm;

use Kata\Algorithm\Model\Couple;

final class BirthdayDistanceCriteria
{
    const CLOSEST_BIRTHDAY = 1;
    const FURTHEST_BIRTHDAY = 2;

    /** @var int */
    private $criteria;

    /** @var Couple */
    private $first_couple;

    private function __construct(int $criteria)
    {
        $this->criteria = $criteria;
    }

    public static function fromCriteriaParameter(int $criteria): BirthdayDistanceCriteria
    {
        if (!in_array($criteria, [self::CLOSEST_BIRTHDAY, self::FURTHEST_BIRTHDAY])) {
            throw new \InvalidArgumentException('Criteria ' . $criteria . ' is invalid.');
        }

        return new self($criteria);
    }

    public function isSatisfiedBy(Couple $first_couple)
    {
        $this->first_couple = $first_couple;

        return $this;
    }

    public function versus(Couple $second_couple): bool
    {
        if (self::CLOSEST_BIRTHDAY === $this->criteria) {
            return $this->first_couple->hasLessDistanceThan($second_couple);
        }

        if (self::FURTHEST_BIRTHDAY === $this->criteria) {
            return $this->first_couple->hasGreaterDistanceThan($second_couple);
        }
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace Kata\Algorithm;
6
7		use Kata\Algorithm\Model\Couple;
8
9		final class BirthdayDistanceCriteria
10		{
11		const CLOSEST_BIRTHDAY = 1;
12		const FURTHEST_BIRTHDAY = 2;
13
14		/** @var int */
15		private $criteria;
16
17		/** @var Couple */
18		private $first_couple;
19
20	4	private function __construct(int $criteria)
21		{
22	4	$this->criteria = $criteria;
23	4	}
24
25	4	public static function fromCriteriaParameter(int $criteria): BirthdayDistanceCriteria
26		{
27	4	if (!in_array($criteria, [self::CLOSEST_BIRTHDAY, self::FURTHEST_BIRTHDAY])) {
28		throw new \InvalidArgumentException('Criteria ' . $criteria . ' is invalid.');
29		}
30
31	4	return new self($criteria);
32		}
33
34	4	public function isSatisfiedBy(Couple $first_couple)
35		{
36	4	$this->first_couple = $first_couple;
37
38	4	return $this;
39		}
40
41	4	public function versus(Couple $second_couple): bool
42		{
43	4	if (self::CLOSEST_BIRTHDAY === $this->criteria) {
44	2	return $this->first_couple->hasLessDistanceThan($second_couple);
45		}
46
47	2	if (self::FURTHEST_BIRTHDAY === $this->criteria) {
48	2	return $this->first_couple->hasGreaterDistanceThan($second_couple);
49		}
50		}
51		}
52

uvinum / php-kata-env

Push — IncomprehensibleFinder/base ( 348f7f...2b8e11 )

BirthdayDistanceCriteria::versus() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like