View GitHub Repository php-kata-env

Schedule Inspection
Subscribe
Completed
Push — GildedRose/edu-dani ( e1f431 )
by Albert
04:13
created

SulfurasItem::createSulfurasItem()   A

↳ Parent: SulfurasItem

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 2
CRAP Score 1

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 0
loc 4
ccs 2
cts 2
cp 1
rs 10
cc 1
eloc 2
nc 1
nop 1
crap 1
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace Kata\GildedRoseKata;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
final class SulfurasItem

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
    public $name;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
    public $item;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
    const NAME = "Sulfuras, Hand of Ragnaros";

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                             2                         
                
                
                
    public static function createSulfurasItem($item)

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                             2                         
                
                
                
        return new self(self::NAME, $item);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Unused Code
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The call to SulfurasItem::__construct() has too many arguments starting with self::NAME.
                                                                                                                                                    

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check compares calls to functions or methods with their respective definitions.
If the call has more arguments than are defined, it raises an issue.


If a function is defined several times with a different number of parameters, the
check may pick up the wrong definition and report false positives. One codebase
where this has been known to happen is Wordpress.


In this case you can add the @ignore
PhpDoc
annotation to the duplicate definition and it will be ignored.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
}