GildedRose::incrementQuality() - Code Metrics - Inspection of "Start pollymorfirsm: 2nd iteration, composition ov..." - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — GildedRose/edu-dani ( e1f431 )

by Albert

created 2017-03-23 00:52 UTC

GildedRose::incrementQuality() A

↳ Parent: GildedRose

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3.0175

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
ccs	7
cts	8
cp	0.875
rs	9.4285
cc	3
eloc	7
nc	3
nop	1
crap	3.0175

<?php

namespace Kata\GildedRoseKata;

class GildedRose
{

    private $items;

    function __construct($items)

    {
        $this->items = $items;
    }

    function update_quality()

    {
        foreach ($this->items as $item)
        {
            $new_item = $this->factory_method($item);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if ($item->name != 'Aged Brie' and $item->name != 'Backstage passes to a TAFKAL80ETC concert')
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            {
                $this->decrementQualityOneUnitIfItemNameIsNotSulfuras($item);
            }
            else
            {
                $this->incrementQuality($item);
            }

            if ($item->name != 'Sulfuras, Hand of Ragnaros')
            {
                $item->sell_in = $item->sell_in - 1;
            }

            if ($item->sell_in > 0)
            {
                continue;
            }

            if ($item->name == 'Aged Brie')
            {
                $this->increaseQualityByOneUnitWhenQualitySmallerThanFifty($item);
            }

            if ($item->name != 'Backstage passes to a TAFKAL80ETC concert')
            {
                $this->decrementQualityOneUnitIfItemNameIsNotSulfuras($item);
            }
            else
            {
                $item->quality = $item->quality - $item->quality;
            }
        }
    }

    public function increaseQualityByOneUnitWhenQualitySmallerThanFifty($item): void
    {
        if ($item->quality < 50)
        {
            $item->quality = $item->quality + 1;
        }
    }

    public function decrementQualityOneUnitIfItemNameIsNotSulfuras($item): void
    {
        if ($item->quality > 0)
        {
            if ($item->name != 'Sulfuras, Hand of Ragnaros')
            {
                $item->quality = $item->quality - 1;
            }
        }
    }

    public function incrementQuality($item): void
    {
        if ($item->quality >= 50)
        {
            return;
        }

        $item->quality = $item->quality + 1;

        if ($item->name !== 'Backstage passes to a TAFKAL80ETC concert')
        {
            return;
        }

        $this->incrementQualityForBackstagePasses($item);
    }

    private function incrementQualityForBackstagePasses($item): void
    {
        if ($item->sell_in < 11)
        {
            $this->increaseQualityByOneUnitWhenQualitySmallerThanFifty($item);
        }
        if ($item->sell_in < 6)
        {
            $this->increaseQualityByOneUnitWhenQualitySmallerThanFifty($item);
        }
    }

    private function factory_method($item)
    {
        if ($item->name == BackstagePassesItem::NAME)
        {
            $new_item = BackstagePassesItem::createBackstagePasses($item);
        }
        elseif ($item->name == AgedBrieItem::NAME)
        {
            $new_item = AgedBrieItem::createAgedBrieItem($item);
        }
        elseif ($item->name == SulfurasItem::NAME)
        {
            $new_item = SulfurasItem::createSulfurasItem($item);
        }else{
            $new_item = $item;
        }

        return $new_item;
    }
}




uvinum / php-kata-env

Push — GildedRose/edu-dani ( e1f431 )

GildedRose::incrementQuality() A

Complexity

Size

Duplication

Code Coverage

Importance

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like