Kata\GildedRoseKata\GildedRose

Complexity

Total Complexity

24

Size/Duplication

Total Lines	119
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

76.47%

Importance

Changes	3
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	increaseQualityByOneUnitWhenQualitySmallerThanFifty()	0	7	2
A	incrementQuality()	0	16	3
A	incrementQualityForBackstagePasses()	0	11	3
A	factory_method()	0	19	4
C	update_quality()	0	40	8
A	decrementQualityOneUnitIfItemNameIsNotSulfuras()	0	10	3

<?php

namespace Kata\GildedRoseKata;

class GildedRose
{

    private $items;

    function __construct($items)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->items = $items;
    }

    function update_quality()

It is generally recommended to explicitly declare the visibility for methods.

    {
        foreach ($this->items as $item)
        {
            $new_item = $this->factory_method($item);

$new_item is not used, you could remove the assignment.

            if ($item->name != 'Aged Brie' and $item->name != 'Backstage passes to a TAFKAL80ETC concert')

Using logical operators such as and instead of && is generally not recommended.

            {
                $this->decrementQualityOneUnitIfItemNameIsNotSulfuras($item);
            }
            else
            {
                $this->incrementQuality($item);
            }

            if ($item->name != 'Sulfuras, Hand of Ragnaros')
            {
                $item->sell_in = $item->sell_in - 1;
            }

            if ($item->sell_in > 0)
            {
                continue;
            }

            if ($item->name == 'Aged Brie')
            {
                $this->increaseQualityByOneUnitWhenQualitySmallerThanFifty($item);
            }

            if ($item->name != 'Backstage passes to a TAFKAL80ETC concert')
            {
                $this->decrementQualityOneUnitIfItemNameIsNotSulfuras($item);
            }
            else
            {
                $item->quality = $item->quality - $item->quality;
            }
        }
    }

    public function increaseQualityByOneUnitWhenQualitySmallerThanFifty($item): void
    {
        if ($item->quality < 50)
        {
            $item->quality = $item->quality + 1;
        }
    }

    public function decrementQualityOneUnitIfItemNameIsNotSulfuras($item): void
    {
        if ($item->quality > 0)
        {
            if ($item->name != 'Sulfuras, Hand of Ragnaros')
            {
                $item->quality = $item->quality - 1;
            }
        }
    }

    public function incrementQuality($item): void
    {
        if ($item->quality >= 50)
        {
            return;
        }

        $item->quality = $item->quality + 1;

        if ($item->name !== 'Backstage passes to a TAFKAL80ETC concert')
        {
            return;
        }

        $this->incrementQualityForBackstagePasses($item);
    }

    private function incrementQualityForBackstagePasses($item): void
    {
        if ($item->sell_in < 11)
        {
            $this->increaseQualityByOneUnitWhenQualitySmallerThanFifty($item);
        }
        if ($item->sell_in < 6)
        {
            $this->increaseQualityByOneUnitWhenQualitySmallerThanFifty($item);
        }
    }

    private function factory_method($item)
    {
        if ($item->name == BackstagePassesItem::NAME)
        {
            $new_item = BackstagePassesItem::createBackstagePasses($item);
        }
        elseif ($item->name == AgedBrieItem::NAME)
        {
            $new_item = AgedBrieItem::createAgedBrieItem($item);
        }
        elseif ($item->name == SulfurasItem::NAME)
        {
            $new_item = SulfurasItem::createSulfurasItem($item);
        }else{
            $new_item = $item;
        }

        return $new_item;
    }
}