Orientation::turn() - Code Metrics - Inspection of "Basic functionality for Rover and related componen..." - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Rover/albertg ( 3c48fc )

by Albert

created 2018-09-14 11:04 UTC

Orientation::turn() C

↳ Parent: Orientation

Complexity

Conditions	17
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	35.496

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	6
cts	10
cp	0.6
rs	5.2166
c	0
b	0
f	0
cc	17
nc	5
nop	1
crap	35.496

How to fix Complexity

<?php

namespace Kata\Rover\Domain\Model;

class Orientation

{
    private $orientation;

    private function __construct(string $orientation)
    {
        $this->orientation = $orientation;
    }

    public static function NORTH(): Orientation
    {
        return new self('N');
    }

    public static function SOUTH(): Orientation
    {
        return new self('S');
    }

    public static function EAST(): Orientation
    {
        return new self('E');
    }

    public static function WEST(): Orientation
    {
        return new self('W');
    }

    public function isNorth(): bool
    {
        return $this->orientation === 'N';
    }

    public function isSouth(): bool
    {
        return $this->orientation === 'S';
    }

    public function isEast(): bool
    {
        return $this->orientation === 'E';
    }

    public function isWest(): bool
    {
        return $this->orientation === 'W';
    }

    public function turn(Movement $movement): Orientation
    {
        if (($movement->isLeft() && $this->isEast()) || ($movement->isRight() && $this->isWest()))
        {
            return self::NORTH();
        }

        if (($movement->isLeft() && $this->isWest()) || ($movement->isRight() && $this->isEast()))
        {
            return self::SOUTH();
        }

        if (($movement->isLeft() && $this->isSouth()) || ($movement->isRight() && $this->isNorth()))
        {
            return self::EAST();
        }

        if (($movement->isLeft() && $this->isNorth()) || ($movement->isRight() && $this->isSouth()))
        {
            return self::WEST();
        }
    }
}

1		<?php
2
3		namespace Kata\Rover\Domain\Model;
4
5		class Orientation
		0 ignored issues – show Coding Style introduced 2018-09-14 11:06 UTC by Report Bug Copy Issue Report Since you have declared the constructor as private, maybe you should also declare the class as final. Loading history...
6		{
7		private $orientation;
8
9	1	private function __construct(string $orientation)
10		{
11	1	$this->orientation = $orientation;
12	1	}
13
14	1	public static function NORTH(): Orientation
15		{
16	1	return new self('N');
17		}
18
19		public static function SOUTH(): Orientation
20		{
21		return new self('S');
22		}
23
24	1	public static function EAST(): Orientation
25		{
26	1	return new self('E');
27		}
28
29		public static function WEST(): Orientation
30		{
31		return new self('W');
32		}
33
34	2	public function isNorth(): bool
35		{
36	2	return $this->orientation === 'N';
37		}
38
39	2	public function isSouth(): bool
40		{
41	2	return $this->orientation === 'S';
42		}
43
44	2	public function isEast(): bool
45		{
46	2	return $this->orientation === 'E';
47		}
48
49	1	public function isWest(): bool
50		{
51	1	return $this->orientation === 'W';
52		}
53
54	1	public function turn(Movement $movement): Orientation
55		{
56	1	if (($movement->isLeft() && $this->isEast()) \|\| ($movement->isRight() && $this->isWest()))
57		{
58	1	return self::NORTH();
59		}
60
61	1	if (($movement->isLeft() && $this->isWest()) \|\| ($movement->isRight() && $this->isEast()))
62		{
63		return self::SOUTH();
64		}
65
66	1	if (($movement->isLeft() && $this->isSouth()) \|\| ($movement->isRight() && $this->isNorth()))
67		{
68	1	return self::EAST();
69		}
70
71		if (($movement->isLeft() && $this->isNorth()) \|\| ($movement->isRight() && $this->isSouth()))
72		{
73		return self::WEST();
74		}
75		}
76		}

uvinum / php-kata-env

Push — Rover/albertg ( 3c48fc )

Orientation::turn() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like