RollType::fromMark() - Code Metrics - Inspection of "[Refactor] Model Bowling game using Game, Frame &..." - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Bowlingkata/Albert ( a8d0e2...ff2053 )

by Albert

created 2016-11-22 23:15 UTC

RollType::fromMark() A

↳ Parent: RollType

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	8
cts	8
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	4
nop	1
crap	4

<?php

namespace Kata\BowlingKata\Domain;

final class RollType
{
    const EMPTY = '-';
    const SPARE = '/';
    const STRIKE = 'X';

    private $type;

    private function __construct($a_type)
    {
        $this->type = $a_type;
    }

    public static function fromMark($a_mark) : self
    {
        if (self::EMPTY == $a_mark) {
            return new self('empty');
        }
        if (self::SPARE == $a_mark) {
            return new self('spare');
        }
        if (self::STRIKE == $a_mark) {
            return new self('strike');
        }

        return new self('default');
    }

    public function isEmpty() : bool
    {
        return 'empty' == $this->type;
    }

    public function isDefault() : bool
    {
        return 'default' == $this->type;
    }

    public function isSpare() : bool
    {
        return 'spare' == $this->type;
    }

    public function isStrike() : bool
    {
        return 'strike' == $this->type;
    }
}


1		<?php
2
3		namespace Kata\BowlingKata\Domain;
4
5		final class RollType
6		{
7		const EMPTY = '-';
8		const SPARE = '/';
9		const STRIKE = 'X';
10
11		private $type;
12
13	38	private function __construct($a_type)
14		{
15	38	$this->type = $a_type;
16	38	}
17
18	38	public static function fromMark($a_mark) : self
19		{
20	38	if (self::EMPTY == $a_mark) {
21	31	return new self('empty');
22		}
23	37	if (self::SPARE == $a_mark) {
24	13	return new self('spare');
25		}
26	36	if (self::STRIKE == $a_mark) {
27	15	return new self('strike');
28		}
29
30	29	return new self('default');
31		}
32
33	35	public function isEmpty() : bool
34		{
35	35	return 'empty' == $this->type;
36		}
37
38	35	public function isDefault() : bool
39		{
40	35	return 'default' == $this->type;
41		}
42
43	35	public function isSpare() : bool
44		{
45	35	return 'spare' == $this->type;
46		}
47
48	35	public function isStrike() : bool
49		{
50	35	return 'strike' == $this->type;
51		}
52		}
53

uvinum / php-kata-env

Push — Bowlingkata/Albert ( a8d0e2...ff2053 )

RollType::fromMark() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like