Frame::addRoll() - Code Metrics - Inspection of "[Refactor] Model Bowling game using Game, Frame &..." - uvinum/php-kata-env - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Bowlingkata/Albert ( a8d0e2...ff2053 )

by Albert

created 2016-11-22 23:15 UTC

Frame::addRoll() A

↳ Parent: Frame

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Kata\BowlingKata\Domain;

final class Frame
{
    const MAX_FRAME_SCORE = 10;
    const MAX_ROLLS_BY_FRAME = 2;

    /** @var Roll[] */
    private $roll_array;

    public function addRoll(Roll $a_roll)
    {
        $this->roll_array[] = $a_roll;
    }

    public function isComplete() : bool
    {
        if (empty($this->roll_array)) {
            return false;
        }

        if (self::MAX_ROLLS_BY_FRAME == count($this->roll_array)) {
            return true;
        }

        if ($this->roll_array[0]->type()->isSpare() || $this->roll_array[0]->type()->isStrike()) {
            return true;
        }

        return false;
    }
}


1		<?php
2
3		namespace Kata\BowlingKata\Domain;
4
5		final class Frame
6		{
7		const MAX_FRAME_SCORE = 10;
8		const MAX_ROLLS_BY_FRAME = 2;
9
10		/** @var Roll[] */
11		private $roll_array;
12
13	34	public function addRoll(Roll $a_roll)
14		{
15	34	$this->roll_array[] = $a_roll;
16	34	}
17
18	34	public function isComplete() : bool
19		{
20	34	if (empty($this->roll_array)) {
21		return false;
22		}
23
24	34	if (self::MAX_ROLLS_BY_FRAME == count($this->roll_array)) {
25	32	return true;
26		}
27
28	34	if ($this->roll_array[0]->type()->isSpare() \|\| $this->roll_array[0]->type()->isStrike()) {
29	14	return true;
30		}
31
32	32	return false;
33		}
34		}
35

uvinum / php-kata-env

Push — Bowlingkata/Albert ( a8d0e2...ff2053 )

Frame::addRoll() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like