Kata\BowlingKata\Domain\Roll

Complexity

Total Complexity

8

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	fromMark()	0	18	4
A	increaseScore()	0	4	1
A	type()	0	4	1
A	score()	0	4	1

<?php

namespace Kata\BowlingKata\Domain;

final class Roll
{
    /** @var string */
    private $mark;

    /** @var int|null */
    private $score;

    /** @var RollType */
    private $type;

    public function __construct(string $a_mark, int $a_score = null)
    {
        $this->mark  = $a_mark;
        $this->score = $a_score;
        $this->type  = RollType::fromMark($a_mark);

It seems like \Kata\BowlingKata\Domain\RollType::fromMark($a_mark) of type object<self> is incompatible with the declared type object<Kata\BowlingKata\Domain\RollType> of property $type.

    }

    public static function fromMark($a_mark)
    {
        $roll_type = RollType::fromMark($a_mark);

        if ($roll_type->isSpare()) {
            return new self($a_mark);
        }

        if ($roll_type->isStrike()) {
            return new self($a_mark, 10);
        }

        if ($roll_type->isEmpty()) {
            return new self($a_mark, 0);
        }

        return new self($a_mark, (int)$a_mark);
    }

    public function increaseScore($a_score)
    {
        $this->score += $a_score;
    }

    public function type() : RollType
    {
        return $this->type;
    }

    public function score() : int
    {
        return $this->score;
    }
}