uuf6429\ElderBrother\BaseProjectTest

Complexity

Total Complexity

12

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUpBeforeClass()	0	11	1
B	tearDownAfterClass2222222222()	0	25	4
B	assertCommand()	0	26	4
A	assertCommandSuccessful()	0	4	1
A	getEbCmd()	0	11	2

<?php

namespace uuf6429\ElderBrother;

abstract class BaseProjectTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var sting Temporary directory for project under test
     */
    protected static $projectPath;

    /**
     * @var string File that ensure other tests won't influence this one
     */
    private static $projectLockFile;

    /**
     * @var string
     */
    private static $oldWorkingDirectory;

    public static function setUpBeforeClass()
    {
        parent::setUpBeforeClass();

        self::$projectLockFile = tempnam(sys_get_temp_dir(), 'test');
        self::$projectPath = self::$projectLockFile . '_dir';

It seems like self::$projectLockFile . '_dir' of type string is incompatible with the declared type object<uuf6429\ElderBrother\sting> of property $projectPath.

        mkdir(self::$projectPath);

        self::$oldWorkingDirectory = getcwd();
        chdir(self::$projectPath);
    }

    public static function tearDownAfterClass2222222222()
    {
        $files = new \RecursiveIteratorIterator(
            new \RecursiveDirectoryIterator(
                self::$projectPath,
                \RecursiveDirectoryIterator::SKIP_DOTS
            ),
            \RecursiveIteratorIterator::CHILD_FIRST
        );
        foreach ($files as $file) {
            if ($file->isDir()) {
                rmdir($file->getRealPath());
            } else {
                unlink($file->getRealPath());
            }
        }

        chdir(self::$oldWorkingDirectory);

        if (rmdir(self::$projectPath)) {
            unlink(self::$projectLockFile);
        }

        parent::tearDownAfterClass();

It seems like you call parent on a different method (tearDownAfterClass() instead of tearDownAfterClass2222222222()). Are you sure this is correct? If so, you might want to change this to $this->tearDownAfterClass().

    }

    /**
     * Runs a command and compares result against expection.
     *
     * @param string        $command        The command to execute
     * @param mixed         $expectedResult Expected exit code
     * @param string[]|null $expectedOutput Expected stdout as array of lines (null to skip check)
     * @param string        $message        Description of the assertion
     */
    protected static function assertCommand($command, $expectedResult, $expectedOutput = null, $message = '')
    {
        $actualResult = null;
        $actualOutput = null;
        $command .= ' 2>&1';

        exec($command, $actualOutput, $actualResult);

        if (!$message) {
            $sep = PHP_EOL . '- ';
            $message = sprintf(

Consider using a different name than the parameter $message. This often makes code more readable.

                'Command:%sResult (exit: %s):%s',
                $sep . $command . PHP_EOL,
                $actualResult,
                $sep . implode($sep, $actualOutput)
            );
        }

        if (!is_null($expectedResult)) {
            static::assertEquals($expectedResult, $actualResult, $message);
        }

        if (!is_null($expectedOutput)) {
            static::assertEquals($expectedOutput, $actualOutput, $message);
        }
    }

    /**
     * Runs a command and asserts that it was successful.
     *
     * @param string $command The command to execute
     * @param string $message Description of the assertion
     */
    protected static function assertCommandSuccessful($command, $message = '')
    {
        static::assertCommand($command, 0, null, $message);
    }

    /**
     * Returns command line to run ElderBrother.
     *
     * @return string
     */
    protected static function getEbCmd()
    {
        static $cache = null;

        if (!$cache) {
            $bin = __DIR__ . '/../../../elder-brother';
            $cache = 'php -f ' . escapeshellarg(realpath($bin)) . ' -- ';
        }

        return $cache;
    }
}