uuf6429\ElderBrother\Action\ActionAbstract

Complexity

Total Complexity

2

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
	getName()	0	1	?
	checkSupport()	0	1	?
	execute()	0	1	?
A	createProgressBar()	0	11	2

<?php

namespace uuf6429\ElderBrother\Action;

use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\NullOutput;
use Symfony\Component\Console\Output\OutputInterface;

abstract class ActionAbstract
{
    /**
     * Returns name of this action (possibly with some extra info).
     *
     * @return string
     */
    abstract public function getName();

    /**
     * Throws an exception when action is not supported (eg: missing lib etc).
     *
     * @throws \Exception
     */
    abstract public function checkSupport();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    /**
     * Execute action for the given parameters.
     *
     * @param InputInterface  $input
     * @param OutputInterface $output
     */
    abstract public function execute(InputInterface $input, OutputInterface $output);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     * @param int             $steps
     *
     * @return ProgressBar
     */
    protected function createProgressBar(InputInterface $input, OutputInterface $output, $steps)
    {
        if ($input->hasOption('no-progress')) {
            $output = new NullOutput();

Consider using a different name than the parameter $output. This often makes code more readable.

        }

        $progress = new ProgressBar($output, $steps);
        $progress->setFormat(' %current%/%max% [%bar%] %percent:3s%% %memory:6s% %message%');
        //$progress->setRedrawFrequency(1);

86% of this comment could be valid code. Did you maybe forget this after debugging?

        return $progress;
    }
}