GitChangeSet::getAllChanges() - Code Metrics - Inspection of "Minor test fix, added test" - uuf6429/elder-brother - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d048e0...15889a )

by Christian

created 2016-11-06 23:41 UTC

GitChangeSet::getAllChanges() A

↳ Parent: GitChangeSet

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace uuf6429\ElderBrother\Change;

class GitChangeSet
{
    /**
     * Returns all files that have been created, changed, moved or deleted.
     *
     * @return FileList
     */
    public static function getAllChanges()
    {
        return static::getFiltered();
    }

    /**
     * Returns only the files created by this changeset.
     *
     * @return FileList
     */
    public static function getAdded()
    {
        return static::getFiltered('A');
    }

    /**
     * Returns files to be deleted by this changeset.
     *
     * @return FileList
     */
    public static function getRemoved()
    {
        return static::getFiltered('D');
    }

    /**
     * Returns all modified files.
     *
     * @return FileList
     */
    public static function getModified()
    {
        return static::getFiltered('M');
    }

    /**
     * Returns all files that have been copied or renmaed by this changeset.
     *
     * @return FileList
     */
    public static function getCopiedOrMoved()
    {
        return static::getFiltered('CR');
    }

    /**
     * Returns all changed files except those that have been deleted.
     *
     * @return FileList
     */
    public static function getAddedCopiedModified()
    {
        return static::getFiltered('ACMR');
    }

    /**
     * @param string|null $filter See https://git-scm.com/docs/git-diff (--diff-filter)
     *
     * @return FileList
     */
    protected static function getFiltered($filter = null)
    {
        return new FileList(
            __METHOD__ . '(' . $filter . ')',
            function () use (&$filter) {
                $output = [];
                $command = 'git diff --cached --name-status';
                if ($filter) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                    $command .= ' --diff-filter=' . escapeshellarg($filter);
                }

                exec($command, $output);

                return array_unique(
                    array_map(
                        function ($line) {
                            return trim(substr($line, 1));
                        },
                        $output
                    )
                );
            }
        );
    }
}


1			<?php
2
3			namespace uuf6429\ElderBrother\Change;
4
5			class GitChangeSet
6			{
7			/**
8			* Returns all files that have been created, changed, moved or deleted.
9			*
10			* @return FileList
11			*/
12			public static function getAllChanges()
13			{
14			return static::getFiltered();
15			}
16
17			/**
18			* Returns only the files created by this changeset.
19			*
20			* @return FileList
21			*/
22			public static function getAdded()
23			{
24			return static::getFiltered('A');
25			}
26
27			/**
28			* Returns files to be deleted by this changeset.
29			*
30			* @return FileList
31			*/
32			public static function getRemoved()
33			{
34			return static::getFiltered('D');
35			}
36
37			/**
38			* Returns all modified files.
39			*
40			* @return FileList
41			*/
42			public static function getModified()
43			{
44			return static::getFiltered('M');
45			}
46
47			/**
48			* Returns all files that have been copied or renmaed by this changeset.
49			*
50			* @return FileList
51			*/
52			public static function getCopiedOrMoved()
53			{
54			return static::getFiltered('CR');
55			}
56
57			/**
58			* Returns all changed files except those that have been deleted.
59			*
60			* @return FileList
61			*/
62			public static function getAddedCopiedModified()
63			{
64			return static::getFiltered('ACMR');
65			}
66
67			/**
68			* @param string\|null $filter See https://git-scm.com/docs/git-diff (--diff-filter)
69			*
70			* @return FileList
71			*/
72			protected static function getFiltered($filter = null)
73			{
74			return new FileList(
75			__METHOD__ . '(' . $filter . ')',
76			function () use (&$filter) {
77			$output = [];
78			$command = 'git diff --cached --name-status';
79			if ($filter) {
			0 ignored issues – show Bug Best Practice introduced 2016-11-06 23:43 UTC by Report Bug Copy Issue Report The expression `$filter` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
80			$command .= ' --diff-filter=' . escapeshellarg($filter);
81			}
82
83			exec($command, $output);
84
85			return array_unique(
86			array_map(
87			function ($line) {
88			return trim(substr($line, 1));
89			},
90			$output
91			)
92			);
93			}
94			);
95			}
96			}
97

uuf6429 / elder-brother

Push — master ( d048e0...15889a )

GitChangeSet::getAllChanges() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like