FileListSqlTest::fileListQueryDataProvider() - Code Metrics - Inspection of "Filter files by SQL content" - uuf6429/elder-brother - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by Christian

created 2016-12-11 11:46 UTC

FileListSqlTest::fileListQueryDataProvider() B

↳ Parent: FileListSqlTest

Complexity

Conditions	6
Paths	1

Size

Total Lines	68
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	68
rs	8.5748
c	0
b	0
f	0
cc	6
eloc	41
nc	1
nop	0

How to fix Long Method

<?php

namespace uuf6429\ElderBrother\Change;

use SqlParser\Statements\TransactionStatement;
use uuf6429\ElderBrother\BaseProjectTest;
use SqlParser\Statements\InsertStatement;

class FileListSqlTest extends BaseProjectTest
{
    public static function setUpBeforeClass()
    {
        parent::setUpBeforeClass();

        /** @noinspection SqlResolve */
        /** @noinspection SqlNoDataSourceInspection */
        foreach (
            [
                'src/Acme/Combinator.php' => '<?php namespace Acme; class Combinator {}',
                'src/Acme/Comparator.php' => '<?php namespace Acme; class Comparator {}',
                'README' => 'Please read me!',
                'sql/AA-000-init.sql' => <<<'SQL'
                    SET NAMES utf8;
                    SET TIME_ZONE='+00:00';
                    SET character set 'utf8';
                    DROP DATABASE IF EXISTS world;
                    CREATE DATABASE world;
SQL
                ,
                'sql/EB-000-schema.sql' => <<<'SQL'
                    CREATE TABLE `City` (
                      `ID` int(11) NOT NULL,
                      `Name` char(35) NOT NULL DEFAULT '',
                      `CountryCode` char(3) NOT NULL DEFAULT '',
                      `District` char(20) NOT NULL DEFAULT '',
                      `Population` int(11) NOT NULL DEFAULT '0'
                    ) ENGINE=MyISAM DEFAULT CHARSET=latin1;
SQL
                ,
                'sql/EB-001-data.sql' => <<<'SQL'
                    INSERT INTO `City` (`ID`, `Name`, `CountryCode`, `District`, `Population`) VALUES
                    (1, 'Kabul', 'AFG', 'Kabol', 1780000),
                    (2, 'Qandahar', 'AFG', 'Qandahar', 237500),
                    (3, 'Herat', 'AFG', 'Herat', 186800),
                    (4, 'Mazar-e-Sharif', 'AFG', 'Balkh', 127800),
                    (5, 'Amsterdam', 'NLD', 'Noord-Holland', 731200),
                    (6, 'Rotterdam', 'NLD', 'Zuid-Holland', 593321),
                    (7, 'Haag', 'NLD', 'Zuid-Holland', 440900),
                    (8, 'Utrecht', 'NLD', 'Utrecht', 234323),
                    (9, 'Eindhoven', 'NLD', 'Noord-Brabant', 201843);
SQL
                ,
                'sql/EB-002-keys-and-fix.sql' => <<<SQL
                    ALTER TABLE `City` ADD PRIMARY KEY (`ID`);
                    UPDATE `City` SET `Name` = "کندهار‎" WHERE `ID` = 2;
SQL
                ,
                'sql/EB-003-more-data.sql' => <<<'SQL'
                    INSERT INTO `City` (`ID`, `Name`, `CountryCode`, `District`, `Population`) VALUES
                    (10,'Tilburg','NLD','Noord-Brabant',193238),
                    (11,'Groningen','NLD','Groningen',172701),
                    (12,'Breda','NLD','Noord-Brabant',160398),
                    (13,'Apeldoorn','NLD','Gelderland',153491);
SQL
                ,
                'sql/EB-004-much-more-data.sql' => <<<'SQL'
                    BEGIN;
                    INSERT INTO `City` (`ID`, `Name`, `CountryCode`, `District`, `Population`) VALUES
                    (14,'Nijmegen','NLD','Gelderland',152463),
                    (15,'Enschede','NLD','Overijssel',149544),
                    (16,'Haarlem','NLD','Noord-Holland',148772),
                    (17,'Almere','NLD','Flevoland',142465),
                    (18,'Arnhem','NLD','Gelderland',138020),
                    (19,'Zaanstad','NLD','Noord-Holland',135621),
                    (20,'´s-Hertogenbosch','NLD','Noord-Brabant',129170),
                    (21,'Amersfoort','NLD','Utrecht',126270),
                    (22,'Maastricht','NLD','Limburg',122087),
                    (23,'Dordrecht','NLD','Zuid-Holland',119811),
                    (24,'Leiden','NLD','Zuid-Holland',117196),
                    (25,'Haarlemmermeer','NLD','Noord-Holland',110722),
                    (26,'Zoetermeer','NLD','Zuid-Holland',110214),
                    (27,'Emmen','NLD','Drenthe',105853),
                    (28,'Zwolle','NLD','Overijssel',105819),
                    (29,'Ede','NLD','Gelderland',101574),
                    (30,'Delft','NLD','Zuid-Holland',95268),
                    (31,'Heerlen','NLD','Limburg',95052),
                    (32,'Alkmaar','NLD','Noord-Holland',92713),
                    (33,'Willemstad','ANT','Curaçao',2345),
                    (34,'Tirana','ALB','Tirana',270000),
                    (35,'Alger','DZA','Alger',2168000);
                    COMMIT;
SQL
                ,
            ] as $filename => $content
        ) {
            if (!is_dir(dirname($filename))) {
                mkdir(dirname($filename), 0755, true);
            }
            file_put_contents($filename, $content);
        }
    }

    /**
     * @param string[] $expectedItems
     * @param \Closure $itemsProvider
     *
     * @dataProvider fileListQueryDataProvider
     */
    public function testFileListQuery($expectedItems, $itemsProvider)
    {
        $baseDir = getcwd();
        $actualItems = array_map(
            function ($file) use ($baseDir) {
                return str_replace([$baseDir . DIRECTORY_SEPARATOR, '\\'], ['', '/'], $file);
            },
            $itemsProvider()
        );
        sort($actualItems);

        $this->assertEquals($expectedItems, $actualItems);
        $this->assertSame($expectedItems, $actualItems);
    }

    /**
     * @return array
     */
    public function fileListQueryDataProvider()
    {
        return [
            'sql that inserts more then 5 records' => [
                '$expectedItems' => [
                    'sql/EB-001-data.sql',
                    'sql/EB-004-much-more-data.sql',
                ],
                '$itemsProvider' => function () {
                    return FullChangeSet::get()->filter(
                        function (FileInfo $file) {
                            $checkStatements = function ($checkStatements, $statements) {
                                foreach ($statements as $statement) {
                                    if ($statement instanceof TransactionStatement) {
                                        if ($checkStatements($checkStatements, $statement->statements)) {
                                            return true;
                                        }
                                    } elseif ($statement instanceof InsertStatement) {
                                        if (count($statement->values) > 5) {
                                            return true;
                                        }
                                    }
                                }

                                return false;
                            };

                            return $checkStatements($checkStatements, $file->getSqlParser()->statements);
                        }
                    )->toArray();
                },
            ],

            'sql with ddl' => [
                '$expectedItems' => [
                    'sql/EB-000-schema.sql',
                    'sql/EB-002-keys-and-fix.sql',
                ],
                '$itemsProvider' => function () {
                    return FullChangeSet::get()->sqlWithDDL()->toArray();
                },
            ],
            'sql with ddl and dml' => [
                '$expectedItems' => [
                    'sql/EB-002-keys-and-fix.sql',
                ],
                '$itemsProvider' => function () {
                    return FullChangeSet::get()->sqlWithDDL()->sqlWithDML()->toArray();
                },
            ],
            'sql without ddl and dml' => [
                '$expectedItems' => [
                    'sql/EB-002-keys-and-fix.sql',
                ],
                '$itemsProvider' => function () {
                    return FullChangeSet::get()->sqlWithoutDDL()->sqlWithoutDML()->toArray();
                },
            ],
            'sql with tcl' => [
                '$expectedItems' => [
                    'sql/EB-004-much-more-data.sql'
                ],
                '$itemsProvider' => function () {
                    return FullChangeSet::get()->sqlWithTCL()->toArray();
                },
            ],
        ];
    }
}


1			<?php
2
3			namespace uuf6429\ElderBrother\Change;
4
5			use SqlParser\Statements\TransactionStatement;
6			use uuf6429\ElderBrother\BaseProjectTest;
7			use SqlParser\Statements\InsertStatement;
8
9			class FileListSqlTest extends BaseProjectTest
10			{
11			public static function setUpBeforeClass()
12			{
13			parent::setUpBeforeClass();
14
15			/** @noinspection SqlResolve */
16			/** @noinspection SqlNoDataSourceInspection */
17			foreach (
18			[
19			'src/Acme/Combinator.php' => '<?php namespace Acme; class Combinator {}',
20			'src/Acme/Comparator.php' => '<?php namespace Acme; class Comparator {}',
21			'README' => 'Please read me!',
22			'sql/AA-000-init.sql' => <<<'SQL'
23			SET NAMES utf8;
24			SET TIME_ZONE='+00:00';
25			SET character set 'utf8';
26			DROP DATABASE IF EXISTS world;
27			CREATE DATABASE world;
28			SQL
29			,
30			'sql/EB-000-schema.sql' => <<<'SQL'
31			CREATE TABLE `City` (
32			`ID` int(11) NOT NULL,
33			`Name` char(35) NOT NULL DEFAULT '',
34			`CountryCode` char(3) NOT NULL DEFAULT '',
35			`District` char(20) NOT NULL DEFAULT '',
36			`Population` int(11) NOT NULL DEFAULT '0'
37			) ENGINE=MyISAM DEFAULT CHARSET=latin1;
38			SQL
39			,
40			'sql/EB-001-data.sql' => <<<'SQL'
41			INSERT INTO `City` (`ID`, `Name`, `CountryCode`, `District`, `Population`) VALUES
42			(1, 'Kabul', 'AFG', 'Kabol', 1780000),
43			(2, 'Qandahar', 'AFG', 'Qandahar', 237500),
44			(3, 'Herat', 'AFG', 'Herat', 186800),
45			(4, 'Mazar-e-Sharif', 'AFG', 'Balkh', 127800),
46			(5, 'Amsterdam', 'NLD', 'Noord-Holland', 731200),
47			(6, 'Rotterdam', 'NLD', 'Zuid-Holland', 593321),
48			(7, 'Haag', 'NLD', 'Zuid-Holland', 440900),
49			(8, 'Utrecht', 'NLD', 'Utrecht', 234323),
50			(9, 'Eindhoven', 'NLD', 'Noord-Brabant', 201843);
51			SQL
52			,
53			'sql/EB-002-keys-and-fix.sql' => <<<SQL
54			ALTER TABLE `City` ADD PRIMARY KEY (`ID`);
55			UPDATE `City` SET `Name` = "کندهار‎" WHERE `ID` = 2;
56			SQL
57			,
58			'sql/EB-003-more-data.sql' => <<<'SQL'
59			INSERT INTO `City` (`ID`, `Name`, `CountryCode`, `District`, `Population`) VALUES
60			(10,'Tilburg','NLD','Noord-Brabant',193238),
61			(11,'Groningen','NLD','Groningen',172701),
62			(12,'Breda','NLD','Noord-Brabant',160398),
63			(13,'Apeldoorn','NLD','Gelderland',153491);
64			SQL
65			,
66			'sql/EB-004-much-more-data.sql' => <<<'SQL'
67			BEGIN;
68			INSERT INTO `City` (`ID`, `Name`, `CountryCode`, `District`, `Population`) VALUES
69			(14,'Nijmegen','NLD','Gelderland',152463),
70			(15,'Enschede','NLD','Overijssel',149544),
71			(16,'Haarlem','NLD','Noord-Holland',148772),
72			(17,'Almere','NLD','Flevoland',142465),
73			(18,'Arnhem','NLD','Gelderland',138020),
74			(19,'Zaanstad','NLD','Noord-Holland',135621),
75			(20,'´s-Hertogenbosch','NLD','Noord-Brabant',129170),
76			(21,'Amersfoort','NLD','Utrecht',126270),
77			(22,'Maastricht','NLD','Limburg',122087),
78			(23,'Dordrecht','NLD','Zuid-Holland',119811),
79			(24,'Leiden','NLD','Zuid-Holland',117196),
80			(25,'Haarlemmermeer','NLD','Noord-Holland',110722),
81			(26,'Zoetermeer','NLD','Zuid-Holland',110214),
82			(27,'Emmen','NLD','Drenthe',105853),
83			(28,'Zwolle','NLD','Overijssel',105819),
84			(29,'Ede','NLD','Gelderland',101574),
85			(30,'Delft','NLD','Zuid-Holland',95268),
86			(31,'Heerlen','NLD','Limburg',95052),
87			(32,'Alkmaar','NLD','Noord-Holland',92713),
88			(33,'Willemstad','ANT','Curaçao',2345),
89			(34,'Tirana','ALB','Tirana',270000),
90			(35,'Alger','DZA','Alger',2168000);
91			COMMIT;
92			SQL
93			,
94			] as $filename => $content
95			) {
96			if (!is_dir(dirname($filename))) {
97			mkdir(dirname($filename), 0755, true);
98			}
99			file_put_contents($filename, $content);
100			}
101			}
102
103			/**
104			* @param string[] $expectedItems
105			* @param \Closure $itemsProvider
106			*
107			* @dataProvider fileListQueryDataProvider
108			*/
109			public function testFileListQuery($expectedItems, $itemsProvider)
110			{
111			$baseDir = getcwd();
112			$actualItems = array_map(
113			function ($file) use ($baseDir) {
114			return str_replace([$baseDir . DIRECTORY_SEPARATOR, '\\'], ['', '/'], $file);
115			},
116			$itemsProvider()
117			);
118			sort($actualItems);
119
120			$this->assertEquals($expectedItems, $actualItems);
121			$this->assertSame($expectedItems, $actualItems);
122			}
123
124			/**
125			* @return array
126			*/
127			public function fileListQueryDataProvider()
128			{
129			return [
130			'sql that inserts more then 5 records' => [
131			'$expectedItems' => [
132			'sql/EB-001-data.sql',
133			'sql/EB-004-much-more-data.sql',
134			],
135			'$itemsProvider' => function () {
136			return FullChangeSet::get()->filter(
137			function (FileInfo $file) {
138			$checkStatements = function ($checkStatements, $statements) {
139			foreach ($statements as $statement) {
140			if ($statement instanceof TransactionStatement) {
141			if ($checkStatements($checkStatements, $statement->statements)) {
142			return true;
143			}
144			} elseif ($statement instanceof InsertStatement) {
145			if (count($statement->values) > 5) {
146			return true;
147			}
148			}
149			}
150
151			return false;
152			};
153
154			return $checkStatements($checkStatements, $file->getSqlParser()->statements);
155			}
156			)->toArray();
157			},
158			],
159
160			'sql with ddl' => [
161			'$expectedItems' => [
162			'sql/EB-000-schema.sql',
163			'sql/EB-002-keys-and-fix.sql',
164			],
165			'$itemsProvider' => function () {
166			return FullChangeSet::get()->sqlWithDDL()->toArray();
167			},
168			],
169			'sql with ddl and dml' => [
170			'$expectedItems' => [
171			'sql/EB-002-keys-and-fix.sql',
172			],
173			'$itemsProvider' => function () {
174			return FullChangeSet::get()->sqlWithDDL()->sqlWithDML()->toArray();
175			},
176			],
177			'sql without ddl and dml' => [
178			'$expectedItems' => [
179			'sql/EB-002-keys-and-fix.sql',
180			],
181			'$itemsProvider' => function () {
182			return FullChangeSet::get()->sqlWithoutDDL()->sqlWithoutDML()->toArray();
183			},
184			],
185			'sql with tcl' => [
186			'$expectedItems' => [
187			'sql/EB-004-much-more-data.sql'
188			],
189			'$itemsProvider' => function () {
190			return FullChangeSet::get()->sqlWithTCL()->toArray();
191			},
192			],
193			];
194			}
195			}
196

uuf6429 / elder-brother

Pull Request — master (#30)

FileListSqlTest::fileListQueryDataProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like